mirror/borg
1
0
Fork 0
mirror of https://github.com/borgbackup/borg.git synced 2025-02-22 22:22:27 +00:00
Code Issues Releases Wiki Activity

xattr: errno ERANGE has different meanings

Browse source
This commit is contained in:
Thomas Waldmann 2016-08-11 21:52:48 +02:00
parent 09dbec99a0
commit 418794f66f
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
borg/xattr.py
View file

@ -18,6 +18,7 @@
def get_buffer(size=None, init=False): def get_buffer(size=None, init=False):
if size is not None: if size is not None:
size = int(size) size = int(size)
assert size < 2 ** 24
if init or len(thread_local.buffer) < size: if init or len(thread_local.buffer) < size:
thread_local.buffer = create_string_buffer(size) thread_local.buffer = create_string_buffer(size)
return thread_local.buffer return thread_local.buffer
@ -96,10 +97,12 @@ class BufferTooSmallError(Exception):
"""the buffer given to an xattr function was too small for the result""" """the buffer given to an xattr function was too small for the result"""
def _check(rv, path=None): def _check(rv, path=None, detect_buffer_too_small=False):
if rv < 0: if rv < 0:
e = get_errno() e = get_errno()
if e == errno.ERANGE: if detect_buffer_too_small and e == errno.ERANGE:
# listxattr and getxattr signal with ERANGE that they need a bigger result buffer.
# setxattr signals this way that e.g. a xattr key name is too long / inacceptable.
raise BufferTooSmallError raise BufferTooSmallError
else: else:
try: try:
@ -119,10 +122,9 @@ def _listxattr_inner(func, path):
while True: while True:
buf = get_buffer(size) buf = get_buffer(size)
try: try:
n = _check(func(path, buf, size), path) n = _check(func(path, buf, size), path, detect_buffer_too_small=True)
except BufferTooSmallError: except BufferTooSmallError:
size *= 2 size *= 2
assert size < 2 ** 20
else: else:
return n, buf.raw return n, buf.raw
@ -135,7 +137,7 @@ def _getxattr_inner(func, path, name):
while True: while True:
buf = get_buffer(size) buf = get_buffer(size)
try: try:
n = _check(func(path, name, buf, size), path) n = _check(func(path, name, buf, size), path, detect_buffer_too_small=True)
except BufferTooSmallError: except BufferTooSmallError:
size *= 2 size *= 2
else: else:
@ -148,7 +150,7 @@ def _setxattr_inner(func, path, name, value):
name = os.fsencode(name) name = os.fsencode(name)
value = value and os.fsencode(value) value = value and os.fsencode(value)
size = len(value) if value else 0 size = len(value) if value else 0
_check(func(path, name, value, size), path) _check(func(path, name, value, size), path, detect_buffer_too_small=False)
if sys.platform.startswith('linux'): # pragma: linux only if sys.platform.startswith('linux'): # pragma: linux only