From 498d4b141e9f71a7b0a9aa00942894d4697e1e47 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Tue, 5 Jul 2016 16:49:50 +0200 Subject: [PATCH] sparse test: fix sparseness assertion in test prep, fixes #1264 use the same condition for the input file as also later for the extracted file. the test preparation sparseness assertion failed on cygwin / ntfs, because the input file uses ~40MB in blocks vs. total_len ~80MB. --- borg/testsuite/archiver.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/borg/testsuite/archiver.py b/borg/testsuite/archiver.py index 126d1c5a5..e8039a611 100644 --- a/borg/testsuite/archiver.py +++ b/borg/testsuite/archiver.py @@ -398,7 +398,7 @@ def test_sparse_file(self): st = os.stat(filename) self.assert_equal(st.st_size, total_len) if sparse_support and hasattr(st, 'st_blocks'): - self.assert_true(st.st_blocks * 512 < total_len / 9) # is input sparse? + self.assert_true(st.st_blocks * 512 < total_len) # is input sparse? self.cmd('init', self.repository_location) self.cmd('create', self.repository_location + '::test', 'input') with changedir('output'): @@ -415,7 +415,7 @@ def test_sparse_file(self): if sparse_support: if hasattr(st, 'st_blocks'): # do only check if it is less, do NOT check if it is much less - # as that causes troubles on xfs and zfs: + # as that causes troubles on xfs, zfs, ntfs: self.assert_true(st.st_blocks * 512 < total_len) if hasattr(os, 'SEEK_HOLE') and hasattr(os, 'SEEK_DATA'): with open(filename, 'rb') as fd: