mirror/borg
1
0
Fork 0
mirror of https://github.com/borgbackup/borg.git synced 2025-01-01 12:45:34 +00:00
Code Issues Releases Wiki Activity

mount: improve mountpoint error msgs, see #7496

Browse source 
saying "must be a writable directory" can distract
from the real root cause as seen in #7496.

so we better first check if the mountpoint is an
existing directory and if not, just tell that.

after that, we check permissions and if they are not
like required, tell that.
This commit is contained in:
Thomas Waldmann 2023-04-04 23:22:30 +02:00
parent 315f312bb2
commit 7eb04b86ed
No known key found for this signature in database
GPG key ID: 243ACFA951F78E01
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/borg/archiver/mount_cmds.py
View file

@ -24,8 +24,12 @@ def do_mount(self, args):
self.print_error("borg mount not available: no FUSE support, BORG_FUSE_IMPL=%s." % BORG_FUSE_IMPL)
return self.exit_code
if not os.path.isdir(args.mountpoint) or not os.access(args.mountpoint, os.R_OK | os.W_OK | os.X_OK):
self.print_error("%s: Mountpoint must be a writable directory" % args.mountpoint)
if not os.path.isdir(args.mountpoint):
self.print_error(f"{args.mountpoint}: Mountpoint must be an **existing directory**")
return self.exit_code
if not os.access(args.mountpoint, os.R_OK | os.W_OK | os.X_OK):
self.print_error(f"{args.mountpoint}: Mountpoint must be a **writable** directory")
return self.exit_code
return self._do_mount(args)