From 80188d3bdf296fae58855efe816d7d9007e298f1 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Sun, 2 Jul 2023 17:25:51 +0200 Subject: [PATCH] remove coala (outdated) last coala release (0.11.0) is now over 6y old. when using pip install coala, a ton of stuff gets installed (expected) and a part of that downgrades some stuff we use to outdated, incompatible versions. when trying to run coala with python 3.11, it just crashes because the last release was made for py35/py36 (as seen in their setup.py). a lot of PRs and tickets pile up at the coala project on github, but noone is maintaining it. --- .coafile | 35 ----------------------------------- MANIFEST.in | 2 +- docs/development.rst | 20 -------------------- requirements.d/coala.txt | 5 ----- 4 files changed, 1 insertion(+), 61 deletions(-) delete mode 100644 .coafile delete mode 100644 requirements.d/coala.txt diff --git a/.coafile b/.coafile deleted file mode 100644 index 625090a1..00000000 --- a/.coafile +++ /dev/null @@ -1,35 +0,0 @@ -[all] -# note: put developer specific settings into ~/.coarc (e.g. editor = ...) -max_line_length = 255 -use_spaces = True -ignore = src/borg/(checksums.c|chunker.c|compress.c|hashindex.c|item.c), - src/borg/crypto/low_level.c, - src/borg/platform/*.c - -[all.general] -files = src/borg/**/*.(py|pyx|c) -bears = SpaceConsistencyBear, FilenameBear, InvalidLinkBear, LineLengthBear -file_naming_convention = snake - -[all.python] -files = src/borg/**/*.py -bears = PyDocStyleBear, PyLintBear -pylint_disable = C0103, C0111, C0112, C0122, C0123, C0301, C0302, C0325, C0330, C0411, C0412, C0413, C1801, - I1101, - W0102, W0104, W0106, W0108, W0120, W0201, W0212, W0221, W0231, W0401, W0404, - W0511, W0603, W0611, W0612, W0613, W0614, W0621, W0622, W0640, W0702, W0703, - W1201, W1202, W1401, - R0101, R0201, R0204, R0901, R0902, R0903, R0904, R0911, R0912, R0913, R0914, R0915, - R0916, R1701, R1704, R1705, R1706, R1710, - E0102, E0202, E0401, E0601, E0611, E0702, E1101, E1102, E1120, E1129, E1130 -pydocstyle_ignore = D100, D101, D102, D103, D104, D105, D200, D201, D202, D203, D204, D205, D209, D210, - D212, D213, D300, D301, D400, D401, D402, D403, D404 - -[all.c] -files = src/borg/**/*.c -bears = CPPCheckBear - -[all.html] -files = src/borg/**/*.html -bears = HTMLLintBear -htmllint_ignore = * diff --git a/MANIFEST.in b/MANIFEST.in index dcbe1854..caf027ad 100644 --- a/MANIFEST.in +++ b/MANIFEST.in @@ -1,7 +1,7 @@ # stuff we need to include into the sdist is handled automatically by # setuptools_scm - it includes all git-committed files. # but we want to exclude some committed files/dirs not needed in the sdist: -exclude .coafile .editorconfig .gitattributes .gitignore .mailmap Vagrantfile +exclude .editorconfig .gitattributes .gitignore .mailmap Vagrantfile prune .github include src/borg/platform/darwin.c src/borg/platform/freebsd.c src/borg/platform/linux.c src/borg/platform/posix.c include src/borg/platform/syncfilerange.c diff --git a/docs/development.rst b/docs/development.rst index eff02309..5db1f6d5 100644 --- a/docs/development.rst +++ b/docs/development.rst @@ -217,26 +217,6 @@ Important notes: - When using ``--`` to give options to py.test, you MUST also give ``borg.testsuite[.module]``. -Running more checks using coala -------------------------------- - -First install coala and some checkers ("bears"): - -:: - - pip install -r requirements.d/coala.txt - -You can now run coala from the toplevel directory; it will read its settings -from ``.coafile`` there: - -:: - - coala - -Some bears have additional requirements and they usually tell you about -them in case they are missing. - - Adding a compression algorithm ------------------------------ diff --git a/requirements.d/coala.txt b/requirements.d/coala.txt deleted file mode 100644 index 86ebea3c..00000000 --- a/requirements.d/coala.txt +++ /dev/null @@ -1,5 +0,0 @@ -# style and other checks for many languages. -# some bears (checkers) have additional requirements. -coala -coala-bears -