RemoteRepository: clean up pipe if remote open() fails

This commit is contained in:
Marian Beermann 2016-04-03 21:44:29 +02:00
parent 425a4d819d
commit 890e44ef60
1 changed files with 6 additions and 1 deletions

View File

@ -81,6 +81,7 @@ class RepositoryServer: # pragma: no cover
unpacker.feed(data) unpacker.feed(data)
for unpacked in unpacker: for unpacked in unpacker:
if not (isinstance(unpacked, tuple) and len(unpacked) == 4): if not (isinstance(unpacked, tuple) and len(unpacked) == 4):
self.repository.close()
raise Exception("Unexpected RPC data format.") raise Exception("Unexpected RPC data format.")
type, msgid, method, args = unpacked type, msgid, method, args = unpacked
method = method.decode('ascii') method = method.decode('ascii')
@ -165,7 +166,11 @@ class RemoteRepository:
raise ConnectionClosedWithHint('Is borg working on the server?') from None raise ConnectionClosedWithHint('Is borg working on the server?') from None
if version != RPC_PROTOCOL_VERSION: if version != RPC_PROTOCOL_VERSION:
raise Exception('Server insisted on using unsupported protocol version %d' % version) raise Exception('Server insisted on using unsupported protocol version %d' % version)
self.id = self.call('open', location.path, create, lock_wait, lock) try:
self.id = self.call('open', self.location.path, create, lock_wait, lock)
except Exception:
self.close()
raise
def __del__(self): def __del__(self):
self.close() self.close()