Merge pull request #4023 from ThomasWaldmann/hostname-fqdn-cleanups-1.1

call socket.gethostname only once
This commit is contained in:
TW 2018-08-09 13:28:00 +02:00 committed by GitHub
commit a38bdd7090
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions

View File

@ -40,7 +40,7 @@ from .helpers import safe_ns
from .helpers import ellipsis_truncate, ProgressIndicatorPercent, log_multi from .helpers import ellipsis_truncate, ProgressIndicatorPercent, log_multi
from .patterns import PathPrefixPattern, FnmatchPattern, IECommand from .patterns import PathPrefixPattern, FnmatchPattern, IECommand
from .item import Item, ArchiveItem from .item import Item, ArchiveItem
from .platform import acl_get, acl_set, set_flags, get_flags, swidth from .platform import acl_get, acl_set, set_flags, get_flags, swidth, hostname
from .remote import cache_if_remote from .remote import cache_if_remote
from .repository import Repository, LIST_SCAN_LIMIT from .repository import Repository, LIST_SCAN_LIMIT
@ -468,7 +468,7 @@ Utilization of max. archive size: {csize_max:.0%}
'comment': comment or '', 'comment': comment or '',
'items': self.items_buffer.chunks, 'items': self.items_buffer.chunks,
'cmdline': sys.argv, 'cmdline': sys.argv,
'hostname': socket.gethostname(), 'hostname': hostname,
'username': getuser(), 'username': getuser(),
'time': start.strftime(ISO_FORMAT), 'time': start.strftime(ISO_FORMAT),
'time_end': end.strftime(ISO_FORMAT), 'time_end': end.strftime(ISO_FORMAT),

View File

@ -664,13 +664,13 @@ def format_line(format, data):
def replace_placeholders(text): def replace_placeholders(text):
"""Replace placeholders in text with their values.""" """Replace placeholders in text with their values."""
from .platform import fqdn from .platform import fqdn, hostname
current_time = datetime.now(timezone.utc) current_time = datetime.now(timezone.utc)
data = { data = {
'pid': os.getpid(), 'pid': os.getpid(),
'fqdn': fqdn, 'fqdn': fqdn,
'reverse-fqdn': '.'.join(reversed(fqdn.split('.'))), 'reverse-fqdn': '.'.join(reversed(fqdn.split('.'))),
'hostname': socket.gethostname(), 'hostname': hostname,
'now': DatetimeWrapper(current_time.astimezone(None)), 'now': DatetimeWrapper(current_time.astimezone(None)),
'utcnow': DatetimeWrapper(current_time), 'utcnow': DatetimeWrapper(current_time),
'user': uid2user(os.getuid(), os.getuid()), 'user': uid2user(os.getuid(), os.getuid()),