From add38e8cdeb4242a64e5939c764ff6a314d85b5b Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Fri, 27 Jan 2017 21:09:55 +0100 Subject: [PATCH] ignore posix_fadvise errors in repository.py, work around #2095 note: we also ignore the call's return value in _chunker.c. both is harmless as the call not working does not cause incorrect function, just worse performance due to constant flooding of the cache (as if we would not issue the call). --- borg/repository.py | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/borg/repository.py b/borg/repository.py index 4c7df2174..e85c33d6f 100644 --- a/borg/repository.py +++ b/borg/repository.py @@ -833,9 +833,19 @@ class LoggedIO: fileno = fd.fileno() os.fsync(fileno) if hasattr(os, 'posix_fadvise'): # only on UNIX - # tell the OS that it does not need to cache what we just wrote, - # avoids spoiling the cache for the OS and other processes. - os.posix_fadvise(fileno, 0, 0, os.POSIX_FADV_DONTNEED) + try: + # tell the OS that it does not need to cache what we just wrote, + # avoids spoiling the cache for the OS and other processes. + os.posix_fadvise(fileno, 0, 0, os.POSIX_FADV_DONTNEED) + except OSError: + # usually, posix_fadvise can't fail for us, but there seem to + # be failures when running borg under docker on ARM, likely due + # to a bug outside of borg. + # also, there is a python wrapper bug, always giving errno = 0. + # https://github.com/borgbackup/borg/issues/2095 + # as this call is not critical for correct function (just to + # optimize cache usage), we ignore these errors. + pass finally: fd.close() if dirname: