mirror/borg
1
0
Fork 0
mirror of https://github.com/borgbackup/borg.git synced 2025-01-03 05:35:58 +00:00
Code Issues Releases Wiki Activity

Revert "docs: Fix grammar in borg mount docs #8510"

Browse source 
This reverts commit d3f3082bf4.

Comment by jdchristensen:

I agree that "wipe clean" is correct grammar, but it doesn't match the situation in "unmount cleanly".
The change in this patch is definitely wrong.
Putting it another way, one would never say that we "clean unmount a filesystem".
We say that we "cleanly unmount a filesystem", or in other words, that it "unmounts cleanly".

But the original text is slightly awkward, so I would propose: "When running in the foreground,
^C/SIGINT cleanly unmounts the filesystem, but other signals or crashes do not."

(Not that this guarantees anything, but I'm a native speaker.)
This commit is contained in:
Thomas Waldmann 2024-11-03 14:00:00 +01:00
parent bef9595463
commit c49a4e20eb
No known key found for this signature in database
GPG key ID: 243ACFA951F78E01
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/borg/archiver/mount_cmds.py
View file

@ -120,7 +120,7 @@ def build_parser_mount_umount(self, subparsers, common_parser, mid_common_parser
Unmounting in these cases could cause an active rsync or similar process Unmounting in these cases could cause an active rsync or similar process
to delete data unintentionally. to delete data unintentionally.
When running in the foreground ^C/SIGINT unmounts clean, but other When running in the foreground ^C/SIGINT unmounts cleanly, but other
signals or crashes do not. signals or crashes do not.
""" """
) )