mirror
/
borg
mirror of https://github.com/borgbackup/borg.git
1
0
Fork 0
Code Issues Releases Wiki Activity

EVP_DecryptFinal_ex: fix check for return value 

seems like the current docs were updated.
was "positive return code".
now specifically mentions 0 and 1.
This commit is contained in:
Thomas Waldmann 2022-03-21 22:36:16 +01:00
parent e1313ccc05
commit ccf0875053
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/borg/crypto/low_level.pyx
View File

@ -313,7 +313,7 @@ cdef class AES256_CTR_BASE:
ilen-hlen-self.mac_len-self.iv_len_short): ilen-hlen-self.mac_len-self.iv_len_short):
raise CryptoError('EVP_DecryptUpdate failed') raise CryptoError('EVP_DecryptUpdate failed')
offset += olen offset += olen
if EVP_DecryptFinal_ex(self.ctx, odata+offset, &olen) <= 0: if not EVP_DecryptFinal_ex(self.ctx, odata+offset, &olen):
raise CryptoError('EVP_DecryptFinal_ex failed') raise CryptoError('EVP_DecryptFinal_ex failed')
offset += olen offset += olen
self.blocks += self.block_count(offset) self.blocks += self.block_count(offset)
@ -705,7 +705,7 @@ cdef class AES:
if not EVP_DecryptUpdate(self.ctx, odata, &olen, <const unsigned char*> idata.buf, ilen): if not EVP_DecryptUpdate(self.ctx, odata, &olen, <const unsigned char*> idata.buf, ilen):
raise Exception('EVP_DecryptUpdate failed') raise Exception('EVP_DecryptUpdate failed')
offset += olen offset += olen
if EVP_DecryptFinal_ex(self.ctx, odata+offset, &olen) <= 0: if not EVP_DecryptFinal_ex(self.ctx, odata+offset, &olen):
# this error check is very important for modes with padding or # this error check is very important for modes with padding or
# authentication. for them, a failure here means corrupted data. # authentication. for them, a failure here means corrupted data.
# CTR mode does not use padding nor authentication. # CTR mode does not use padding nor authentication.