mirror/borg
1
0
Fork 0
mirror of https://github.com/borgbackup/borg.git synced 2024-12-27 18:28:42 +00:00
Code Issues Releases Wiki Activity

refactor/dedup xattr exception handler

Browse source
This commit is contained in:
Thomas Waldmann 2020-12-25 19:30:05 +01:00
parent ecae0841b1
commit d986114e5e
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/borg/xattr.py
View file

@ -133,19 +133,19 @@ def set_all(path, xattrs, follow_symlinks=False):
path_str = '<FD %d>' % path path_str = '<FD %d>' % path
else: else:
path_str = os.fsdecode(path) path_str = os.fsdecode(path)
msg_format = '%s: when setting extended attribute %s: %%s' % (path_str, k_str)
if e.errno == errno.E2BIG: if e.errno == errno.E2BIG:
logger.warning('%s: Value or key of extended attribute %s is too big for this filesystem' % ( err_str = 'too big for this filesystem'
path_str, k_str))
elif e.errno == errno.ENOTSUP: elif e.errno == errno.ENOTSUP:
logger.warning('%s: Extended attributes are not supported on this filesystem' % path_str) err_str = 'xattrs not supported on this filesystem'
elif e.errno == errno.EACCES:
# permission denied to set this specific xattr (this may happen related to security.* keys)
logger.warning('%s: Permission denied when setting extended attribute %s' % (path_str, k_str))
elif e.errno == errno.ENOSPC: elif e.errno == errno.ENOSPC:
# ext4 reports ENOSPC when trying to set an xattr with >4kiB while ext4 can only support 4kiB xattrs # ext4 reports ENOSPC when trying to set an xattr with >4kiB while ext4 can only support 4kiB xattrs
# (in this case, this is NOT a "disk full" error, just a ext4 limitation). # (in this case, this is NOT a "disk full" error, just a ext4 limitation).
logger.warning('%s: No space left on device while setting extended attribute %s (len = %d)' % ( err_str = 'no space left on device [xattr len = %d]' % (len(v),)
path_str, k_str, len(v)))
else: else:
logger.warning('%s: when setting extended attribute %s: %s' % (path_str, k_str, str(e))) # generic handler
# EACCES: permission denied to set this specific xattr (this may happen related to security.* keys)
# EPERM: operation not permitted
err_str = str(e)
logger.warning(msg_format % err_str)
return warning return warning