From d9a1761d0e92e122b4fb243a312f3d97a1e70fe8 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Sat, 27 Apr 2019 08:45:26 -0500 Subject: [PATCH] do not check python/libc for borg serve, fixes #4483 This is a forward port of 24118459c6d497eedaee9ce4eb09f525034c89bd the check checks whether follow_symlinks=False is supported, which requires that the glibc is recent enough / python was compiled for a recent enough glibc. follow_symlinks=False is only used for borg create and extract, but not needed for borg serve. thus, this makes it possible to run "borg serve" even on a bit older servers. be careful, due to the presence of this check on the server side until now, older server systems are not really much tested. --- src/borg/archiver.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/borg/archiver.py b/src/borg/archiver.py index 5a72fcc10..7d92f05a2 100644 --- a/src/borg/archiver.py +++ b/src/borg/archiver.py @@ -4243,8 +4243,10 @@ class Archiver: parser.error('Need at least one PATH argument.') return args - def prerun_checks(self, logger): - check_python() + def prerun_checks(self, logger, is_serve): + if not is_serve: + # this is the borg *client*, we need to check the python: + check_python() check_extension_modules() selftest(logger) @@ -4286,7 +4288,7 @@ class Archiver: return self.exit_code if args.show_version: logging.getLogger('borg.output.show-version').info('borgbackup version %s' % __version__) - self.prerun_checks(logger) + self.prerun_checks(logger, is_serve) if not is_supported_msgpack(): logger.error("You do not have a supported version of the msgpack python package installed. Terminating.") logger.error("This should never happen as specific, supported versions are required by our setup.py.")