From dbcc870489a8fe3cc3517a438e21331feef63538 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Fri, 20 Oct 2017 16:47:32 +0200 Subject: [PATCH] fix server-side IndexError for 4-arg open() of old clients, fixes #3192 borg 1.1(.0) server didn't support the 4 argument open() calls made by < 1.0.7 clients. --- src/borg/remote.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/borg/remote.py b/src/borg/remote.py index 583ceafb0..d3c5e542d 100644 --- a/src/borg/remote.py +++ b/src/borg/remote.py @@ -179,7 +179,15 @@ class RepositoryServer: # pragma: no cover def positional_to_named(self, method, argv): """Translate from positional protocol to named protocol.""" - return {name: argv[pos] for pos, name in enumerate(compatMap[method])} + try: + return {name: argv[pos] for pos, name in enumerate(compatMap[method])} + except IndexError: + if method == 'open' and len(argv) == 4: + # borg clients < 1.0.7 use open() with 4 args + mapping = compatMap[method][:4] + else: + raise + return {name: argv[pos] for pos, name in enumerate(mapping)} def filter_args(self, f, kwargs): """Remove unknown named parameters from call, because client did (implicitly) say it's ok."""