mirror
/
borg
mirror of https://github.com/borgbackup/borg.git
1
0
Fork 0
Code Issues Releases Wiki Activity

"create" micro optimization: do not check for sockets early 

they are rare, so it's pointless to check for them first.

seen the stat..S_ISSOCK in profiling results with high call count.
was no big issue, that call is cheap, but also no big issue to just fix the order.
This commit is contained in:
Thomas Waldmann 2015-05-31 21:23:36 +02:00
parent 69371153d1
commit ed1e5e9c13
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
borg/archiver.py
View File

@ -168,9 +168,6 @@ Type "Yes I am sure" if you understand this and want to continue.\n""")
# Entering a new filesystem?
if restrict_dev and st.st_dev != restrict_dev:
return
# Ignore unix sockets
if stat.S_ISSOCK(st.st_mode):
return
status = None
if stat.S_ISREG(st.st_mode):
try:
@ -196,6 +193,9 @@ Type "Yes I am sure" if you understand this and want to continue.\n""")
status = archive.process_fifo(path, st)
elif stat.S_ISCHR(st.st_mode) or stat.S_ISBLK(st.st_mode):
status = archive.process_dev(path, st)
elif stat.S_ISSOCK(st.st_mode):
# Ignore unix sockets
return
else:
self.print_error('Unknown file type: %s', path)
return