mirror/borg
1
0
Fork 0
mirror of https://github.com/borgbackup/borg.git synced 2025-02-06 22:43:48 +00:00
Code Issues Releases Wiki Activity

Merge pull request #1136 from ThomasWaldmann/env-security-cleanup

Browse source 
remove passphrase from subprocess environment, fixes #1105
This commit is contained in:
TW 2016-06-05 13:29:52 +02:00
commit ee5e89b575
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
borg/remote.py
View file

@ -153,6 +153,7 @@ def __init__(self, location, create=False, lock_wait=None, lock=True, args=None)
# pyinstaller binary adds LD_LIBRARY_PATH=/tmp/_ME... but we do not want
# that the system's ssh binary picks up (non-matching) libraries from there
env.pop('LD_LIBRARY_PATH', None)
env.pop('BORG_PASSPHRASE', None) # security: do not give secrets to subprocess
self.p = Popen(borg_cmd, bufsize=0, stdin=PIPE, stdout=PIPE, stderr=PIPE, env=env)
self.stdin_fd = self.p.stdin.fileno()
self.stdout_fd = self.p.stdout.fileno()