Merge pull request #5669 from ThomasWaldmann/misc-fixes-master

misc. crash fixes (master)
This commit is contained in:
TW 2021-02-03 16:35:10 +01:00 committed by GitHub
commit f195a71e24
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 15 deletions

View File

@ -74,7 +74,7 @@ class Archives(abc.MutableMapping):
name = safe_encode(name) name = safe_encode(name)
del self._archives[name] del self._archives[name]
def list(self, *, glob=None, match_end=r'\Z', sort_by=(), consider_checkpoints=False, first=None, last=None, reverse=False): def list(self, *, glob=None, match_end=r'\Z', sort_by=(), consider_checkpoints=True, first=None, last=None, reverse=False):
""" """
Return list of ArchiveInfo instances according to the parameters. Return list of ArchiveInfo instances according to the parameters.
@ -82,6 +82,10 @@ class Archives(abc.MutableMapping):
Apply *first* and *last* filters, and then possibly *reverse* the list. Apply *first* and *last* filters, and then possibly *reverse* the list.
*sort_by* is a list of sort keys applied in reverse order. *sort_by* is a list of sort keys applied in reverse order.
Note: for better robustness, all filtering / limiting parameters must default to
"not limit / not filter", so a FULL archive list is produced by a simple .list().
some callers EXPECT to iterate over all archives in a repo for correct operation.
""" """
if isinstance(sort_by, (str, bytes)): if isinstance(sort_by, (str, bytes)):
raise TypeError('sort_by must be a sequence of str') raise TypeError('sort_by must be a sequence of str')