Antoine Beaupré
35b219597f
only write magic num if necessary
...
this could allow speeding up conversions resumed after interruption
2015-10-01 14:28:49 -04:00
Antoine Beaupré
180dfcb18f
remove needless indentation
2015-10-01 14:23:43 -04:00
Antoine Beaupré
6a72252b69
release lock properly if segment conversion crashes
2015-10-01 14:22:29 -04:00
Antoine Beaupré
1b540d91a0
convert more print() statements to logging
...
we use logging.warning in info and list, but print() more usage bits.
we also now support logging.debug() and by default are more silent
2015-10-01 14:20:29 -04:00
TW
d27da99208
Merge pull request #230 from anarcat/api
...
add automatically generated API
2015-10-01 19:52:15 +02:00
Antoine Beaupré
09ffbb1d9d
convert most print() calls to logging
...
the logging level varies: most is logging.info(), in some place
logging.warning() or logging.error() are used when the condition is
clearly an error or warning. in other cases, we keep using print, but
force writing to sys.stderr, unless we interact with the user.
there were 77 calls to print before this commit, now there are 7, most
of which in the archiver module, which interacts directly with the
user. in one case there, we still use print() only because logging is
not setup properly yet during argument parsing.
it could be argued that commands like info or list should use print
directly, but we have converted them anyways, without ill effects on
the unit tests
unit tests still use print() in some places
this switches all informational output to stderr, which should help
with, if not fix jborg/attic#312 directly
2015-10-01 13:41:45 -04:00
Antoine Beaupré
c996fd8366
just call print() once in the odd print_() function
...
this will help when we want to refactor output functions
this function should definitely be replaced by a __repr__() or
__str__() however
2015-10-01 12:39:13 -04:00
Antoine Beaupré
3bb3bd45fc
add percentage progress
2015-10-01 12:36:53 -04:00
Thomas Waldmann
5c649a0154
Merge branch 'master' of github.com:borgbackup/borg
2015-10-01 18:21:45 +02:00
Antoine Beaupré
0d457bc846
clarify what to do about the cache warning
2015-10-01 11:25:12 -04:00
Antoine Beaupré
946aca97a1
avoid flooding the console
...
instead we add progress information
2015-10-01 11:25:02 -04:00
Antoine Beaupré
6c318a0f27
re-pep8
2015-10-01 11:12:23 -04:00
Antoine Beaupré
7f6fd1f306
add docs for all converter test code
2015-10-01 11:11:30 -04:00
Antoine Beaupré
a08bcb21ae
refactor common code
...
we get rid of repo_open() which doesn't same much typing, and add a validator for keys
2015-10-01 11:10:56 -04:00
Antoine Beaupré
f5cb0f4e73
rewrite convert tests with pytest fixtures
2015-10-01 10:41:31 -04:00
Antoine Beaupré
98e4e6bc25
lock repository when converting segments
2015-10-01 09:35:17 -04:00
Antoine Beaupré
58815bc28a
fix commandline dispatch for converter
2015-10-01 09:23:17 -04:00
Antoine Beaupré
57801a288d
keep tests simple by always adding attic depends
...
note that we do not depend on attic to build borg, just to do those
tests. if attic goes away, we could eventually do this another way or
just stop testing this altogether.
2015-10-01 09:03:41 -04:00
Antoine Beaupré
79d9aebaf2
use permanently instead of irrevocably, which is less common
2015-10-01 09:00:49 -04:00
Antoine Beaupré
b9c474d187
pep8: put pytest skip marker after imports
2015-10-01 08:59:01 -04:00
Antoine Beaupré
4a85f2d0f5
fix most pep8 warnings
...
* limit all lines to 80 chars
* remove spaces around parameters
* missing blank lines
2015-10-01 08:58:01 -04:00
Antoine Beaupré
5f6eb87385
much nicer validation checking
2015-10-01 08:50:06 -04:00
Antoine Beaupré
d5198c551b
split out depends in imports
2015-10-01 08:47:23 -04:00
Antoine Beaupré
d66516351f
use builtin NotImplementedError instead of writing our own
...
NotImplemented didn't work with pytest.raise(), i didn't know about NotImplementedError, thanks tw
2015-10-01 08:46:30 -04:00
Antoine Beaupré
ef0ed409b6
fix typo
2015-10-01 08:44:17 -04:00
Antoine Beaupré
5b8cb63479
remove duplicate code with the unit test
2015-10-01 08:43:05 -04:00
Antoine Beaupré
dbd4ac7f8d
add missing colon
2015-10-01 08:41:44 -04:00
Antoine Beaupré
c2913f5f10
style: don't use continue for nothing
2015-10-01 08:40:56 -04:00
Antoine Beaupré
efbad396f4
help text review: magic s/number/string/, s/can/must/
2015-10-01 08:40:25 -04:00
Antoine Beaupré
a81755f1a9
use triple-double-quoted instead of single-double-quoted
...
at the request of TW, see #231
2015-10-01 08:34:18 -04:00
TW
50fe290770
Merge pull request #229 from anarcat/rmapi
...
remove api file introduced by mistake in #228
2015-10-01 10:52:09 +02:00
Antoine Beaupré
c990829225
add attic dependency for build as a separate factor
...
this way we don't depend on attic for regular build, but we can still see proper test coverage
2015-10-01 00:51:19 -04:00
Antoine Beaupré
bcd94b96e0
split up keyfile, segments and overall testing in converter
2015-10-01 00:32:34 -04:00
Antoine Beaupré
1ba856d2b3
refactor: group test repo subroutine
2015-10-01 00:15:25 -04:00
Antoine Beaupré
1b29699403
cosmetic: reorder
2015-10-01 00:15:12 -04:00
Antoine Beaupré
a5f32b0a27
add convert command
2015-09-30 23:50:46 -04:00
Antoine Beaupré
f35e8e17f2
add dry run support to converter
2015-09-30 23:50:35 -04:00
Antoine Beaupré
e554365765
remove unused import
2015-09-30 23:28:07 -04:00
Antoine Beaupré
77ed6dec2b
skip converter tests if attic isn't installed
2015-09-30 23:27:55 -04:00
Antoine Beaupré
c30df4e033
move converter code out of test suite
2015-09-30 23:18:03 -04:00
Antoine Beaupré
5a1680397c
remove needless use of self
2015-09-30 23:02:21 -04:00
Antoine Beaupré
aa25a217a4
move conversion code to a separate class for clarity
2015-09-30 23:01:03 -04:00
Antoine Beaupré
312c3cf738
rewrite converter to avoid using attic code
...
the unit tests themselves still use attic to generate an attic
repository for testing, but the converter code should now be
standalone
2015-09-30 22:54:00 -04:00
Antoine Beaupré
c7af4c7f1d
more debug
2015-09-30 22:43:08 -04:00
Antoine Beaupré
2d1988179e
some debugging code
2015-09-30 22:41:38 -04:00
Antoine Beaupré
e88a994c8a
reshuffle and document
2015-09-30 22:41:21 -04:00
Antoine Beaupré
9ab1e1961e
keyfile conversion code
2015-09-30 22:37:39 -04:00
Antoine Beaupré
de54228809
first stab at an attic-borg converter
...
for now, just in the test suite, but will be migrated to a separate command
2015-09-30 21:08:47 -04:00
Antoine Beaupré
a2cf0025c2
add automatically generated API
...
this is a crude hack for now, and could use a better table of contents
but at least we have some way of linking and showing the different
internal functions
the next phase here is obviously to document that API through the
addition of docstrings. a static api.rst could also be easier to read,
but maybe that could go through some docstrings as well, to be tested
2015-09-30 18:35:57 -04:00
Antoine Beaupré
b72d955c3e
remove api file introduced by mistake in #228
2015-09-30 18:33:45 -04:00
