Commit Graph

6447 Commits

Author SHA1 Message Date
TW fc4483a37c
Merge pull request #6079 from hexagonrecursion/patch-1
Remove --list-format from borg list
2021-12-07 20:15:35 +01:00
Andrey Bienkowski f2ea757fad
Remove --list-format from borg list
While reading the docs I noticed that in `borg list` the options --list-format and --format do the same thing. Using `git log -S` I have uncovered that --list-format used to be deprecated and was supposed to be removed in c87393cab7, but you overlooked it and undeprecated it instead. What should we do now? Just remove it or deprecate it again?
2021-12-07 12:45:42 +00:00
TW 54b5ae4865
Merge pull request #6076 from hexagonrecursion/fwdport-a-test
Forward port: Test that the archive name is not mentioned
2021-12-03 15:35:59 +01:00
Andrey Bienkowski 17d12b520c Forward port: Test that the archive name is not mentioned
This test was originally added in #6071
2021-12-02 17:27:13 +03:00
TW 13f2600fb2
Merge pull request #6072 from hexagonrecursion/fwdport-6064
Forward port #6064: avoid expanding path into LHS of formatting operation
2021-12-02 03:57:10 +01:00
Andrey Bienkowski d9e923e66f Forward port #6064: avoid expanding path into LHS of formatting operation 2021-11-30 20:51:47 +03:00
Andrey Bienkowski 3e3ed78b8c Test % in file name and xattr (see #6063) 2021-11-30 20:51:38 +03:00
TW e8ff51b0f9
Merge pull request #6067 from hexagonrecursion/fwd-port-6008
Remove BORG_LIBC completion
2021-11-29 11:08:58 +01:00
Andrey Bienkowski a605dff15e Remove BORG_LIBC completion
BORG_LIBC was added in a4f7e69 to allow borg to work on systems where 
ctypes.util,find_library() fails. Since 9914968 borg no longer uses 
find_library().
2021-11-28 17:32:34 +03:00
enkore 79cb4e43e5
docs/data-structures: tie CDC back into dedup rationale 2021-11-27 18:45:19 +00:00
enkore 5b297849d3
docs/data-structures: add content-defined chunking explainer 2021-11-27 14:41:24 +00:00
Thomas Waldmann 7f5cd2c4d4 fix cyclic import issues 2021-11-17 17:36:43 +01:00
TW 9dfdd9f06a
Merge pull request #6022 from pgerber/recover
Speed up search for next valid object in segment in --repair mode
2021-11-17 15:33:40 +01:00
Thomas Waldmann 9ef0413aeb atomically create the CACHE_TAG file, see #6028 2021-11-16 16:05:56 +01:00
TW ef6a65214e
Merge pull request #6055 from ThomasWaldmann/fix-hl-preload-master
fix hardlinkable file type check, fixes #6037
2021-11-16 15:25:59 +01:00
Thomas Waldmann 5064ec3c9a fix hardlinkable file type check, fixes #6037 2021-11-16 14:36:43 +01:00
sw9719 fec3568cba
do not show archive name in error msgs referring to repository (#6023)
do not show archive name in repo error msgs, fix #6014
2021-11-11 00:27:39 +01:00
TW 450ab38e42
Merge pull request #6025 from amikula/issue_6015
Handle case of calling prune_split when there are no archives, #6015
2021-10-28 17:43:35 +02:00
Peter Gerber 6c21404143
Validate tag ID when --repair[ing] an object
This too should make the scan faster as, assuming the data is
random, we can skip CRC checks for almost 94% of the incorrect
header location solely based on the tag.

As draw back, this will limit the number of tags that can be
added without breaking backwards compatibility to 16, with
13 currently unused.
2021-10-28 14:13:37 +00:00
Alf Mikula 663abc7c90 Handle case of calling prune_split when there are no archives 2021-10-28 05:36:43 -07:00
Peter Gerber 2bc91e5010
Speed up search for next valid object in segment in --repair mode
When an object is corrupted, the start position of the next object
will not be known as the size field belonging to the corrupted
object may be corrupted as well. In order to find the next object
within the segment, the remainder is scanned for the next valid
object, byte-by-byte. An object is considered valid if the CRC
checksum matches the content. However, doing so the scan accepted
any object size that fit within the remainder of the segment. As a
result, in particular when the corruption occurred near the start
of a segment, CRC checksums were calculated for large objects,
often hundreds of megabytes in size, despite the size being limited
to 20 MiB. This change makes it so that CRC calculation is skipped
when the object header indicates an impossible size, thereby,
greatly reducing the number of CPU cycles used for CRC calculations.
In my case, this brought down the time for repair from hours to mere
minutes.

This has also the additional benefit that there is some verification
in addition to the CRC checksum. The 4-bytes checksum is rather
short considering the amount of data that might be in an archive.

Likely fixes the hanging --repair in #5995 also.
2021-10-28 10:59:11 +00:00
Alf Mikula 5b050bd01c Add test for prune_split when no archives exist 2021-10-27 15:52:45 -07:00
TW 9b6adc1cd6
Merge pull request #6016 from strugee/patch-1
Fix manifest-timestamp path in docs
2021-10-18 17:10:20 +02:00
AJ Jordan 284b26f6cc
Fix manifest-timestamp path 2021-10-18 02:54:12 -04:00
TW bc700c008a
Merge pull request #6011 from jimparis/jim-fix-6009
create: fix passing device nodes and symlinks to --paths-from-stdin
2021-10-15 21:48:44 +02:00
Jim Paris 7a0ffed7f0 create: fix passing device nodes and symlinks to --paths-from-stdin
Paths that come from --paths-from-stdin or --paths-from-command don't
have a parent_fd or name, so we need to use the os_stat helper that
falls back on the full path if those are missing.

Fixes borgbackup/borg#6009
2021-10-14 11:46:10 -04:00
TW 93e0d0f614
Merge pull request #6004 from KN4CK3R/forwardport-5923
Forwardport Update shell completions to 1.1.17 (#5923)
2021-10-08 09:37:06 +02:00
TW 79eba96bba Update shell completions to 1.1.17 2021-10-08 08:59:38 +02:00
TW 3ad8dc8bd0
Merge pull request #5999 from ahtaarra/patch-1
docs: fix the broken link to .nix file
2021-10-06 18:35:53 +02:00
ahtaarra 09730833ec
Fix broken link to .nix file
Fix the link to .nix file which has been broken since this change: e570d93519
2021-10-05 06:53:11 +06:00
TW 4605078bca
Merge pull request #5987 from ThomasWaldmann/require-py38
require python 3.8+, fixes #5975
2021-10-02 21:22:04 +02:00
Marcin Zajączkowski 2b67c9f3ee Fix command completion in Fish 3.3.0+
Fish 3.3.0 enabled stderr-nocaret flag by default which breaks
stderr redirection with "^/dev/null". A posix-like "2>/dev/null"
has to be used instead.

https://github.com/fish-shell/fish-shell/pull/7907
https://github.com/fish-shell/fish-shell/issues/7105
2021-09-16 20:21:29 +02:00
Thomas Waldmann 59b6dc5442 require python 3.8+, fixes #5975
if you do not have py38+ yet, just use borg 1.1.x.
2021-09-16 02:21:29 +02:00
TW 4f82550773
Merge pull request #5985 from ThomasWaldmann/fix-5979-master
do not require BORG_CONFIG_DIR if BORG_{SECURITY,KEYS}_DIR are set
2021-09-15 23:16:33 +02:00
TW 64e694b652
Merge pull request #5986 from ThomasWaldmann/vagrant-py397
vagrant: use py 3.9.7 (incl. binary builds)
2021-09-12 15:50:59 +02:00
Thomas Waldmann 98230f721a fix: do not require BORG_CONFIG_DIR if BORG_{SECURITY,KEYS}_DIR are set, fixes #5979
but please note that this does not mean that "keys" and "security" are or will ever be the only subdirs below the borg config dir.
2021-09-12 15:36:07 +02:00
Thomas Waldmann 04d1dd8720 vagrant: use py 3.9.7 (incl. binary builds) 2021-09-02 15:00:10 +02:00
Jubjub 0393cfac6c
docs: document behavior for filesystems with inconsistent inodes, fixes borgbackup#5770 (#5965) 2021-08-25 21:43:47 +02:00
remyabel 795d9abad2
docs: clarify user_id vs uid for fuse (#5958)
docs: clarify user_id vs uid for fuse, fixes #5723
2021-08-25 21:42:07 +02:00
remyabel e25095364b
docs: clarify pattern usage with commands (#5959)
docs: clarify pattern usage with commands, fixes #5176
2021-08-21 16:02:11 +02:00
TW c6559f04f0
Merge pull request #5956 from Gu1nness/5734-stacktrace-patterns-from
Use an exception catching to avoid a stack trace
2021-08-13 19:09:51 +02:00
Guinness 82e93527b0
Use an exception catching to avoid a stack trace
When exclude files are used, this can trigger a stack trace if the file
does not exist. Instead exit nicely without the stacktrace.

Fix #5734
2021-08-13 16:55:21 +02:00
TW b65183fc48
Merge pull request #5951 from remyabel/docs-pf-pp
docs: clarify pp pattern type, fixes #5300
2021-08-07 14:29:28 +02:00
Tommy Nguyen 7639465ad4
docs: clarify pp pattern type
Fixes: #5300

This incorporates the comments from `patterns.py` into the documentation
to clarify the difference between `pp` and `pf`.
2021-08-07 07:38:04 -04:00
remyabel 79db0b0815
docs: update referenced freebsd version (#5945)
docs: update referenced freebsd/macOS versions used for binary build

Fixes #5942.
2021-08-05 22:56:02 +02:00
TW 96af6dd144
Merge pull request #5911 from KN4CK3R/forwardport-5902
Forwardport pull request #5902
2021-07-19 23:04:48 +02:00
TW 1e7c1414b0 Merge pull request #5902 from ThomasWaldmann/pull-chroot-problematic-1.1
docs: pull mode: add some warnings, fixes #5827
2021-07-11 18:07:14 +02:00
TW 99a791f9e2
Merge pull request #5908 from ThomasWaldmann/fix-pyinstaller-dir-mode-master
fix pyinstaller detection for dir-mode, fixes #5897
2021-07-11 13:48:28 +02:00
Thomas Waldmann 5a13416a80 fix pyinstaller detection for dir-mode, fixes #5897
"running under pyinstaller" detection is now as recommended by the pyinstaller docs.
2021-07-11 00:26:50 +02:00
TW 7f97b0db99
Merge pull request #5907 from ThomasWaldmann/docs-key-hint-master
docs: clarify "you will need key and passphrase" borg init warning, fixes #4622
2021-07-10 23:55:51 +02:00