From acbe0e6c59cfe19ef17604680379109cb7b59af2 Mon Sep 17 00:00:00 2001 From: Thomas Citharel Date: Fri, 10 Sep 2021 11:30:12 +0200 Subject: [PATCH] Fix rendering metadata from deleted (empty) comments Signed-off-by: Thomas Citharel --- lib/service/metadata/comment.ex | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/service/metadata/comment.ex b/lib/service/metadata/comment.ex index 99c893642..d36aebc07 100644 --- a/lib/service/metadata/comment.ex +++ b/lib/service/metadata/comment.ex @@ -2,7 +2,8 @@ defimpl Mobilizon.Service.Metadata, for: Mobilizon.Discussions.Comment do alias Phoenix.HTML.Tag alias Mobilizon.Discussions.Comment - def build_tags(%Comment{} = comment, _locale \\ "en") do + @spec build_tags(Comment.t(), String.t()) :: list(Phoenix.HTML.safe()) + def build_tags(%Comment{deleted_at: nil} = comment, _locale) do [ Tag.tag(:meta, property: "og:title", content: comment.actor.preferred_username), Tag.tag(:meta, property: "og:url", content: comment.url), @@ -11,4 +12,6 @@ defimpl Mobilizon.Service.Metadata, for: Mobilizon.Discussions.Comment do Tag.tag(:meta, property: "twitter:card", content: "summary") ] end + + def build_tags(%Comment{} = _comment, _locale), do: [] end