mirror of
https://framagit.org/framasoft/mobilizon.git
synced 2024-12-23 08:22:50 +00:00
1984f71cbf
And other fixes Signed-off-by: Thomas Citharel <tcit@tcit.fr>
365 lines
10 KiB
Elixir
365 lines
10 KiB
Elixir
defmodule Mobilizon.Web.Resolvers.GroupTest do
|
|
use Mobilizon.Web.ConnCase
|
|
use Oban.Testing, repo: Mobilizon.Storage.Repo
|
|
|
|
import Mobilizon.Factory
|
|
|
|
alias Mobilizon.GraphQL.AbsintheHelpers
|
|
|
|
@non_existent_username "nonexistent"
|
|
@new_group_params %{groupname: "new group"}
|
|
|
|
setup %{conn: conn} do
|
|
user = insert(:user)
|
|
actor = insert(:actor, user: user)
|
|
|
|
{:ok, conn: conn, actor: actor, user: user}
|
|
end
|
|
|
|
describe "create a group" do
|
|
test "create_group/3 should check the user owns the identity", %{conn: conn, user: user} do
|
|
another_actor = insert(:actor)
|
|
|
|
mutation = """
|
|
mutation {
|
|
createGroup(
|
|
preferred_username: "#{@new_group_params.groupname}",
|
|
creator_actor_id: #{another_actor.id}
|
|
) {
|
|
preferred_username,
|
|
type
|
|
}
|
|
}
|
|
"""
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> post("/api", AbsintheHelpers.mutation_skeleton(mutation))
|
|
|
|
assert hd(json_response(res, 200)["errors"])["message"] ==
|
|
"Creator actor id is not owned by the current user"
|
|
end
|
|
|
|
test "create_group/3 creates a group and check a group with this name does not already exist",
|
|
%{conn: conn, user: user, actor: actor} do
|
|
mutation = """
|
|
mutation {
|
|
createGroup(
|
|
preferred_username: "#{@new_group_params.groupname}",
|
|
creator_actor_id: #{actor.id}
|
|
) {
|
|
preferred_username,
|
|
type
|
|
}
|
|
}
|
|
"""
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> post("/api", AbsintheHelpers.mutation_skeleton(mutation))
|
|
|
|
assert json_response(res, 200)["data"]["createGroup"]["preferred_username"] ==
|
|
@new_group_params.groupname
|
|
|
|
assert json_response(res, 200)["data"]["createGroup"]["type"] == "GROUP"
|
|
|
|
mutation = """
|
|
mutation {
|
|
createGroup(
|
|
preferred_username: "#{@new_group_params.groupname}",
|
|
creator_actor_id: #{actor.id},
|
|
) {
|
|
preferred_username,
|
|
type
|
|
}
|
|
}
|
|
"""
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> post("/api", AbsintheHelpers.mutation_skeleton(mutation))
|
|
|
|
assert hd(json_response(res, 200)["errors"])["message"] ==
|
|
"A group with this name already exists"
|
|
end
|
|
end
|
|
|
|
describe "list groups" do
|
|
@list_groups_query """
|
|
{
|
|
groups {
|
|
elements {
|
|
preferredUsername,
|
|
},
|
|
total
|
|
}
|
|
}
|
|
"""
|
|
|
|
test "list_groups/3 doesn't returns all groups if not authenticated", %{conn: conn} do
|
|
insert(:group, visibility: :public)
|
|
insert(:group, visibility: :unlisted)
|
|
insert(:group, visibility: :private)
|
|
|
|
res = AbsintheHelpers.graphql_query(conn, query: @list_groups_query)
|
|
|
|
assert hd(res["errors"])["message"] == "You may not list groups unless moderator."
|
|
end
|
|
|
|
test "list_groups/3 doesn't return all groups if not a moderator", %{conn: conn} do
|
|
insert(:group, visibility: :public)
|
|
insert(:group, visibility: :unlisted)
|
|
insert(:group, visibility: :private)
|
|
user = insert(:user)
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> AbsintheHelpers.graphql_query(query: @list_groups_query)
|
|
|
|
assert hd(res["errors"])["message"] == "You may not list groups unless moderator."
|
|
end
|
|
|
|
test "list_groups/3 returns all groups if a moderator", %{conn: conn} do
|
|
group_1 = insert(:group, visibility: :public)
|
|
group_2 = insert(:group, visibility: :unlisted)
|
|
group_3 = insert(:group, visibility: :private)
|
|
user = insert(:user, role: :moderator)
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> AbsintheHelpers.graphql_query(query: @list_groups_query)
|
|
|
|
assert res["data"]["groups"]["total"] == 3
|
|
|
|
assert res["data"]["groups"]["elements"]
|
|
|> Enum.map(& &1["preferredUsername"])
|
|
|> MapSet.new() ==
|
|
[group_1, group_2, group_3] |> Enum.map(& &1.preferred_username) |> MapSet.new()
|
|
end
|
|
end
|
|
|
|
describe "find a group" do
|
|
@group_query """
|
|
query Group($preferredUsername: String!) {
|
|
group(preferredUsername: $preferredUsername) {
|
|
preferredUsername,
|
|
members {
|
|
total,
|
|
elements {
|
|
role,
|
|
actor {
|
|
preferredUsername
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
"""
|
|
|
|
test "find_group/3 returns a group by its username", %{conn: conn, actor: actor, user: user} do
|
|
group = insert(:group)
|
|
insert(:member, parent: group, actor: actor, role: :administrator)
|
|
insert(:member, parent: group, role: :member)
|
|
|
|
res =
|
|
conn
|
|
|> AbsintheHelpers.graphql_query(
|
|
query: @group_query,
|
|
variables: %{
|
|
preferredUsername: group.preferred_username
|
|
}
|
|
)
|
|
|
|
assert res["errors"] == nil
|
|
|
|
assert res["data"]["group"]["preferredUsername"] ==
|
|
group.preferred_username
|
|
|
|
assert res["data"]["group"]["members"]["total"] == 2
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> AbsintheHelpers.graphql_query(
|
|
query: @group_query,
|
|
variables: %{
|
|
preferredUsername: group.preferred_username,
|
|
actorId: actor.id
|
|
}
|
|
)
|
|
|
|
assert res["errors"] == nil
|
|
|
|
assert res["data"]["group"]["members"]["total"] == 2
|
|
assert hd(res["data"]["group"]["members"]["elements"])["role"] == "ADMINISTRATOR"
|
|
|
|
assert hd(res["data"]["group"]["members"]["elements"])["actor"]["preferredUsername"] ==
|
|
actor.preferred_username
|
|
|
|
res =
|
|
conn
|
|
|> AbsintheHelpers.graphql_query(
|
|
query: @group_query,
|
|
variables: %{preferredUsername: @non_existent_username}
|
|
)
|
|
|
|
assert res["data"]["group"] == nil
|
|
|
|
assert hd(res["errors"])["message"] ==
|
|
"Group with name #{@non_existent_username} not found"
|
|
end
|
|
|
|
test "find_group doesn't list group members access if group is private", %{
|
|
conn: conn,
|
|
actor: actor
|
|
} do
|
|
group = insert(:group, visibility: :private)
|
|
insert(:member, parent: group, actor: actor, role: :administrator)
|
|
|
|
res =
|
|
conn
|
|
|> AbsintheHelpers.graphql_query(
|
|
query: @group_query,
|
|
variables: %{
|
|
preferredUsername: group.preferred_username
|
|
}
|
|
)
|
|
|
|
assert res["errors"] == nil
|
|
|
|
assert res["data"]["group"]["preferredUsername"] ==
|
|
group.preferred_username
|
|
|
|
assert res["data"]["group"]["members"] == %{"elements" => [], "total" => 1}
|
|
end
|
|
end
|
|
|
|
describe "delete a group" do
|
|
@delete_group_mutation """
|
|
mutation DeleteGroup($groupId: ID!) {
|
|
deleteGroup(
|
|
groupId: $groupId
|
|
) {
|
|
id
|
|
}
|
|
}
|
|
"""
|
|
|
|
test "delete_group/3 deletes a group", %{conn: conn, user: user, actor: actor} do
|
|
group = insert(:group)
|
|
insert(:member, parent: group, actor: actor, role: :administrator)
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> AbsintheHelpers.graphql_query(
|
|
query: @delete_group_mutation,
|
|
variables: %{groupId: group.id}
|
|
)
|
|
|
|
assert res["errors"] == nil
|
|
assert res["data"]["deleteGroup"]["id"] == to_string(group.id)
|
|
|
|
assert_enqueued(
|
|
worker: Mobilizon.Service.Workers.Background,
|
|
args: %{
|
|
"actor_id" => group.id,
|
|
"author_id" => actor.id,
|
|
"op" => "delete_actor",
|
|
"reserve_username" => true,
|
|
"suspension" => false
|
|
}
|
|
)
|
|
|
|
# Can't be used right now, probably because we try to run a transaction in a Oban Job while using Ecto Sandbox
|
|
|
|
# assert %{success: 1, failure: 0} == Oban.drain_queue(queue: :background)
|
|
|
|
# res =
|
|
# conn
|
|
# |> auth_conn(user)
|
|
# |> AbsintheHelpers.graphql_query(
|
|
# query: @delete_group_mutation,
|
|
# variables: %{groupId: group.id}
|
|
# )
|
|
|
|
# assert res["data"] == "tt"
|
|
# assert hd(json_response(res, 200)["errors"])["message"] =~ "not found"
|
|
end
|
|
|
|
test "delete_group/3 should check user authentication", %{conn: conn, actor: actor} do
|
|
group = insert(:group)
|
|
insert(:member, parent: group, actor: actor, role: :member)
|
|
|
|
res =
|
|
conn
|
|
|> AbsintheHelpers.graphql_query(
|
|
query: @delete_group_mutation,
|
|
variables: %{groupId: group.id}
|
|
)
|
|
|
|
assert hd(res["errors"])["message"] =~ "logged-in"
|
|
end
|
|
|
|
test "delete_group/3 should check the actor is owned by the user", %{
|
|
conn: conn,
|
|
user: user,
|
|
actor: actor
|
|
} do
|
|
group = insert(:group)
|
|
insert(:member, parent: group, actor: actor, role: :member)
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> AbsintheHelpers.graphql_query(
|
|
query: @delete_group_mutation,
|
|
variables: %{groupId: group.id}
|
|
)
|
|
|
|
assert hd(res["errors"])["message"] ==
|
|
"Actor id is not an administrator of the selected group"
|
|
end
|
|
|
|
test "delete_group/3 should check the actor is a member of this group", %{
|
|
conn: conn,
|
|
user: user
|
|
} do
|
|
group = insert(:group)
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> AbsintheHelpers.graphql_query(
|
|
query: @delete_group_mutation,
|
|
variables: %{groupId: group.id}
|
|
)
|
|
|
|
assert hd(res["errors"])["message"] =~ "not a member"
|
|
end
|
|
|
|
test "delete_group/3 should check the actor is an administrator of this group", %{
|
|
conn: conn,
|
|
user: user,
|
|
actor: actor
|
|
} do
|
|
group = insert(:group)
|
|
insert(:member, parent: group, actor: actor, role: :member)
|
|
|
|
res =
|
|
conn
|
|
|> auth_conn(user)
|
|
|> AbsintheHelpers.graphql_query(
|
|
query: @delete_group_mutation,
|
|
variables: %{groupId: group.id}
|
|
)
|
|
|
|
assert hd(res["errors"])["message"] =~ "not an administrator"
|
|
end
|
|
end
|
|
end
|