From a0157fce0c1ab287373924558f95962ae0df540f Mon Sep 17 00:00:00 2001
From: Daniel Supernault <danielsupernault@gmail.com>
Date: Fri, 8 Dec 2023 01:13:04 -0700
Subject: [PATCH] Update Inbox handler, fix missing object_url and uri fields
 for direct statuses

---
 app/Util/ActivityPub/Inbox.php                | 15 ++++++---
 ...d_direct_object_urls_to_statuses_table.php | 33 +++++++++++++++++++
 2 files changed, 44 insertions(+), 4 deletions(-)
 create mode 100644 database/migrations/2023_12_08_074345_add_direct_object_urls_to_statuses_table.php

diff --git a/app/Util/ActivityPub/Inbox.php b/app/Util/ActivityPub/Inbox.php
index e97eda34d..7cb25af82 100644
--- a/app/Util/ActivityPub/Inbox.php
+++ b/app/Util/ActivityPub/Inbox.php
@@ -282,8 +282,8 @@ class Inbox
 		}
 
 		if($actor->followers_count == 0) {
-            if(config('federation.activitypub.ingest.store_notes_without_followers')) {
-            } else if(FollowerService::followerCount($actor->id, true) == 0) {
+			if(config('federation.activitypub.ingest.store_notes_without_followers')) {
+			} else if(FollowerService::followerCount($actor->id, true) == 0) {
 				return;
 			}
 		}
@@ -401,6 +401,8 @@ class Inbox
 		$status->visibility = 'direct';
 		$status->scope = 'direct';
 		$status->url = $activity['id'];
+		$status->uri = $activity['id'];
+		$status->object_url = $activity['id'];
 		$status->in_reply_to_profile_id = $profile->id;
 		$status->save();
 
@@ -703,12 +705,17 @@ class Inbox
 							return;
 						}
 						$status = Status::whereProfileId($profile->id)
-							->whereObjectUrl($id)
+							->where(function($q) use($id) {
+								return $q->where('object_url', $id)
+									->orWhere('url', $id);
+							})
 							->first();
 						if(!$status) {
 							return;
 						}
-						FeedRemoveRemotePipeline::dispatch($status->id, $status->profile_id)->onQueue('feed');
+						if($status->scope && $status->scope != 'direct') {
+							FeedRemoveRemotePipeline::dispatch($status->id, $status->profile_id)->onQueue('feed');
+						}
 						RemoteStatusDelete::dispatch($status)->onQueue('high');
 						return;
 					break;
diff --git a/database/migrations/2023_12_08_074345_add_direct_object_urls_to_statuses_table.php b/database/migrations/2023_12_08_074345_add_direct_object_urls_to_statuses_table.php
new file mode 100644
index 000000000..5211c658f
--- /dev/null
+++ b/database/migrations/2023_12_08_074345_add_direct_object_urls_to_statuses_table.php
@@ -0,0 +1,33 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+use App\Status;
+use Illuminate\Database\UniqueConstraintViolationException;
+
+return new class extends Migration
+{
+    /**
+     * Run the migrations.
+     */
+    public function up(): void
+    {
+        foreach(Status::whereScope('direct')->whereNotNull('url')->whereNull('object_url')->lazyById(50, 'id') as $status) {
+            try {
+                $status->object_url = $status->url;
+                $status->uri = $status->url;
+                $status->save();
+            } catch (Exception | UniqueConstraintViolationException $e) {
+                continue;
+            }
+        }
+    }
+
+    /**
+     * Reverse the migrations.
+     */
+    public function down(): void
+    {
+    }
+};