restic/internal/backend/rest/rest.go

500 lines
12 KiB
Go
Raw Normal View History

package rest
import (
2017-06-03 15:39:57 +00:00
"context"
"encoding/json"
"fmt"
"io"
Fix REST backend HTTP keepalive This is subtle. A combination od fast client disk (read: SSD) with lots of files and fast network connection to restic-server would suddenly start getting lots of "dial tcp: connect: cannot assign requested address" errors during backup stage. Further inspection revealed that client machine was plagued with TCP sockets in TIME_WAIT state. When ephemeral port range was finally exhausted, no more sockets could be opened, so restic would freak out. To understand the magnitude of this problem, with ~18k ports and default timeout of 60 seconds, it means more than 300 HTTP connections per seconds were created and teared down. Yeah, restic-server is that fast. :) As it turns out, this behavior was product of 2 subtle issues: 1) The body of HTTP response wasn't read completely with io.ReadFull() at the end of the Load() function. This deactivated HTTP keepalive, so already open connections were not reused, but closed instead, and new ones opened for every new request. io.Copy(ioutil.Discard, resp.Body) before resp.Body.Close() remedies this. 2) Even with the above fix, somehow having MaxIdleConnsPerHost at its default value of 2 wasn't enough to stop reconnecting. It is hard to understand why this would be so detrimental, it could even be some subtle Go runtime bug. Anyhow, setting this value to match the connection limit, as set by connLimit global variable, finally nails this ugly bug. I fixed several other places where the response body wasn't read in full (or at all). For example, json.NewDecoder() is also known not to read the whole body of response. Unfortunately, this is not over yet. :( The check command is firing up to 40 simultaneous connections to the restic-server. Then, once again, MaxIdleConnsPerHost is too low to support keepalive, and sockets in the TIME_WAIT state pile up. But, as this kind of concurrency absolutely kill the poor disk on the server side, this is a completely different bug then.
2016-11-09 21:37:20 +00:00
"io/ioutil"
"net/http"
"net/url"
"path"
"strconv"
2016-02-21 15:35:25 +00:00
"strings"
2017-06-03 15:39:57 +00:00
"golang.org/x/net/context/ctxhttp"
2020-12-17 11:47:53 +00:00
"github.com/restic/restic/internal/backend"
2017-07-23 12:21:03 +00:00
"github.com/restic/restic/internal/debug"
"github.com/restic/restic/internal/errors"
2017-07-24 15:42:25 +00:00
"github.com/restic/restic/internal/restic"
2020-12-17 11:47:53 +00:00
"github.com/cenkalti/backoff/v4"
)
// make sure the rest backend implements restic.Backend
2018-03-13 21:30:41 +00:00
var _ restic.Backend = &Backend{}
2018-03-13 21:30:41 +00:00
// Backend uses the REST protocol to access data stored on a server.
type Backend struct {
2017-06-05 22:25:22 +00:00
url *url.URL
sem *backend.Semaphore
client *http.Client
2017-04-11 19:47:57 +00:00
backend.Layout
}
2018-03-13 21:22:35 +00:00
// the REST API protocol version is decided by HTTP request headers, these are the constants.
2018-01-23 22:12:52 +00:00
const (
2018-03-13 21:22:35 +00:00
ContentTypeV1 = "application/vnd.x.restic.rest.v1"
ContentTypeV2 = "application/vnd.x.restic.rest.v2"
2018-01-23 22:12:52 +00:00
)
// Open opens the REST backend with the given config.
2018-03-13 21:30:41 +00:00
func Open(cfg Config, rt http.RoundTripper) (*Backend, error) {
client := &http.Client{Transport: rt}
2017-06-05 22:25:22 +00:00
sem, err := backend.NewSemaphore(cfg.Connections)
if err != nil {
return nil, err
}
2017-04-11 19:47:57 +00:00
// use url without trailing slash for layout
url := cfg.URL.String()
if url[len(url)-1] == '/' {
url = url[:len(url)-1]
}
2018-03-13 21:30:41 +00:00
be := &Backend{
2017-06-05 22:25:22 +00:00
url: cfg.URL,
client: client,
Layout: &backend.RESTLayout{URL: url, Join: path.Join},
sem: sem,
2017-04-11 19:47:57 +00:00
}
return be, nil
}
// Create creates a new REST on server configured in config.
func Create(ctx context.Context, cfg Config, rt http.RoundTripper) (*Backend, error) {
be, err := Open(cfg, rt)
if err != nil {
return nil, err
}
_, err = be.Stat(ctx, restic.Handle{Type: restic.ConfigFile})
if err == nil {
return nil, errors.Fatal("config file already exists")
}
url := *cfg.URL
values := url.Query()
values.Set("create", "true")
url.RawQuery = values.Encode()
resp, err := be.client.Post(url.String(), "binary/octet-stream", strings.NewReader(""))
if err != nil {
return nil, err
}
if resp.StatusCode != http.StatusOK {
return nil, errors.Fatalf("server response unexpected: %v (%v)", resp.Status, resp.StatusCode)
}
_, err = io.Copy(ioutil.Discard, resp.Body)
if err != nil {
return nil, err
}
err = resp.Body.Close()
if err != nil {
return nil, err
}
return be, nil
}
// Location returns this backend's location (the server's URL).
2018-03-13 21:30:41 +00:00
func (b *Backend) Location() string {
return b.url.String()
}
// Save stores data in the backend at the handle.
2018-03-13 21:30:41 +00:00
func (b *Backend) Save(ctx context.Context, h restic.Handle, rd restic.RewindReader) error {
if err := h.Valid(); err != nil {
2020-12-17 11:47:53 +00:00
return backoff.Permanent(err)
}
2017-06-03 15:39:57 +00:00
ctx, cancel := context.WithCancel(ctx)
defer cancel()
// make sure that client.Post() cannot close the reader by wrapping it
req, err := http.NewRequest(http.MethodPost, b.Filename(h), ioutil.NopCloser(rd))
2018-01-23 22:12:52 +00:00
if err != nil {
return errors.Wrap(err, "NewRequest")
}
req.Header.Set("Content-Type", "application/octet-stream")
2018-03-13 21:22:35 +00:00
req.Header.Set("Accept", ContentTypeV2)
2018-01-23 22:12:52 +00:00
// explicitly set the content length, this prevents chunked encoding and
// let's the server know what's coming.
req.ContentLength = rd.Length()
2017-06-05 22:25:22 +00:00
b.sem.GetToken()
2018-01-23 22:12:52 +00:00
resp, err := ctxhttp.Do(ctx, b.client, req)
2017-06-05 22:25:22 +00:00
b.sem.ReleaseToken()
var cerr error
if resp != nil {
_, _ = io.Copy(ioutil.Discard, resp.Body)
cerr = resp.Body.Close()
}
if err != nil {
2016-08-29 19:54:50 +00:00
return errors.Wrap(err, "client.Post")
}
if resp.StatusCode != 200 {
2017-05-28 10:31:19 +00:00
return errors.Errorf("server response unexpected: %v (%v)", resp.Status, resp.StatusCode)
}
return errors.Wrap(cerr, "Close")
}
2017-06-15 11:40:27 +00:00
// ErrIsNotExist is returned whenever the requested file does not exist on the
// server.
type ErrIsNotExist struct {
restic.Handle
}
func (e ErrIsNotExist) Error() string {
return fmt.Sprintf("%v does not exist", e.Handle)
}
// IsNotExist returns true if the error was caused by a non-existing file.
2018-03-13 21:30:41 +00:00
func (b *Backend) IsNotExist(err error) bool {
2017-06-15 11:40:27 +00:00
err = errors.Cause(err)
_, ok := err.(ErrIsNotExist)
return ok
}
// Load runs fn with a reader that yields the contents of the file at h at the
// given offset.
2018-03-13 21:30:41 +00:00
func (b *Backend) Load(ctx context.Context, h restic.Handle, length int, offset int64, fn func(rd io.Reader) error) error {
r, err := b.openReader(ctx, h, length, offset)
if err != nil {
return err
}
err = fn(r)
if err != nil {
_ = r.Close() // ignore error here
return err
}
// Note: readerat.ReadAt() (the fn) uses io.ReadFull() that doesn't
// wait for EOF after reading body. Due to HTTP/2 stream multiplexing
// and goroutine timings the EOF frame arrives from server (eg. rclone)
// with a delay after reading body. Immediate close might trigger
// HTTP/2 stream reset resulting in the *stream closed* error on server,
// so we wait for EOF before closing body.
var buf [1]byte
_, err = r.Read(buf[:])
if err == io.EOF {
err = nil
}
if e := r.Close(); err == nil {
err = e
}
return err
}
2018-03-13 21:30:41 +00:00
func (b *Backend) openReader(ctx context.Context, h restic.Handle, length int, offset int64) (io.ReadCloser, error) {
2017-01-23 17:11:10 +00:00
debug.Log("Load %v, length %v, offset %v", h, length, offset)
2017-01-22 21:01:12 +00:00
if err := h.Valid(); err != nil {
2020-12-17 11:47:53 +00:00
return nil, backoff.Permanent(err)
2017-01-22 21:01:12 +00:00
}
if offset < 0 {
return nil, errors.New("offset is negative")
}
if length < 0 {
return nil, errors.Errorf("invalid length %d", length)
}
2017-04-11 19:47:57 +00:00
req, err := http.NewRequest("GET", b.Filename(h), nil)
2017-01-22 21:01:12 +00:00
if err != nil {
return nil, errors.Wrap(err, "http.NewRequest")
}
byteRange := fmt.Sprintf("bytes=%d-", offset)
if length > 0 {
byteRange = fmt.Sprintf("bytes=%d-%d", offset, offset+int64(length)-1)
}
2018-01-23 22:12:52 +00:00
req.Header.Set("Range", byteRange)
2018-03-13 21:22:35 +00:00
req.Header.Set("Accept", ContentTypeV2)
2017-01-23 17:11:10 +00:00
debug.Log("Load(%v) send range %v", h, byteRange)
2017-01-22 21:01:12 +00:00
2017-06-05 22:25:22 +00:00
b.sem.GetToken()
2017-06-03 15:39:57 +00:00
resp, err := ctxhttp.Do(ctx, b.client, req)
2017-06-05 22:25:22 +00:00
b.sem.ReleaseToken()
2017-01-22 21:01:12 +00:00
if err != nil {
if resp != nil {
2017-06-03 15:39:57 +00:00
_, _ = io.Copy(ioutil.Discard, resp.Body)
_ = resp.Body.Close()
2017-01-22 21:01:12 +00:00
}
return nil, errors.Wrap(err, "client.Do")
}
2017-06-15 11:40:27 +00:00
if resp.StatusCode == http.StatusNotFound {
_ = resp.Body.Close()
return nil, ErrIsNotExist{h}
}
2017-01-22 21:01:12 +00:00
if resp.StatusCode != 200 && resp.StatusCode != 206 {
2017-06-03 15:39:57 +00:00
_ = resp.Body.Close()
2017-05-28 10:31:19 +00:00
return nil, errors.Errorf("unexpected HTTP response (%v): %v", resp.StatusCode, resp.Status)
2017-01-22 21:01:12 +00:00
}
// workaround https://github.com/golang/go/issues/46071
// see also https://forum.restic.net/t/http2-stream-closed-connection-reset-context-canceled/3743/10
if resp.ContentLength == 0 && resp.ProtoMajor == 2 && resp.ProtoMinor == 0 {
if clens := resp.Header["Content-Length"]; len(clens) == 1 {
if cl, err := strconv.ParseUint(clens[0], 10, 63); err == nil {
resp.ContentLength = int64(cl)
}
if resp.ContentLength != 0 {
_ = resp.Body.Close()
return nil, errors.Errorf("unexpected EOF got 0 instead of %v bytes", resp.ContentLength)
}
}
}
2017-01-22 21:01:12 +00:00
return resp.Body, nil
}
// Stat returns information about a blob.
2018-03-13 21:30:41 +00:00
func (b *Backend) Stat(ctx context.Context, h restic.Handle) (restic.FileInfo, error) {
if err := h.Valid(); err != nil {
2020-12-17 11:47:53 +00:00
return restic.FileInfo{}, backoff.Permanent(err)
}
2018-01-23 22:12:52 +00:00
req, err := http.NewRequest(http.MethodHead, b.Filename(h), nil)
if err != nil {
return restic.FileInfo{}, errors.Wrap(err, "NewRequest")
}
2018-03-13 21:22:35 +00:00
req.Header.Set("Accept", ContentTypeV2)
2018-01-23 22:12:52 +00:00
2017-06-05 22:25:22 +00:00
b.sem.GetToken()
2018-01-23 22:12:52 +00:00
resp, err := ctxhttp.Do(ctx, b.client, req)
2017-06-05 22:25:22 +00:00
b.sem.ReleaseToken()
if err != nil {
2016-08-31 20:51:35 +00:00
return restic.FileInfo{}, errors.Wrap(err, "client.Head")
}
2017-06-03 15:39:57 +00:00
_, _ = io.Copy(ioutil.Discard, resp.Body)
if err = resp.Body.Close(); err != nil {
2016-08-31 20:51:35 +00:00
return restic.FileInfo{}, errors.Wrap(err, "Close")
}
2017-06-15 11:40:27 +00:00
if resp.StatusCode == http.StatusNotFound {
_ = resp.Body.Close()
return restic.FileInfo{}, ErrIsNotExist{h}
}
if resp.StatusCode != 200 {
2017-05-28 10:31:19 +00:00
return restic.FileInfo{}, errors.Errorf("unexpected HTTP response (%v): %v", resp.StatusCode, resp.Status)
}
if resp.ContentLength < 0 {
2016-08-31 20:51:35 +00:00
return restic.FileInfo{}, errors.New("negative content length")
}
2016-08-31 20:51:35 +00:00
bi := restic.FileInfo{
Size: resp.ContentLength,
Name: h.Name,
}
return bi, nil
}
// Test returns true if a blob of the given type and name exists in the backend.
2018-03-13 21:30:41 +00:00
func (b *Backend) Test(ctx context.Context, h restic.Handle) (bool, error) {
2017-06-03 15:39:57 +00:00
_, err := b.Stat(ctx, h)
if err != nil {
return false, nil
}
return true, nil
}
// Remove removes the blob with the given name and type.
2018-03-13 21:30:41 +00:00
func (b *Backend) Remove(ctx context.Context, h restic.Handle) error {
if err := h.Valid(); err != nil {
2020-12-17 11:47:53 +00:00
return backoff.Permanent(err)
}
2017-04-11 19:47:57 +00:00
req, err := http.NewRequest("DELETE", b.Filename(h), nil)
if err != nil {
2016-08-29 19:54:50 +00:00
return errors.Wrap(err, "http.NewRequest")
}
2018-03-13 21:22:35 +00:00
req.Header.Set("Accept", ContentTypeV2)
2018-01-23 22:12:52 +00:00
2017-06-05 22:25:22 +00:00
b.sem.GetToken()
2017-06-03 15:39:57 +00:00
resp, err := ctxhttp.Do(ctx, b.client, req)
2017-06-05 22:25:22 +00:00
b.sem.ReleaseToken()
if err != nil {
2016-08-29 19:54:50 +00:00
return errors.Wrap(err, "client.Do")
}
2017-06-15 11:40:27 +00:00
if resp.StatusCode == http.StatusNotFound {
_ = resp.Body.Close()
return ErrIsNotExist{h}
}
if resp.StatusCode != 200 {
return errors.Errorf("blob not removed, server response: %v (%v)", resp.Status, resp.StatusCode)
}
2017-06-03 15:39:57 +00:00
_, err = io.Copy(ioutil.Discard, resp.Body)
if err != nil {
return errors.Wrap(err, "Copy")
}
return errors.Wrap(resp.Body.Close(), "Close")
}
// List runs fn for each file in the backend which has the type t. When an
// error occurs (or fn returns an error), List stops and returns it.
2018-03-13 21:30:41 +00:00
func (b *Backend) List(ctx context.Context, t restic.FileType, fn func(restic.FileInfo) error) error {
2017-04-11 19:47:57 +00:00
url := b.Dirname(restic.Handle{Type: t})
2016-02-21 15:35:25 +00:00
if !strings.HasSuffix(url, "/") {
url += "/"
}
2018-01-23 22:12:52 +00:00
req, err := http.NewRequest(http.MethodGet, url, nil)
if err != nil {
return errors.Wrap(err, "NewRequest")
}
2018-03-13 21:22:35 +00:00
req.Header.Set("Accept", ContentTypeV2)
2018-01-23 22:12:52 +00:00
2017-06-05 22:25:22 +00:00
b.sem.GetToken()
2018-01-23 22:12:52 +00:00
resp, err := ctxhttp.Do(ctx, b.client, req)
2017-06-05 22:25:22 +00:00
b.sem.ReleaseToken()
if err != nil {
return errors.Wrap(err, "List")
}
if resp.StatusCode != 200 {
return errors.Errorf("List failed, server response: %v (%v)", resp.Status, resp.StatusCode)
}
2018-03-13 21:22:35 +00:00
if resp.Header.Get("Content-Type") == ContentTypeV2 {
2018-01-23 22:12:52 +00:00
return b.listv2(ctx, t, resp, fn)
}
return b.listv1(ctx, t, resp, fn)
}
// listv1 uses the REST protocol v1, where a list HTTP request (e.g. `GET
// /data/`) only returns the names of the files, so we need to issue an HTTP
// HEAD request for each file.
2018-03-13 21:30:41 +00:00
func (b *Backend) listv1(ctx context.Context, t restic.FileType, resp *http.Response, fn func(restic.FileInfo) error) error {
2018-01-23 22:12:52 +00:00
debug.Log("parsing API v1 response")
dec := json.NewDecoder(resp.Body)
var list []string
2018-01-23 22:12:52 +00:00
if err := dec.Decode(&list); err != nil {
return errors.Wrap(err, "Decode")
}
for _, m := range list {
fi, err := b.Stat(ctx, restic.Handle{Name: m, Type: t})
if err != nil {
return err
}
if ctx.Err() != nil {
return ctx.Err()
}
fi.Name = m
err = fn(fi)
if err != nil {
return err
}
if ctx.Err() != nil {
return ctx.Err()
}
}
return ctx.Err()
}
2018-01-23 22:12:52 +00:00
// listv2 uses the REST protocol v2, where a list HTTP request (e.g. `GET
// /data/`) returns the names and sizes of all files.
2018-03-13 21:30:41 +00:00
func (b *Backend) listv2(ctx context.Context, t restic.FileType, resp *http.Response, fn func(restic.FileInfo) error) error {
2018-01-23 22:12:52 +00:00
debug.Log("parsing API v2 response")
dec := json.NewDecoder(resp.Body)
var list []struct {
Name string `json:"name"`
Size int64 `json:"size"`
}
if err := dec.Decode(&list); err != nil {
return errors.Wrap(err, "Decode")
}
for _, item := range list {
if ctx.Err() != nil {
return ctx.Err()
}
fi := restic.FileInfo{
Name: item.Name,
Size: item.Size,
}
err := fn(fi)
if err != nil {
return err
}
if ctx.Err() != nil {
return ctx.Err()
}
}
return ctx.Err()
}
// Close closes all open files.
2018-03-13 21:30:41 +00:00
func (b *Backend) Close() error {
// this does not need to do anything, all open files are closed within the
// same function.
return nil
}
// Remove keys for a specified backend type.
2018-03-13 21:30:41 +00:00
func (b *Backend) removeKeys(ctx context.Context, t restic.FileType) error {
return b.List(ctx, t, func(fi restic.FileInfo) error {
return b.Remove(ctx, restic.Handle{Type: t, Name: fi.Name})
})
}
// Delete removes all data in the backend.
2018-03-13 21:30:41 +00:00
func (b *Backend) Delete(ctx context.Context) error {
alltypes := []restic.FileType{
restic.PackFile,
restic.KeyFile,
restic.LockFile,
restic.SnapshotFile,
restic.IndexFile}
for _, t := range alltypes {
err := b.removeKeys(ctx, t)
if err != nil {
return nil
}
}
2017-10-14 13:56:38 +00:00
err := b.Remove(ctx, restic.Handle{Type: restic.ConfigFile})
if err != nil && b.IsNotExist(err) {
return nil
}
return err
}