From 07f4e7d10b1562a84beec3180babd43916654770 Mon Sep 17 00:00:00 2001 From: Michael Eischer Date: Thu, 17 Sep 2020 21:40:17 +0200 Subject: [PATCH] Only log HTTP requests when a debug log is configured The logged HTTP requests are only visible when a debug log is configured. --- internal/debug/round_tripper_debug.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/internal/debug/round_tripper_debug.go b/internal/debug/round_tripper_debug.go index 7b29267c9..5dfbb64c6 100644 --- a/internal/debug/round_tripper_debug.go +++ b/internal/debug/round_tripper_debug.go @@ -66,7 +66,12 @@ type loggingRoundTripper struct { // RoundTripper returns a new http.RoundTripper which logs all requests (if // debug is enabled). When debug is not enabled, upstream is returned. func RoundTripper(upstream http.RoundTripper) http.RoundTripper { - return loggingRoundTripper{eofDetectRoundTripper{upstream}} + eofRoundTripper := eofDetectRoundTripper{upstream} + if opts.isEnabled { + // only use loggingRoundTripper if the debug log is configured + return loggingRoundTripper{eofRoundTripper} + } + return eofRoundTripper } func (tr loggingRoundTripper) RoundTrip(req *http.Request) (res *http.Response, err error) {