From 0b56214473759b8f820b7d7ff7ab0e1ac64dd80f Mon Sep 17 00:00:00 2001
From: greatroar <61184462+greatroar@users.noreply.github.com>
Date: Tue, 21 May 2024 10:19:14 +0200
Subject: [PATCH] ui: Simplify stdio wrapper

The StdioWrapper type is really just a pair of io.WriteClosers, so
remove it in favor of a function that returns two of those. Test
coverage increases because the removed code was not tested.
---
 cmd/restic/termstatus.go     |  3 +--
 internal/ui/stdio_wrapper.go | 31 ++++---------------------------
 2 files changed, 5 insertions(+), 29 deletions(-)

diff --git a/cmd/restic/termstatus.go b/cmd/restic/termstatus.go
index cf3cd82ee..633e4521c 100644
--- a/cmd/restic/termstatus.go
+++ b/cmd/restic/termstatus.go
@@ -31,8 +31,7 @@ func setupTermstatus() (*termstatus.Terminal, func()) {
 
 	// use the termstatus for stdout/stderr
 	prevStdout, prevStderr := globalOptions.stdout, globalOptions.stderr
-	stdioWrapper := ui.NewStdioWrapper(term)
-	globalOptions.stdout, globalOptions.stderr = stdioWrapper.Stdout(), stdioWrapper.Stderr()
+	globalOptions.stdout, globalOptions.stderr = ui.WrapStdio(term)
 
 	return term, func() {
 		// shutdown termstatus
diff --git a/internal/ui/stdio_wrapper.go b/internal/ui/stdio_wrapper.go
index 6566ab67c..f78533601 100644
--- a/internal/ui/stdio_wrapper.go
+++ b/internal/ui/stdio_wrapper.go
@@ -7,33 +7,10 @@ import (
 	"github.com/restic/restic/internal/ui/termstatus"
 )
 
-// StdioWrapper provides stdout and stderr integration with termstatus.
-type StdioWrapper struct {
-	stdout *lineWriter
-	stderr *lineWriter
-}
-
-// NewStdioWrapper initializes a new stdio wrapper that can be used in place of
-// os.Stdout or os.Stderr.
-func NewStdioWrapper(term *termstatus.Terminal) *StdioWrapper {
-	return &StdioWrapper{
-		stdout: newLineWriter(term.Print),
-		stderr: newLineWriter(term.Error),
-	}
-}
-
-// Stdout returns a writer that is line buffered and can be used in place of
-// os.Stdout. On Close(), the remaining bytes are written, followed by a line
-// break.
-func (w *StdioWrapper) Stdout() io.WriteCloser {
-	return w.stdout
-}
-
-// Stderr returns a writer that is line buffered and can be used in place of
-// os.Stderr. On Close(), the remaining bytes are written, followed by a line
-// break.
-func (w *StdioWrapper) Stderr() io.WriteCloser {
-	return w.stderr
+// WrapStdio returns line-buffering replacements for os.Stdout and os.Stderr.
+// On Close, the remaining bytes are written, followed by a line break.
+func WrapStdio(term *termstatus.Terminal) (stdout, stderr io.WriteCloser) {
+	return newLineWriter(term.Print), newLineWriter(term.Error)
 }
 
 type lineWriter struct {