mirror/restic
1
0
Fork 0
mirror of https://github.com/restic/restic.git synced 2024-12-22 15:57:07 +00:00
Code Issues Releases Wiki Activity

Improve readability

Browse source 
It's time to use a switch statement.
This commit is contained in:
Alexander Neumann 2020-11-02 11:24:26 +01:00
parent 04dfa19c7e
commit 5f0fa2129e
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
internal/dump/tar_test.go
View file

@ -153,7 +153,8 @@ func checkTar(t *testing.T, testDir string, srcTar *bytes.Buffer) error {
return fmt.Errorf("mode does not match, got: %v, want: %v", os.FileMode(hdr.Mode), match.Mode()) return fmt.Errorf("mode does not match, got: %v, want: %v", os.FileMode(hdr.Mode), match.Mode())
} }
if hdr.Typeflag == tar.TypeDir { switch hdr.Typeflag {
case tar.TypeDir:
// this is a folder // this is a folder
if hdr.Name == "." { if hdr.Name == "." {
// we don't need to check the root folder // we don't need to check the root folder
@ -167,7 +168,7 @@ func checkTar(t *testing.T, testDir string, srcTar *bytes.Buffer) error {
if !strings.HasSuffix(hdr.Name, "/") { if !strings.HasSuffix(hdr.Name, "/") {
return fmt.Errorf("foldernames must end with separator got %v", hdr.Name) return fmt.Errorf("foldernames must end with separator got %v", hdr.Name)
} }
} else if hdr.Typeflag == tar.TypeSymlink { case tar.TypeSymlink:
target, err := fs.Readlink(matchPath) target, err := fs.Readlink(matchPath)
if err != nil { if err != nil {
return err return err
@ -175,7 +176,7 @@ func checkTar(t *testing.T, testDir string, srcTar *bytes.Buffer) error {
if target != hdr.Linkname { if target != hdr.Linkname {
return fmt.Errorf("symlink target does not match, got %s want %s", target, hdr.Linkname) return fmt.Errorf("symlink target does not match, got %s want %s", target, hdr.Linkname)
} }
} else { default:
if match.Size() != hdr.Size { if match.Size() != hdr.Size {
return fmt.Errorf("size does not match got %v want %v", hdr.Size, match.Size()) return fmt.Errorf("size does not match got %v want %v", hdr.Size, match.Size())
} }