mirror of https://github.com/restic/restic.git
Don't set a parent for --stdin backups
Loading any parent tree for these only wastes time and memory. Fixes #3641, where it was shown that the most recent tree will get picked. --parent is now implicitly ignored when --stdin is given.
This commit is contained in:
parent
58236ead12
commit
63f6a9b085
|
@ -0,0 +1,13 @@
|
|||
Change: Backups from stdin no longer have a parent
|
||||
|
||||
Snapshots made with `restic backup --stdin` no longer have a parent snapshot.
|
||||
Since parent snapshots are only used to skip files in the scanning phase
|
||||
based on filename and timestamps, the parent snapshot of a `--stdin` snapshot
|
||||
was meaningless to begin with. Not setting a parent allows `restic backup`
|
||||
to skip some startup operations.
|
||||
|
||||
The `--parent` option is still available for `restic backup --stdin`,
|
||||
but is now ignored.
|
||||
|
||||
https://github.com/restic/restic/issues/3641
|
||||
https://github.com/restic/restic/pull/3645
|
|
@ -579,16 +579,19 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, term *termstatus.Termina
|
|||
return err
|
||||
}
|
||||
|
||||
parentSnapshotID, err := findParentSnapshot(gopts.ctx, repo, opts, targets, timeStamp)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
var parentSnapshotID *restic.ID
|
||||
if !opts.Stdin {
|
||||
parentSnapshotID, err = findParentSnapshot(gopts.ctx, repo, opts, targets, timeStamp)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
if !gopts.JSON {
|
||||
if parentSnapshotID != nil {
|
||||
progressPrinter.P("using parent snapshot %v\n", parentSnapshotID.Str())
|
||||
} else {
|
||||
progressPrinter.P("no parent snapshot found, will read all files\n")
|
||||
if !gopts.JSON {
|
||||
if parentSnapshotID != nil {
|
||||
progressPrinter.P("using parent snapshot %v\n", parentSnapshotID.Str())
|
||||
} else {
|
||||
progressPrinter.P("no parent snapshot found, will read all files\n")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue