mirror/restic
1
0
Fork 0
mirror of https://github.com/restic/restic.git synced 2025-01-03 13:45:20 +00:00
Code Issues Releases Wiki Activity

fs: enable fd-based handles on Linux/macOS/Windows

Browse source
This commit is contained in:
Michael Eischer 2024-11-29 23:05:18 +01:00
parent 4b33540148
commit 9a0259cd0f
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
internal/feature/registry.go
View file

@ -8,6 +8,7 @@ const (
BackendErrorRedesign FlagName = "backend-error-redesign"
DeviceIDForHardlinks FlagName = "device-id-for-hardlinks"
ExplicitS3AnonymousAuth FlagName = "explicit-s3-anonymous-auth"
FilehandleBasedBackup FlagName = "filehandle-based-backup"
SafeForgetKeepTags FlagName = "safe-forget-keep-tags"
)
@ -15,6 +16,7 @@ func init() {
Flag.SetFlags(map[FlagName]FlagDesc{
BackendErrorRedesign: {Type: Beta, Description: "enforce timeouts for stuck HTTP requests and use new backend error handling design."},
DeviceIDForHardlinks: {Type: Alpha, Description: "store deviceID only for hardlinks to reduce metadata changes for example when using btrfs subvolumes. Will be removed in a future restic version after repository format 3 is available"},
FilehandleBasedBackup: {Type: Beta, Description: "`backup` uses filehandles to atomically collect file metadata on Linux/macOS/Windows"},
ExplicitS3AnonymousAuth: {Type: Beta, Description: "forbid anonymous S3 authentication unless `-o s3.unsafe-anonymous-auth=true` is set"},
SafeForgetKeepTags: {Type: Beta, Description: "prevent deleting all snapshots if the tag passed to `forget --keep-tags tagname` does not exist"},
})

11
internal/fs/fs_local.go
View file

@ -3,10 +3,15 @@ package fs
import (
"os"
"path/filepath"
"runtime"
"github.com/restic/restic/internal/feature"
"github.com/restic/restic/internal/restic"
)
// testOverwriteUseFd controls whether a fd based metadata handle is used when set.
var testOverwriteUseFd *bool
// Local is the local file system. Most methods are just passed on to the stdlib.
type Local struct{}
@ -243,7 +248,11 @@ func (f *fdLocalFile) MakeReadable() error {
}
func buildLocalFile(name string, flag int, metadataOnly bool) (File, error) {
useFd := true // FIXME
useFd := runtime.GOOS == "linux" || runtime.GOOS == "windows" || runtime.GOOS == "darwin"
useFd = useFd && feature.Flag.Enabled(feature.FilehandleBasedBackup)
if testOverwriteUseFd != nil {
useFd = *testOverwriteUseFd
}
if useFd {
return newFdLocalFile(name, flag, metadataOnly)
}