mirror/restic
1
0
Fork 0
mirror of https://github.com/restic/restic.git synced 2024-12-24 16:54:00 +00:00
Code Issues Releases Wiki Activity

Fix repository benchmarks

Browse source 
BenchmarkLoad{AndDecrypt,Blob} were spending between 38% and 50% of
their time measuring SHA-256 performance in their checks.
This commit is contained in:
greatroar 2020-04-28 07:57:29 +02:00
parent 42a3db05b0
commit f97a680887
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
internal/repository/repository_test.go
View file

@ -197,6 +197,10 @@ func BenchmarkLoadBlob(b *testing.B) {
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
var err error var err error
buf, err = repo.LoadBlob(context.TODO(), restic.DataBlob, id, buf) buf, err = repo.LoadBlob(context.TODO(), restic.DataBlob, id, buf)
// Checking the SHA-256 with restic.Hash can make up 38% of the time
// spent in this loop, so pause the timer.
b.StopTimer()
rtest.OK(b, err) rtest.OK(b, err)
if len(buf) != length { if len(buf) != length {
b.Errorf("wanted %d bytes, got %d", length, len(buf)) b.Errorf("wanted %d bytes, got %d", length, len(buf))
@ -206,6 +210,7 @@ func BenchmarkLoadBlob(b *testing.B) {
if !id.Equal(id2) { if !id.Equal(id2) {
b.Errorf("wrong data returned, wanted %v, got %v", id.Str(), id2.Str()) b.Errorf("wrong data returned, wanted %v, got %v", id.Str(), id2.Str())
} }
b.StartTimer()
} }
} }
@ -230,6 +235,9 @@ func BenchmarkLoadAndDecrypt(b *testing.B) {
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
data, err := repo.LoadAndDecrypt(context.TODO(), nil, restic.DataFile, storageID) data, err := repo.LoadAndDecrypt(context.TODO(), nil, restic.DataFile, storageID)
rtest.OK(b, err) rtest.OK(b, err)
// See comment in BenchmarkLoadBlob.
b.StopTimer()
if len(data) != length { if len(data) != length {
b.Errorf("wanted %d bytes, got %d", length, len(data)) b.Errorf("wanted %d bytes, got %d", length, len(data))
} }
@ -238,6 +246,7 @@ func BenchmarkLoadAndDecrypt(b *testing.B) {
if !dataID.Equal(id2) { if !dataID.Equal(id2) {
b.Errorf("wrong data returned, wanted %v, got %v", storageID.Str(), id2.Str()) b.Errorf("wrong data returned, wanted %v, got %v", storageID.Str(), id2.Str())
} }
b.StartTimer()
} }
} }