mirror of
https://github.com/restic/restic.git
synced 2025-03-04 18:48:39 +00:00
* feat(backends/s3): add warmup support before repacks and restores This commit introduces basic support for transitioning pack files stored in cold storage to hot storage on S3 and S3-compatible providers. To prevent unexpected behavior for existing users, the feature is gated behind new flags: - `s3.enable-restore`: opt-in flag (defaults to false) - `s3.restore-days`: number of days for the restored objects to remain in hot storage (defaults to `7`) - `s3.restore-timeout`: maximum time to wait for a single restoration (default to `1 day`) - `s3.restore-tier`: retrieval tier at which the restore will be processed. (default to `Standard`) As restoration times can be lengthy, this implementation preemptively restores selected packs to prevent incessant restore-delays during downloads. This is slightly sub-optimal as we could process packs out-of-order (as soon as they're transitioned), but this would really add too much complexity for a marginal gain in speed. To maintain simplicity and prevent resources exhautions with lots of packs, no new concurrency mechanisms or goroutines were added. This just hooks gracefully into the existing routines. **Limitations:** - Tests against the backend were not written due to the lack of cold storage class support in MinIO. Testing was done manually on Scaleway's S3-compatible object storage. If necessary, we could explore testing with LocalStack or mocks, though this requires further discussion. - Currently, this feature only warms up before restores and repacks (prune/copy), as those are the two main use-cases I came across. Support for other commands may be added in future iterations, as long as affected packs can be calculated in advance. - The feature is gated behind a new alpha `s3-restore` feature flag to make it explicit that the feature is still wet behind the ears. - There is no explicit user notification for ongoing pack restorations. While I think it is not necessary because of the opt-in flag, showing some notice may improve usability (but would probably require major refactoring in the progress bar which I didn't want to start). Another possibility would be to add a flag to send restores requests and fail early. See https://github.com/restic/restic/issues/3202 * ui: warn user when files are warming up from cold storage * refactor: remove the PacksWarmer struct It's easier to handle multiple handles in the backend directly, and it may open the door to reducing the number of requests made to the backend in the future.
134 lines
4.1 KiB
Go
134 lines
4.1 KiB
Go
package backend
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"hash"
|
|
"io"
|
|
)
|
|
|
|
var ErrNoRepository = fmt.Errorf("repository does not exist")
|
|
|
|
// Backend is used to store and access data.
|
|
//
|
|
// Backend operations that return an error will be retried when a Backend is
|
|
// wrapped in a RetryBackend. To prevent that from happening, the operations
|
|
// should return a github.com/cenkalti/backoff/v4.PermanentError. Errors from
|
|
// the context package need not be wrapped, as context cancellation is checked
|
|
// separately by the retrying logic.
|
|
type Backend interface {
|
|
// Connections returns the maximum number of concurrent backend operations.
|
|
Connections() uint
|
|
|
|
// Hasher may return a hash function for calculating a content hash for the backend
|
|
Hasher() hash.Hash
|
|
|
|
// HasAtomicReplace returns whether Save() can atomically replace files
|
|
HasAtomicReplace() bool
|
|
|
|
// Remove removes a File described by h.
|
|
Remove(ctx context.Context, h Handle) error
|
|
|
|
// Close the backend
|
|
Close() error
|
|
|
|
// Save stores the data from rd under the given handle.
|
|
Save(ctx context.Context, h Handle, rd RewindReader) error
|
|
|
|
// Load runs fn with a reader that yields the contents of the file at h at the
|
|
// given offset. If length is larger than zero, only a portion of the file
|
|
// is read. If the length is larger than zero and the file is too short to return
|
|
// the requested length bytes, then an error MUST be returned that is recognized
|
|
// by IsPermanentError().
|
|
//
|
|
// The function fn may be called multiple times during the same Load invocation
|
|
// and therefore must be idempotent.
|
|
//
|
|
// Implementations are encouraged to use util.DefaultLoad
|
|
Load(ctx context.Context, h Handle, length int, offset int64, fn func(rd io.Reader) error) error
|
|
|
|
// Stat returns information about the File identified by h.
|
|
Stat(ctx context.Context, h Handle) (FileInfo, error)
|
|
|
|
// List runs fn for each file in the backend which has the type t. When an
|
|
// error occurs (or fn returns an error), List stops and returns it.
|
|
//
|
|
// The function fn is called exactly once for each file during successful
|
|
// execution and at most once in case of an error.
|
|
//
|
|
// The function fn is called in the same Goroutine that List() is called
|
|
// from.
|
|
List(ctx context.Context, t FileType, fn func(FileInfo) error) error
|
|
|
|
// IsNotExist returns true if the error was caused by a non-existing file
|
|
// in the backend.
|
|
//
|
|
// The argument may be a wrapped error. The implementation is responsible
|
|
// for unwrapping it.
|
|
IsNotExist(err error) bool
|
|
|
|
// IsPermanentError returns true if the error can very likely not be resolved
|
|
// by retrying the operation. Backends should return true if the file is missing,
|
|
// the requested range does not (completely) exist in the file or the user is
|
|
// not authorized to perform the requested operation.
|
|
IsPermanentError(err error) bool
|
|
|
|
// Delete removes all data in the backend.
|
|
Delete(ctx context.Context) error
|
|
|
|
// Warmup ensures that the specified handles are ready for upcoming reads.
|
|
// This is particularly useful for transitioning files from cold to hot
|
|
// storage.
|
|
//
|
|
// The method is non-blocking. WarmupWait can be used to wait for
|
|
// completion.
|
|
//
|
|
// Returns:
|
|
// - Handles currently warming up.
|
|
// - An error if warmup fails.
|
|
Warmup(ctx context.Context, h []Handle) ([]Handle, error)
|
|
|
|
// WarmupWait waits until all given handles are warm.
|
|
WarmupWait(ctx context.Context, h []Handle) error
|
|
}
|
|
|
|
type Unwrapper interface {
|
|
// Unwrap returns the underlying backend or nil if there is none.
|
|
Unwrap() Backend
|
|
}
|
|
|
|
func AsBackend[B Backend](b Backend) B {
|
|
for b != nil {
|
|
if be, ok := b.(B); ok {
|
|
return be
|
|
}
|
|
|
|
if be, ok := b.(Unwrapper); ok {
|
|
b = be.Unwrap()
|
|
} else {
|
|
// not the backend we're looking for
|
|
break
|
|
}
|
|
}
|
|
var be B
|
|
return be
|
|
}
|
|
|
|
type FreezeBackend interface {
|
|
Backend
|
|
// Freeze blocks all backend operations except those on lock files
|
|
Freeze()
|
|
// Unfreeze allows all backend operations to continue
|
|
Unfreeze()
|
|
}
|
|
|
|
// FileInfo is contains information about a file in the backend.
|
|
type FileInfo struct {
|
|
Size int64
|
|
Name string
|
|
}
|
|
|
|
// ApplyEnvironmenter fills in a backend configuration from the environment
|
|
type ApplyEnvironmenter interface {
|
|
ApplyEnvironment(prefix string)
|
|
}
|