2014-06-23 02:38:53 +00:00
|
|
|
/*
|
|
|
|
* This file Copyright (C) 2013-2014 Mnemosyne LLC
|
|
|
|
*
|
|
|
|
* It may be used under the GNU GPL versions 2 or 3
|
|
|
|
* or any future license endorsed by Mnemosyne LLC.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "transmission.h"
|
|
|
|
#include "error.h"
|
2017-06-08 07:24:12 +00:00
|
|
|
#include "tr-assert.h"
|
2014-06-23 02:38:53 +00:00
|
|
|
#include "utils.h"
|
|
|
|
|
2017-04-20 16:02:19 +00:00
|
|
|
tr_error* tr_error_new_literal(int code, char const* message)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(message != nullptr);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-06-13 02:24:09 +00:00
|
|
|
tr_error* error = tr_new(tr_error, 1);
|
2017-04-19 12:04:45 +00:00
|
|
|
error->code = code;
|
|
|
|
error->message = tr_strdup(message);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
return error;
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
|
|
|
|
2017-04-20 16:02:19 +00:00
|
|
|
tr_error* tr_error_new_valist(int code, char const* message_format, va_list args)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(message_format != nullptr);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-06-13 02:24:09 +00:00
|
|
|
tr_error* error = tr_new(tr_error, 1);
|
2017-04-19 12:04:45 +00:00
|
|
|
error->code = code;
|
|
|
|
error->message = tr_strdup_vprintf(message_format, args);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
return error;
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
void tr_error_free(tr_error* error)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
if (error == nullptr)
|
2017-04-19 12:04:45 +00:00
|
|
|
{
|
|
|
|
return;
|
|
|
|
}
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
tr_free(error->message);
|
|
|
|
tr_free(error);
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
|
|
|
|
2017-04-20 16:02:19 +00:00
|
|
|
void tr_error_set(tr_error** error, int code, char const* message_format, ...)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(message_format != nullptr);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2021-09-15 00:18:09 +00:00
|
|
|
if (error == nullptr)
|
2017-04-19 12:04:45 +00:00
|
|
|
{
|
|
|
|
return;
|
|
|
|
}
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(*error == nullptr);
|
2017-06-13 02:24:09 +00:00
|
|
|
|
|
|
|
va_list args;
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
va_start(args, message_format);
|
|
|
|
*error = tr_error_new_valist(code, message_format, args);
|
|
|
|
va_end(args);
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
|
|
|
|
2017-04-20 16:02:19 +00:00
|
|
|
void tr_error_set_literal(tr_error** error, int code, char const* message)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(message != nullptr);
|
2017-06-13 02:24:09 +00:00
|
|
|
|
2021-09-15 00:18:09 +00:00
|
|
|
if (error == nullptr)
|
2017-04-19 12:04:45 +00:00
|
|
|
{
|
|
|
|
return;
|
|
|
|
}
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(*error == nullptr);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
*error = tr_error_new_literal(code, message);
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
void tr_error_propagate(tr_error** new_error, tr_error** old_error)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(old_error != nullptr);
|
|
|
|
TR_ASSERT(*old_error != nullptr);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2021-09-15 00:18:09 +00:00
|
|
|
if (new_error != nullptr)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(*new_error == nullptr);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
*new_error = *old_error;
|
2021-09-15 00:18:09 +00:00
|
|
|
*old_error = nullptr;
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
2017-04-19 12:04:45 +00:00
|
|
|
else
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2017-04-19 12:04:45 +00:00
|
|
|
tr_error_clear(old_error);
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
void tr_error_clear(tr_error** error)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
if (error == nullptr)
|
2017-04-19 12:04:45 +00:00
|
|
|
{
|
|
|
|
return;
|
|
|
|
}
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
tr_error_free(*error);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2021-09-15 00:18:09 +00:00
|
|
|
*error = nullptr;
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
|
|
|
|
fix: gcc warnings in libtransmission/ and utils/ (#843)
* fix: __attribute__(__printf__) warnings
* fix: implicit fallthrough warning
* fixup! fix: implicit fallthrough warning
* fix: disable warnings for 3rd party code
Since we want to leave upstream code as-is
* fixup! fix: disable warnings for 3rd party code
* fixup! fix: disable warnings for 3rd party code
* silence spurious alignment warning
Xrefs
Discussion: https://stackoverflow.com/a/35554349
Macro inspiration: https://pagure.io/SSSD/sssd/blob/90ac46f71068d131391492360a8553bdd005b5a7/f/src/util/util_safealign.h#_35
* fixup! fix: disable warnings for 3rd party code
* fixup! fix: implicit fallthrough warning
* make uncrustify happy
* remove uncrustify-test.sh
that's probably off-topic for this PR
* fixup! fix: __attribute__(__printf__) warnings
* Update libtransmission/CMakeLists.txt
Co-Authored-By: ckerr <ckerr@github.com>
* fixup! silence spurious alignment warning
* use -w for DISABLE_WARNINGS in Clang
* refactor: fix libtransmission deprecation warnings
* fix: pthread_create's start_routine's return value
This was defined as `void` on non-Windows but should have been `void*`
* chore: uncrustify
* fix: add DISABLE_WARNINGS option for SunPro Studio
* fix "unused in lambda capture" warnings by clang++
* fix 'increases required alignment' warning
Caused from storing int16_t's in a char array.
* fix net.c 'increases required alignment' warning
The code passes in a `struct sockaddr_storage*` which is a padded struct
large enough for the necessary alignment. Unfortunately it was recast as
a `struct sockaddr*` which has less padding and a smaller alignment. The
warning occrred because of these differing alignments.
* make building quieter so warnings are more visible
* fixup! fix 'increases required alignment' warning
* Fix -Wcast-function-type warnings in GTK+ app code
https://gitlab.gnome.org/GNOME/gnome-terminal/issues/96 talks about both
the issue and its solution.
GCC 8's -Wcast-function-type, enabled by -Wextra, is problematic in glib
applications because it's idiomatic there to recast function signatures,
e.g. `g_slist_free(list, (GFunc)g_free, NULL);`.
Disabling the warning with pragmas causes "unrecognized pragma" warnings
on clang and older versions of gcc, and disabling the warning could miss
actual bugs. GCC defines `void (*)(void)` as a special case that matches
anything so we can silence warnings by double-casting through GCallback.
In the previous example, the warning is silenced by changing the code to
read `g_slist_free(list, (GFunc)(GCallback)g_free, NULL);`).
* fixup! fix "unused in lambda capture" warnings by clang++
* fixup! fix "unused in lambda capture" warnings by clang++
* fix two more libtransmission compiler warnings
* fix: in watchdir, use TR_ENABLE_ASSERTS not NDEBUG
2019-11-06 17:27:03 +00:00
|
|
|
static void error_prefix_valist(tr_error** error, char const* prefix_format, va_list args) TR_GNUC_PRINTF(2, 0);
|
|
|
|
|
2017-04-20 16:02:19 +00:00
|
|
|
static void error_prefix_valist(tr_error** error, char const* prefix_format, va_list args)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(error != nullptr);
|
|
|
|
TR_ASSERT(*error != nullptr);
|
|
|
|
TR_ASSERT(prefix_format != nullptr);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-06-13 02:24:09 +00:00
|
|
|
char* prefix = tr_strdup_vprintf(prefix_format, args);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-06-13 02:24:09 +00:00
|
|
|
char* new_message = tr_strdup_printf("%s%s", prefix, (*error)->message);
|
2017-04-19 12:04:45 +00:00
|
|
|
tr_free((*error)->message);
|
|
|
|
(*error)->message = new_message;
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
tr_free(prefix);
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
|
|
|
|
2017-04-20 16:02:19 +00:00
|
|
|
void tr_error_prefix(tr_error** error, char const* prefix_format, ...)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(prefix_format != nullptr);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2021-09-15 00:18:09 +00:00
|
|
|
if (error == nullptr || *error == nullptr)
|
2017-04-19 12:04:45 +00:00
|
|
|
{
|
|
|
|
return;
|
|
|
|
}
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-06-13 02:24:09 +00:00
|
|
|
va_list args;
|
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
va_start(args, prefix_format);
|
|
|
|
error_prefix_valist(error, prefix_format, args);
|
|
|
|
va_end(args);
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|
|
|
|
|
2017-04-20 16:02:19 +00:00
|
|
|
void tr_error_propagate_prefixed(tr_error** new_error, tr_error** old_error, char const* prefix_format, ...)
|
2014-06-23 02:38:53 +00:00
|
|
|
{
|
2021-09-15 00:18:09 +00:00
|
|
|
TR_ASSERT(prefix_format != nullptr);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
tr_error_propagate(new_error, old_error);
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2021-09-15 00:18:09 +00:00
|
|
|
if (new_error == nullptr)
|
2017-04-19 12:04:45 +00:00
|
|
|
{
|
|
|
|
return;
|
|
|
|
}
|
2014-06-23 02:38:53 +00:00
|
|
|
|
2017-06-13 02:24:09 +00:00
|
|
|
va_list args;
|
|
|
|
|
2017-04-19 12:04:45 +00:00
|
|
|
va_start(args, prefix_format);
|
|
|
|
error_prefix_valist(new_error, prefix_format, args);
|
|
|
|
va_end(args);
|
2014-06-23 02:38:53 +00:00
|
|
|
}
|