mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity
transmission/gtk/details.c

3033 lines
91 KiB
C
Raw Normal View History

decouple the torrent file list from the torrent inspector so that it can be reused in the "add torrent" dialog
2008-02-10 22:25:42 +00:00
/*
Licensing changes: 1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed 2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :) 3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
* This file Copyright (C) 2007-2014 Mnemosyne LLC
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
*
Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text
2014-01-21 03:10:30 +00:00
* It may be used under the GNU GPL versions 2 or 3
Licensing changes: 1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed 2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :) 3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
* or any future license endorsed by Mnemosyne LLC.
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
*
decouple the torrent file list from the torrent inspector so that it can be reused in the "add torrent" dialog
2008-02-10 22:25:42 +00:00
*/
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
#include limits.h where we use it, and don't where we don't
2013-08-24 17:53:45 +00:00
#include <limits.h> /* INT_MAX */
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
#include <stddef.h>
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
#include <stdio.h> /* sscanf() */
#include <stdlib.h> /* abort() */
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
#include <glib/gi18n.h>
#include <gtk/gtk.h>
Merge file selection and torrent creation into the main branch. The new code for these features is under a new license.
2007-06-18 03:40:41 +00:00
part one of moving the build environment over to automake/autoconf. beware!
2007-07-18 23:04:26 +00:00
#include <libtransmission/transmission.h>
(gtk) clean up yesterday's properties dialog rewrite a bit.
2009-04-24 12:05:53 +00:00
#include <libtransmission/utils.h> /* tr_free */
Merge file selection and torrent creation into the main branch. The new code for these features is under a new license.
2007-06-18 03:40:41 +00:00
#include "actions.h"
(trunk gtk) kill "pref_flag_t" in a burlap sack and throw it off the cliff into the freezing water below
2010-12-22 06:11:49 +00:00
#include "conf.h"
(gtk) add ability to delete downloaded files when deleting a torrent
2008-02-19 03:57:03 +00:00
#include "details.h"
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
#include "favicon.h" /* gtr_get_favicon() */
decouple the torrent file list from the torrent inspector so that it can be reused in the "add torrent" dialog
2008-02-10 22:25:42 +00:00
#include "file-list.h"
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
#include "hig.h"
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
#include "tr-prefs.h"
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
#include "util.h"
(trunk gtk) in the details dialog, use the GQuark versions of g_object_{get,set}_data()
2011-04-29 21:36:44 +00:00
static GQuark ARG_KEY = 0;
static GQuark DETAILS_KEY = 0;
static GQuark TORRENT_ID_KEY = 0;
static GQuark TEXT_BUFFER_KEY = 0;
static GQuark URL_ENTRY_KEY = 0;
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
struct DetailsImpl
(trunk) #1787: add support for seeding ratio limiting in libtransmission
2009-02-13 18:23:56 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* dialog;
GtkWidget* honor_limits_check;
GtkWidget* up_limited_check;
GtkWidget* up_limit_sping;
GtkWidget* down_limited_check;
GtkWidget* down_limit_spin;
GtkWidget* bandwidth_combo;
GtkWidget* ratio_combo;
GtkWidget* ratio_spin;
GtkWidget* idle_combo;
GtkWidget* idle_spin;
GtkWidget* max_peers_spin;
gulong honor_limits_check_tag;
gulong up_limited_check_tag;
gulong down_limited_check_tag;
gulong down_limit_spin_tag;
gulong up_limit_spin_tag;
gulong bandwidth_combo_tag;
gulong ratio_combo_tag;
gulong ratio_spin_tag;
gulong idle_combo_tag;
gulong idle_spin_tag;
gulong max_peers_spin_tag;
GtkWidget* size_lb;
GtkWidget* state_lb;
GtkWidget* have_lb;
GtkWidget* dl_lb;
GtkWidget* ul_lb;
GtkWidget* error_lb;
GtkWidget* date_started_lb;
GtkWidget* eta_lb;
GtkWidget* last_activity_lb;
GtkWidget* hash_lb;
GtkWidget* privacy_lb;
GtkWidget* origin_lb;
GtkWidget* destination_lb;
GtkTextBuffer* comment_buffer;
GHashTable* peer_hash;
GHashTable* webseed_hash;
GtkListStore* peer_store;
GtkListStore* webseed_store;
GtkWidget* webseed_view;
GtkWidget* peer_view;
GtkWidget* more_peer_details_check;
GtkListStore* tracker_store;
GHashTable* tracker_hash;
GtkTreeModel* trackers_filtered;
GtkWidget* add_tracker_button;
GtkWidget* edit_trackers_button;
GtkWidget* remove_tracker_button;
GtkWidget* tracker_view;
GtkWidget* scrape_check;
GtkWidget* all_check;
GtkWidget* file_list;
GtkWidget* file_label;
GSList* ids;
TrCore* core;
guint periodic_refresh_tag;
GString* gstr;
more webseed work.
2008-06-10 02:36:52 +00:00
};
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static tr_torrent** getTorrents(struct DetailsImpl* d, int* setmeCount)
more webseed work.
2008-06-10 02:36:52 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int torrentCount = 0;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const n = g_slist_length(d->ids);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_torrent** torrents = g_new(tr_torrent*, n);
(trunk gtk) fix crash when leaving the properties dialog open during shutdown
2009-06-15 00:01:38 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (GSList* l = d->ids; l != NULL; l = l->next)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if ((torrents[torrentCount] = gtr_core_find_torrent(d->core, GPOINTER_TO_INT(l->data))) != NULL)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
++torrentCount;
}
}
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
*setmeCount = torrentCount;
return torrents;
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
more webseed work.
2008-06-10 02:36:52 +00:00
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
/****
*****
***** OPTIONS TAB
*****
****/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void set_togglebutton_if_different(GtkWidget* w, gulong tag, gboolean value)
more webseed work.
2008-06-10 02:36:52 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkToggleButton* toggle = GTK_TOGGLE_BUTTON(w);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
gboolean const currentValue = gtk_toggle_button_get_active(toggle);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (currentValue != value)
more webseed work.
2008-06-10 02:36:52 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_signal_handler_block(toggle, tag);
gtk_toggle_button_set_active(toggle, value);
g_signal_handler_unblock(toggle, tag);
more webseed work.
2008-06-10 02:36:52 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void set_int_spin_if_different(GtkWidget* w, gulong tag, int value)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkSpinButton* spin = GTK_SPIN_BUTTON(w);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const currentValue = gtk_spin_button_get_value_as_int(spin);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (currentValue != value)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_signal_handler_block(spin, tag);
gtk_spin_button_set_value(spin, value);
g_signal_handler_unblock(spin, tag);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
}
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void set_double_spin_if_different(GtkWidget* w, gulong tag, double value)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkSpinButton* spin = GTK_SPIN_BUTTON(w);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
double const currentValue = gtk_spin_button_get_value(spin);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if ((int)(currentValue * 100) != (int)(value * 100))
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_signal_handler_block(spin, tag);
gtk_spin_button_set_value(spin, value);
g_signal_handler_unblock(spin, tag);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
}
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void unset_combo(GtkWidget* w, gulong tag)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkComboBox* combobox = GTK_COMBO_BOX(w);
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_signal_handler_block(combobox, tag);
gtk_combo_box_set_active(combobox, -1);
g_signal_handler_unblock(combobox, tag);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void refreshOptions(struct DetailsImpl* di, tr_torrent** torrents, int n)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/***
**** Options Page
***/
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* honor_limits_check */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
bool const baseline = tr_torrentUsesSessionLimits(torrents[0]);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == tr_torrentUsesSessionLimits(torrents[i]);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (is_uniform)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
set_togglebutton_if_different(di->honor_limits_check, di->honor_limits_check_tag, baseline);
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* down_limited_check */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
bool const baseline = tr_torrentUsesSpeedLimit(torrents[0], TR_DOWN);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == tr_torrentUsesSpeedLimit(torrents[i], TR_DOWN);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (is_uniform)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
set_togglebutton_if_different(di->down_limited_check, di->down_limited_check_tag, baseline);
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* down_limit_spin */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
unsigned int const baseline = tr_torrentGetSpeedLimit_KBps(torrents[0], TR_DOWN);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == tr_torrentGetSpeedLimit_KBps(torrents[i], TR_DOWN);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (is_uniform)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
set_int_spin_if_different(di->down_limit_spin, di->down_limit_spin_tag, baseline);
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* up_limited_check */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
bool const baseline = tr_torrentUsesSpeedLimit(torrents[0], TR_UP);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == tr_torrentUsesSpeedLimit(torrents[i], TR_UP);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (is_uniform)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
set_togglebutton_if_different(di->up_limited_check, di->up_limited_check_tag, baseline);
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* up_limit_sping */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
unsigned int const baseline = tr_torrentGetSpeedLimit_KBps(torrents[0], TR_UP);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == tr_torrentGetSpeedLimit_KBps(torrents[i], TR_UP);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (is_uniform)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
set_int_spin_if_different(di->up_limit_sping, di->up_limit_spin_tag, baseline);
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* bandwidth_combo */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const baseline = tr_torrentGetPriority(torrents[0]);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == tr_torrentGetPriority(torrents[i]);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (is_uniform)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* w = di->bandwidth_combo;
g_signal_handler_block(w, di->bandwidth_combo_tag);
gtr_priority_combo_set_value(GTK_COMBO_BOX(w), baseline);
g_signal_handler_unblock(w, di->bandwidth_combo_tag);
(trunk gtk) "Priority Selection in `Add' window" -- implemented for GTK+ client
2010-02-02 07:51:45 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
unset_combo(di->bandwidth_combo, di->bandwidth_combo_tag);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* ratio_combo */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const baseline = tr_torrentGetRatioMode(torrents[0]);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == (int)tr_torrentGetRatioMode(torrents[i]);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (is_uniform)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* w = di->ratio_combo;
g_signal_handler_block(w, di->ratio_combo_tag);
gtr_combo_box_set_active_enum(GTK_COMBO_BOX(w), baseline);
gtr_widget_set_visible(di->ratio_spin, baseline == TR_RATIOLIMIT_SINGLE);
g_signal_handler_unblock(w, di->ratio_combo_tag);
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
}
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* ratio_spin */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
double const baseline = tr_torrentGetRatioLimit(torrents[0]);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
set_double_spin_if_different(di->ratio_spin, di->ratio_spin_tag, baseline);
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* idle_combo */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const baseline = tr_torrentGetIdleMode(torrents[0]);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == (int)tr_torrentGetIdleMode(torrents[i]);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (is_uniform)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* w = di->idle_combo;
g_signal_handler_block(w, di->idle_combo_tag);
gtr_combo_box_set_active_enum(GTK_COMBO_BOX(w), baseline);
gtr_widget_set_visible(di->idle_spin, baseline == TR_IDLELIMIT_SINGLE);
g_signal_handler_unblock(w, di->idle_combo_tag);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* idle_spin */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const baseline = tr_torrentGetIdleLimit(torrents[0]);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
set_int_spin_if_different(di->idle_spin, di->idle_spin_tag, baseline);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* max_peers_spin */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (n != 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const baseline = tr_torrentGetPeerLimit(torrents[0]);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
set_int_spin_if_different(di->max_peers_spin, di->max_peers_spin_tag, baseline);
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
}
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void torrent_set_bool(struct DetailsImpl* di, tr_quark const key, gboolean value)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
tr_variant top;
tr_variant* args;
tr_variant* ids;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_variantInitDict(&top, 2);
tr_variantDictAddStr(&top, TR_KEY_method, "torrent-set");
args = tr_variantDictAddDict(&top, TR_KEY_arguments, 2);
tr_variantDictAddBool(args, key, value);
ids = tr_variantDictAddList(args, TR_KEY_ids, g_slist_length(di->ids));
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (GSList* l = di->ids; l != NULL; l = l->next)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
tr_variantListAddInt(ids, GPOINTER_TO_INT(l->data));
}
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_core_exec(di->core, &top);
tr_variantFree(&top);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void torrent_set_int(struct DetailsImpl* di, tr_quark const key, int value)
merge encryption branch to trunk (xcode project is still out of date)
2007-09-20 16:32:01 +00:00
{
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
tr_variant top;
tr_variant* args;
tr_variant* ids;
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_variantInitDict(&top, 2);
tr_variantDictAddStr(&top, TR_KEY_method, "torrent-set");
args = tr_variantDictAddDict(&top, TR_KEY_arguments, 2);
tr_variantDictAddInt(args, key, value);
ids = tr_variantDictAddList(args, TR_KEY_ids, g_slist_length(di->ids));
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (GSList* l = di->ids; l != NULL; l = l->next)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
tr_variantListAddInt(ids, GPOINTER_TO_INT(l->data));
}
gtr_core_exec(di->core, &top);
tr_variantFree(&top);
merge encryption branch to trunk (xcode project is still out of date)
2007-09-20 16:32:01 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void torrent_set_real(struct DetailsImpl* di, tr_quark const key, double value)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
tr_variant top;
tr_variant* args;
tr_variant* ids;
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_variantInitDict(&top, 2);
tr_variantDictAddStr(&top, TR_KEY_method, "torrent-set");
args = tr_variantDictAddDict(&top, TR_KEY_arguments, 2);
tr_variantDictAddReal(args, key, value);
ids = tr_variantDictAddList(args, TR_KEY_ids, g_slist_length(di->ids));
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (GSList* l = di->ids; l != NULL; l = l->next)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
tr_variantListAddInt(ids, GPOINTER_TO_INT(l->data));
}
gtr_core_exec(di->core, &top);
tr_variantFree(&top);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void up_speed_toggled_cb(GtkToggleButton* tb, gpointer d)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_bool(d, TR_KEY_uploadLimited, gtk_toggle_button_get_active(tb));
(trunk gtk) minor tweaks
2009-03-05 17:18:36 +00:00
}
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void down_speed_toggled_cb(GtkToggleButton* tb, gpointer d)
(trunk gtk) minor tweaks
2009-03-05 17:18:36 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_bool(d, TR_KEY_downloadLimited, gtk_toggle_button_get_active(tb));
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void global_speed_toggled_cb(GtkToggleButton* tb, gpointer d)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_bool(d, TR_KEY_honorsSessionLimits, gtk_toggle_button_get_active(tb));
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void up_speed_spun_cb(GtkSpinButton* s, struct DetailsImpl* di)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_int(di, TR_KEY_uploadLimit, gtk_spin_button_get_value_as_int(s));
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void down_speed_spun_cb(GtkSpinButton* s, struct DetailsImpl* di)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_int(di, TR_KEY_downloadLimit, gtk_spin_button_get_value_as_int(s));
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void idle_spun_cb(GtkSpinButton* s, struct DetailsImpl* di)
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_int(di, TR_KEY_seedIdleLimit, gtk_spin_button_get_value_as_int(s));
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void ratio_spun_cb(GtkSpinButton* s, struct DetailsImpl* di)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_real(di, TR_KEY_seedRatioLimit, gtk_spin_button_get_value(s));
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void max_peers_spun_cb(GtkSpinButton* s, struct DetailsImpl* di)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_int(di, TR_KEY_peer_limit, gtk_spin_button_get_value(s));
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void onPriorityChanged(GtkComboBox* combo_box, struct DetailsImpl* di)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_priority_t const priority = gtr_priority_combo_get_value(combo_box);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_int(di, TR_KEY_bandwidthPriority, priority);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static GtkWidget* new_priority_combo(struct DetailsImpl* di)
(gtk) #860: Nobody knows what the UI DEI etc. it the Details>Peers status column mean
2008-04-12 01:36:31 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* w = gtr_priority_combo_new();
di->bandwidth_combo_tag = g_signal_connect(w, "changed", G_CALLBACK(onPriorityChanged), di);
return w;
(gtk) #860: Nobody knows what the UI DEI etc. it the Details>Peers status column mean
2008-04-12 01:36:31 +00:00
}
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void refresh(struct DetailsImpl* di);
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void onComboEnumChanged(GtkComboBox* combo_box, struct DetailsImpl* di)
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_quark const key = GPOINTER_TO_INT(g_object_get_qdata(G_OBJECT(combo_box), ARG_KEY));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
torrent_set_int(di, key, gtr_combo_box_get_active_enum(combo_box));
refresh(di);
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static GtkWidget* ratio_combo_new(void)
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* w = gtr_combo_box_new_enum(
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
_("Use global settings"), TR_RATIOLIMIT_GLOBAL,
_("Seed regardless of ratio"), TR_RATIOLIMIT_UNLIMITED,
_("Stop seeding at ratio:"), TR_RATIOLIMIT_SINGLE,
NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_object_set_qdata(G_OBJECT(w), ARG_KEY, GINT_TO_POINTER(TR_KEY_seedRatioMode));
return w;
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static GtkWidget* idle_combo_new(void)
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* w = gtr_combo_box_new_enum(
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
_("Use global settings"), TR_IDLELIMIT_GLOBAL,
_("Seed regardless of activity"), TR_IDLELIMIT_UNLIMITED,
_("Stop seeding if idle for N minutes:"), TR_IDLELIMIT_SINGLE,
NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_object_set_qdata(G_OBJECT(w), ARG_KEY, GINT_TO_POINTER(TR_KEY_seedIdleMode));
return w;
(trunk) #2560: rename "inactive limit" to "idle limit". Add support in GTK+ client and preliminary support to Qt client
2010-07-24 02:57:39 +00:00
}
(gtk) #860: Nobody knows what the UI DEI etc. it the Details>Peers status column mean
2008-04-12 01:36:31 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static GtkWidget* options_page_new(struct DetailsImpl* d)
{
guint row;
gulong tag;
char buf[128];
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
GtkWidget* t;
GtkWidget* w;
GtkWidget* tb;
GtkWidget* h;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
row = 0;
t = hig_workarea_create();
hig_workarea_add_section_title(t, &row, _("Speed"));
tb = hig_workarea_add_wide_checkbutton(t, &row, _("Honor global _limits"), 0);
d->honor_limits_check = tb;
tag = g_signal_connect(tb, "toggled", G_CALLBACK(global_speed_toggled_cb), d);
d->honor_limits_check_tag = tag;
g_snprintf(buf, sizeof(buf), _("Limit _download speed (%s):"), _(speed_K_str));
tb = gtk_check_button_new_with_mnemonic(buf);
gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(tb), FALSE);
d->down_limited_check = tb;
tag = g_signal_connect(tb, "toggled", G_CALLBACK(down_speed_toggled_cb), d);
d->down_limited_check_tag = tag;
w = gtk_spin_button_new_with_range(0, INT_MAX, 5);
tag = g_signal_connect(w, "value-changed", G_CALLBACK(down_speed_spun_cb), d);
d->down_limit_spin_tag = tag;
hig_workarea_add_row_w(t, &row, tb, w, NULL);
d->down_limit_spin = w;
g_snprintf(buf, sizeof(buf), _("Limit _upload speed (%s):"), _(speed_K_str));
tb = gtk_check_button_new_with_mnemonic(buf);
d->up_limited_check = tb;
tag = g_signal_connect(tb, "toggled", G_CALLBACK(up_speed_toggled_cb), d);
d->up_limited_check_tag = tag;
w = gtk_spin_button_new_with_range(0, INT_MAX, 5);
tag = g_signal_connect(w, "value-changed", G_CALLBACK(up_speed_spun_cb), d);
d->up_limit_spin_tag = tag;
hig_workarea_add_row_w(t, &row, tb, w, NULL);
d->up_limit_sping = w;
w = new_priority_combo(d);
hig_workarea_add_row(t, &row, _("Torrent _priority:"), w, NULL);
d->bandwidth_combo = w;
hig_workarea_add_section_divider(t, &row);
hig_workarea_add_section_title(t, &row, _("Seeding Limits"));
h = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, GUI_PAD);
w = d->ratio_combo = ratio_combo_new();
d->ratio_combo_tag = g_signal_connect(w, "changed", G_CALLBACK(onComboEnumChanged), d);
gtk_box_pack_start(GTK_BOX(h), w, TRUE, TRUE, 0);
w = d->ratio_spin = gtk_spin_button_new_with_range(0, 1000, .05);
gtk_entry_set_width_chars(GTK_ENTRY(w), 7);
d->ratio_spin_tag = g_signal_connect(w, "value-changed", G_CALLBACK(ratio_spun_cb), d);
gtk_box_pack_start(GTK_BOX(h), w, FALSE, FALSE, 0);
hig_workarea_add_row(t, &row, _("_Ratio:"), h, NULL);
h = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, GUI_PAD);
w = d->idle_combo = idle_combo_new();
d->idle_combo_tag = g_signal_connect(w, "changed", G_CALLBACK(onComboEnumChanged), d);
gtk_box_pack_start(GTK_BOX(h), w, TRUE, TRUE, 0);
Set idle seed limit range to 1..40320 (4 weeks tops) in all clients Fixes: #212
2017-07-05 18:07:16 +00:00
w = d->idle_spin = gtk_spin_button_new_with_range(1, 40320, 5);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
d->idle_spin_tag = g_signal_connect(w, "value-changed", G_CALLBACK(idle_spun_cb), d);
gtk_box_pack_start(GTK_BOX(h), w, FALSE, FALSE, 0);
hig_workarea_add_row(t, &row, _("_Idle:"), h, NULL);
hig_workarea_add_section_divider(t, &row);
hig_workarea_add_section_title(t, &row, _("Peer Connections"));
w = gtk_spin_button_new_with_range(1, 3000, 5);
hig_workarea_add_row(t, &row, _("_Maximum peers:"), w, w);
tag = g_signal_connect(w, "value-changed", G_CALLBACK(max_peers_spun_cb), d);
d->max_peers_spin = w;
d->max_peers_spin_tag = tag;
return t;
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
/****
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
*****
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
***** INFO TAB
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
*****
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
****/
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static char const* activityString(int activity, bool finished)
* change tr_stat.activityDate's and tr_stat.startedDate's type to time_t, since that's how everyone uses them anyway * add a little more documentation to tr_stat and tr_ctor in transmission.h
2008-05-23 20:04:41 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
switch (activity)
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case TR_STATUS_CHECK_WAIT:
return _("Queued for verification");
case TR_STATUS_CHECK:
return _("Verifying local data");
case TR_STATUS_DOWNLOAD_WAIT:
return _("Queued for download");
case TR_STATUS_DOWNLOAD:
return C_("Verb", "Downloading");
case TR_STATUS_SEED_WAIT:
return _("Queued for seeding");
case TR_STATUS_SEED:
return C_("Verb", "Seeding");
case TR_STATUS_STOPPED:
return finished ? _("Finished") : _("Paused");
* change tr_stat.activityDate's and tr_stat.startedDate's type to time_t, since that's how everyone uses them anyway * add a little more documentation to tr_stat and tr_ctor in transmission.h
2008-05-23 20:04:41 +00:00
}
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return "";
* change tr_stat.activityDate's and tr_stat.startedDate's type to time_t, since that's how everyone uses them anyway * add a little more documentation to tr_stat and tr_ctor in transmission.h
2008-05-23 20:04:41 +00:00
}
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
/* Only call gtk_text_buffer_set_text () if the new text differs from the old.
(trunk gtk) #2932 "The 'comment' field in the Torrent Properties dialog loses selection" -- fixed in trunk for 1.91
2010-02-19 14:49:03 +00:00
* This way if the user has text selected, refreshing won't deselect it */
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void gtr_text_buffer_set_text(GtkTextBuffer* b, char const* str)
(trunk gtk) #2932 "The 'comment' field in the Torrent Properties dialog loses selection" -- fixed in trunk for 1.91
2010-02-19 14:49:03 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char* old_str;
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
GtkTextIter start;
GtkTextIter end;
(trunk gtk) #2932 "The 'comment' field in the Torrent Properties dialog loses selection" -- fixed in trunk for 1.91
2010-02-19 14:49:03 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (str == NULL)
{
str = "";
}
(trunk gtk) #2932 "The 'comment' field in the Torrent Properties dialog loses selection" -- fixed in trunk for 1.91
2010-02-19 14:49:03 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_text_buffer_get_bounds(b, &start, &end);
old_str = gtk_text_buffer_get_text(b, &start, &end, FALSE);
(trunk gtk) #2932 "The 'comment' field in the Torrent Properties dialog loses selection" -- fixed in trunk for 1.91
2010-02-19 14:49:03 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (old_str == NULL || g_strcmp0(old_str, str) != 0)
{
gtk_text_buffer_set_text(b, str, -1);
}
(trunk gtk) #2932 "The 'comment' field in the Torrent Properties dialog loses selection" -- fixed in trunk for 1.91
2010-02-19 14:49:03 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_free(old_str);
(trunk gtk) #2932 "The 'comment' field in the Torrent Properties dialog loses selection" -- fixed in trunk for 1.91
2010-02-19 14:49:03 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static char* get_short_date_string(time_t t)
(trunk gtk) remove function gtr_localtime2()
2010-05-28 19:43:37 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char buf[64];
struct tm tm;
(trunk) #3698 "creation date of magnet links are set before the epoch." -- fixed.
2010-11-08 19:16:03 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (t == 0)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
return g_strdup(_("N/A"));
}
(trunk) #3698 "creation date of magnet links are set before the epoch." -- fixed.
2010-11-08 19:16:03 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_localtime_r(&t, &tm);
strftime(buf, sizeof(buf), "%d %b %Y", &tm);
return g_locale_to_utf8(buf, -1, NULL, NULL, NULL);
refactor: use GTest for running tests (#1383) * refactor: use google-test on libtransmission tests
2020-08-11 18:11:55 +00:00
}
(trunk gtk) remove function gtr_localtime2()
2010-05-28 19:43:37 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void refreshInfo(struct DetailsImpl* di, tr_torrent** torrents, int n)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
char const* str;
char const* mixed = _("Mixed");
char const* no_torrent = _("No Torrents Selected");
char const* stateString;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char buf[512];
uint64_t sizeWhenDone = 0;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_stat const** stats = g_new(tr_stat const*, n);
tr_info const** infos = g_new(tr_info const*, n);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
stats[i] = tr_torrentStatCached(torrents[i]);
infos[i] = tr_torrentInfo(torrents[i]);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* privacy_lb */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
bool const baseline = infos[0]->isPrivate;
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == infos[i]->isPrivate;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (is_uniform)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
str = baseline ? _("Private to this tracker -- DHT and PEX disabled") : _("Public torrent");
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
else
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
str = mixed;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_label_set_text(GTK_LABEL(di->privacy_lb), str);
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* origin_lb */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
char const* creator = infos[0]->creator != NULL ? infos[0]->creator : "";
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
time_t const date = infos[0]->dateCreated;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char* datestr = get_short_date_string(date);
gboolean mixed_creator = FALSE;
gboolean mixed_date = FALSE;
(trunk gtk) remove function gtr_localtime2()
2010-05-28 19:43:37 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; i < n; ++i)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
mixed_creator |= g_strcmp0(creator, infos[i]->creator != NULL ? infos[i]->creator : "") != 0;
mixed_date |= date != infos[i]->dateCreated;
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Introduce `tr_str_is_empty` to relay intent better
2019-07-13 08:52:44 +00:00
gboolean const empty_creator = tr_str_is_empty(creator);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
gboolean const empty_date = date == 0;
Even better (and unified) torrent origin logic for GTK+, Qt and web clients
2015-04-22 21:04:49 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (mixed_date || mixed_creator)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = mixed;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else if (empty_date && empty_creator)
Even better (and unified) torrent origin logic for GTK+, Qt and web clients
2015-04-22 21:04:49 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = _("N/A");
Even better (and unified) torrent origin logic for GTK+, Qt and web clients
2015-04-22 21:04:49 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (empty_date && !empty_creator)
{
g_snprintf(buf, sizeof(buf), _("Created by %1$s"), creator);
}
else if (empty_creator && !empty_date)
{
g_snprintf(buf, sizeof(buf), _("Created on %1$s"), datestr);
}
else
{
g_snprintf(buf, sizeof(buf), _("Created by %1$s on %2$s"), creator, datestr);
}
str = buf;
(trunk gtk) fix for "origin" field in the properties dialog when multiple torrents are selected. (kklimonda)
2009-08-04 03:10:35 +00:00
}
(trunk gtk) remove function gtr_localtime2()
2010-05-28 19:43:37 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_free(datestr);
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_label_set_text(GTK_LABEL(di->origin_lb), str);
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* comment_buffer */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = "";
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Fix a number of other style inconsistencies met along the way (part 2)
2017-05-01 15:47:49 +00:00
char const* baseline = infos[0]->comment != NULL ? infos[0]->comment : "";
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = g_strcmp0(baseline, infos[i]->comment != NULL ? infos[i]->comment : "") == 0;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
str = is_uniform ? baseline : mixed;
(trunk gtk,qt) #2490: gtk, qt clients' Details dialog doesn't show ETA anymore
2009-10-10 20:42:23 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_text_buffer_set_text(di->comment_buffer, str);
/* destination_lb */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
char const* baseline = tr_torrentGetDownloadDir(torrents[0]);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(trunk gtk,qt) #2490: gtk, qt clients' Details dialog doesn't show ETA anymore
2009-10-10 20:42:23 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = g_strcmp0(baseline, tr_torrentGetDownloadDir(torrents[i])) == 0;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(trunk gtk,qt) #2490: gtk, qt clients' Details dialog doesn't show ETA anymore
2009-10-10 20:42:23 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
str = is_uniform ? baseline : mixed;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_label_set_text(GTK_LABEL(di->destination_lb), str);
/* state_lb */
if (n <= 0)
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_torrent_activity const activity = stats[0]->activity;
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
bool allFinished = stats[0]->finished;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
(trunk) #3549 "torrent properties window does not fit netbook screen" -- fixed
2010-09-17 05:43:06 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = activity == stats[i]->activity;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (!stats[i]->finished)
{
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
allFinished = false;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
str = is_uniform ? activityString(activity, allFinished) : mixed;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
stateString = str;
gtr_label_set_text(GTK_LABEL(di->state_lb), str);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* date started */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
time_t const baseline = stats[0]->startDate;
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == stats[i]->startDate;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (!is_uniform)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
str = mixed;
}
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
else if (baseline <= 0 || stats[0]->activity == TR_STATUS_STOPPED)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
str = stateString;
}
else
{
str = tr_strltime(buf, time(NULL) - baseline, sizeof(buf));
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_label_set_text(GTK_LABEL(di->date_started_lb), str);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* eta */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const baseline = stats[0]->eta;
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = baseline == stats[i]->eta;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
if (!is_uniform)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
str = mixed;
}
else if (baseline < 0)
{
str = _("Unknown");
}
else
{
str = tr_strltime(buf, baseline, sizeof(buf));
}
}
gtr_label_set_text(GTK_LABEL(di->eta_lb), str);
/* size_lb */
{
char sizebuf[128];
uint64_t size = 0;
int pieces = 0;
int32_t pieceSize = 0;
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
size += infos[i]->totalSize;
pieces += infos[i]->pieceCount;
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (pieceSize == 0)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
pieceSize = infos[i]->pieceSize;
}
else if (pieceSize != (int)infos[i]->pieceSize)
{
pieceSize = -1;
}
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_strlsize(sizebuf, size, sizeof(sizebuf));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (size == 0)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
str = "";
}
else if (pieceSize >= 0)
{
char piecebuf[128];
tr_formatter_mem_B(piecebuf, pieceSize, sizeof(piecebuf));
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
g_snprintf(buf, sizeof(buf), ngettext("%1$s (%2$'d piece @ %3$s)", "%1$s (%2$'d pieces @ %3$s)", pieces), sizebuf,
pieces, piecebuf);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = buf;
}
else
{
g_snprintf(buf, sizeof(buf), ngettext("%1$s (%2$'d piece)", "%1$s (%2$'d pieces)", pieces), sizebuf, pieces);
str = buf;
}
gtr_label_set_text(GTK_LABEL(di->size_lb), str);
}
/* have_lb */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
uint64_t leftUntilDone = 0;
uint64_t haveUnchecked = 0;
uint64_t haveValid = 0;
uint64_t available = 0;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_stat const* st = stats[i];
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
haveUnchecked += st->haveUnchecked;
haveValid += st->haveValid;
sizeWhenDone += st->sizeWhenDone;
leftUntilDone += st->leftUntilDone;
fix availability not showing 100% in gtk details view (#1181) #1180 Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-26 05:07:40 +00:00
available += st->sizeWhenDone - st->leftUntilDone + st->haveUnchecked + st->desiredAvailable;
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
char buf2[32];
char unver[64];
char total[64];
char avail[32];
Fix a number of other style inconsistencies met along the way (part 2)
2017-05-01 15:47:49 +00:00
double const d = sizeWhenDone != 0 ? (100.0 * available) / sizeWhenDone : 0;
double const ratio = 100.0 * (sizeWhenDone != 0 ? (haveValid + haveUnchecked) / (double)sizeWhenDone : 1);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_strlpercent(avail, d, sizeof(avail));
tr_strlpercent(buf2, ratio, sizeof(buf2));
tr_strlsize(total, haveUnchecked + haveValid, sizeof(total));
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
tr_strlsize(unver, haveUnchecked, sizeof(unver));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (haveUnchecked == 0 && leftUntilDone == 0)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
g_snprintf(buf, sizeof(buf), _("%1$s (%2$s%%)"), total, buf2);
}
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
else if (haveUnchecked == 0)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
g_snprintf(buf, sizeof(buf), _("%1$s (%2$s%% of %3$s%% Available)"), total, buf2, avail);
}
else
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_snprintf(buf, sizeof(buf), _("%1$s (%2$s%% of %3$s%% Available); %4$s Unverified"), total, buf2, avail,
unver);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = buf;
}
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_label_set_text(GTK_LABEL(di->have_lb), str);
/* dl_lb */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
char dbuf[64];
char fbuf[64];
uint64_t d = 0;
uint64_t f = 0;
(trunk) remove trailing spaces
2009-08-10 20:04:08 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
d += stats[i]->downloadedEver;
f += stats[i]->corruptEver;
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_strlsize(dbuf, d, sizeof(dbuf));
tr_strlsize(fbuf, f, sizeof(fbuf));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (f != 0)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
g_snprintf(buf, sizeof(buf), _("%1$s (+%2$s corrupt)"), dbuf, fbuf);
}
else
{
tr_strlcpy(buf, dbuf, sizeof(buf));
}
str = buf;
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_label_set_text(GTK_LABEL(di->dl_lb), str);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* ul_lb */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char upstr[64];
char ratiostr[64];
uint64_t up = 0;
uint64_t down = 0;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
up += stats[i]->uploadedEver;
down += stats[i]->downloadedEver;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_strlsize(upstr, up, sizeof(upstr));
tr_strlratio(ratiostr, tr_getRatio(up, down), sizeof(ratiostr));
g_snprintf(buf, sizeof(buf), _("%s (Ratio: %s)"), upstr, ratiostr);
str = buf;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_label_set_text(GTK_LABEL(di->ul_lb), str);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* hash_lb */
if (n <= 0)
{
str = no_torrent;
}
else if (n == 1)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = infos[0]->hashString;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = mixed;
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_label_set_text(GTK_LABEL(di->hash_lb), str);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* error */
if (n <= 0)
{
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
char const* baseline = stats[0]->errorString;
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
bool is_uniform = true;
(trunk libT, gtk) #2625 "ability to create a magnet link" -- add hook for generating a magnet link from a tr_torrent, and use it in the Torrent Properties dialog in the GTK+ client
2009-11-29 08:27:55 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 1; is_uniform && i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
is_uniform = g_strcmp0(baseline, stats[i]->errorString) == 0;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
str = is_uniform ? baseline : mixed;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
Introduce `tr_str_is_empty` to relay intent better
2019-07-13 08:52:44 +00:00
if (tr_str_is_empty(str))
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
str = _("No errors");
}
gtr_label_set_text(GTK_LABEL(di->error_lb), str);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* activity date */
if (n <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = no_torrent;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
time_t latest = 0;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
if (latest < stats[i]->activityDate)
{
latest = stats[i]->activityDate;
}
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (latest <= 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = _("Never");
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const period = time(NULL) - latest;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (period < 5)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_strlcpy(buf, _("Active now"), sizeof(buf));
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char tbuf[128];
tr_strltime(tbuf, period, sizeof(tbuf));
g_snprintf(buf, sizeof(buf), _("%1$s ago"), tbuf);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
str = buf;
(trunk qt, gtk) some string changes: minor Gnome HiGification. omit unnecessary words. use less jargon.
2009-06-23 00:24:37 +00:00
}
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_label_set_text(GTK_LABEL(di->last_activity_lb), str);
g_free(stats);
g_free(infos);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static GtkWidget* info_page_new(struct DetailsImpl* di)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
guint row = 0;
GtkTextBuffer* b;
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
GtkWidget* l;
GtkWidget* w;
GtkWidget* fr;
GtkWidget* sw;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* t = hig_workarea_create();
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
hig_workarea_add_section_title(t, &row, _("Activity"));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
/* size */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = di->size_lb = gtk_label_new(NULL);
gtk_label_set_single_line_mode(GTK_LABEL(l), TRUE);
hig_workarea_add_row(t, &row, _("Torrent size:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
/* have */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = di->have_lb = gtk_label_new(NULL);
gtk_label_set_single_line_mode(GTK_LABEL(l), TRUE);
hig_workarea_add_row(t, &row, _("Have:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
/* uploaded */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = di->ul_lb = gtk_label_new(NULL);
gtk_label_set_single_line_mode(GTK_LABEL(l), TRUE);
hig_workarea_add_row(t, &row, _("Uploaded:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
(trunk, gtk/qt/web) #5581: 'Inconsistent ordering of Upload and Download speed limits' -- fixed.
2014-01-20 23:56:06 +00:00
/* downloaded */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = di->dl_lb = gtk_label_new(NULL);
gtk_label_set_single_line_mode(GTK_LABEL(l), TRUE);
hig_workarea_add_row(t, &row, _("Downloaded:"), l, NULL);
(trunk, gtk/qt/web) #5581: 'Inconsistent ordering of Upload and Download speed limits' -- fixed.
2014-01-20 23:56:06 +00:00
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
/* state */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = di->state_lb = gtk_label_new(NULL);
gtk_label_set_single_line_mode(GTK_LABEL(l), TRUE);
hig_workarea_add_row(t, &row, _("State:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
/* running for */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = di->date_started_lb = gtk_label_new(NULL);
gtk_label_set_single_line_mode(GTK_LABEL(l), TRUE);
hig_workarea_add_row(t, &row, _("Running time:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
/* eta */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = di->eta_lb = gtk_label_new(NULL);
gtk_label_set_single_line_mode(GTK_LABEL(l), TRUE);
hig_workarea_add_row(t, &row, _("Remaining time:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
/* last activity */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = di->last_activity_lb = gtk_label_new(NULL);
gtk_label_set_single_line_mode(GTK_LABEL(l), TRUE);
hig_workarea_add_row(t, &row, _("Last activity:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
/* error */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = g_object_new(GTK_TYPE_LABEL, "selectable", TRUE, "ellipsize", PANGO_ELLIPSIZE_END, NULL);
hig_workarea_add_row(t, &row, _("Error:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
di->error_lb = l;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
hig_workarea_add_section_divider(t, &row);
hig_workarea_add_section_title(t, &row, _("Details"));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
/* destination */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = g_object_new(GTK_TYPE_LABEL, "selectable", TRUE, "ellipsize", PANGO_ELLIPSIZE_END, NULL);
hig_workarea_add_row(t, &row, _("Location:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
di->destination_lb = l;
/* hash */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = g_object_new(GTK_TYPE_LABEL, "selectable", TRUE, "ellipsize", PANGO_ELLIPSIZE_END, NULL);
hig_workarea_add_row(t, &row, _("Hash:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
di->hash_lb = l;
/* privacy */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = gtk_label_new(NULL);
gtk_label_set_single_line_mode(GTK_LABEL(l), TRUE);
hig_workarea_add_row(t, &row, _("Privacy:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
di->privacy_lb = l;
/* origins */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
l = g_object_new(GTK_TYPE_LABEL, "selectable", TRUE, "ellipsize", PANGO_ELLIPSIZE_END, NULL);
hig_workarea_add_row(t, &row, _("Origin:"), l, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
di->origin_lb = l;
/* comment */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
b = di->comment_buffer = gtk_text_buffer_new(NULL);
w = gtk_text_view_new_with_buffer(b);
gtk_text_view_set_wrap_mode(GTK_TEXT_VIEW(w), GTK_WRAP_WORD);
gtk_text_view_set_editable(GTK_TEXT_VIEW(w), FALSE);
sw = gtk_scrolled_window_new(NULL, NULL);
gtk_widget_set_size_request(sw, 350, 36);
gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(sw), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
gtk_container_add(GTK_CONTAINER(sw), w);
fr = gtk_frame_new(NULL);
gtk_frame_set_shadow_type(GTK_FRAME(fr), GTK_SHADOW_IN);
gtk_container_add(GTK_CONTAINER(fr), sw);
w = hig_workarea_add_tall_row(t, &row, _("Comment:"), fr, NULL);
Fix some gtk warnings (#1038) * fix gtk deprecation warning: gtk_misc_set_alignment * fix gtk deprecation warning: gtk_alignment_new * fix gtk deprecation warning: gtk_tree_view_set_rules_hint * fix gtk deprecation warning: gtk_image_new_from_stock * fixup! fix gtk deprecation warning: gtk_alignment_new * fix gtk deprecation warning: gtk_dialog_set_alternative_button_order * fix gtk deprecation warning: gtk_show_uri * fix gtk deprecation warning: gtk_widget_set_margin_left * fix gtk deprecation warning: gtk_button_set_alignment * fix gtk deprecation warning: g_type_class_add_private * fix gtk deprecation warning: gtk_menu_popup * fix gtk deprecation warning: gtk_misc_set_padding * chore: uncrustify * fix: silence G_TYPE_INSTANCE_GET_PRIVATE warning Deprecaed starting in glib 2.58 * chore: uncrustify
2019-11-06 19:09:27 +00:00
g_object_set(w, "halign", GTK_ALIGN_START, "valign", GTK_ALIGN_START, NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
hig_workarea_add_section_divider(t, &row);
return t;
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
/****
*****
***** PEERS TAB
*****
****/
(trunk) #1787: add support for seeding ratio limiting in libtransmission
2009-02-13 18:23:56 +00:00
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
enum
(trunk) #1787: add support for seeding ratio limiting in libtransmission
2009-02-13 18:23:56 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
WEBSEED_COL_KEY,
WEBSEED_COL_WAS_UPDATED,
WEBSEED_COL_URL,
WEBSEED_COL_DOWNLOAD_RATE_DOUBLE,
WEBSEED_COL_DOWNLOAD_RATE_STRING,
N_WEBSEED_COLS
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
};
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static char const* getWebseedColumnNames(int column)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
switch (column)
(trunk) #1787: add support for seeding ratio limiting in libtransmission
2009-02-13 18:23:56 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case WEBSEED_COL_URL:
return _("Web Seeds");
case WEBSEED_COL_DOWNLOAD_RATE_DOUBLE:
case WEBSEED_COL_DOWNLOAD_RATE_STRING:
return _("Down");
default:
return "";
(trunk) #1787: add support for seeding ratio limiting in libtransmission
2009-02-13 18:23:56 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static GtkListStore* webseed_model_new(void)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return gtk_list_store_new(N_WEBSEED_COLS,
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
G_TYPE_STRING, /* key */
G_TYPE_BOOLEAN, /* was-updated */
G_TYPE_STRING, /* url */
G_TYPE_DOUBLE, /* download rate double */
G_TYPE_STRING); /* download rate string */
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
enum
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
PEER_COL_KEY,
PEER_COL_WAS_UPDATED,
PEER_COL_ADDRESS,
PEER_COL_ADDRESS_COLLATED,
PEER_COL_DOWNLOAD_RATE_DOUBLE,
PEER_COL_DOWNLOAD_RATE_STRING,
PEER_COL_UPLOAD_RATE_DOUBLE,
PEER_COL_UPLOAD_RATE_STRING,
PEER_COL_CLIENT,
PEER_COL_PROGRESS,
PEER_COL_UPLOAD_REQUEST_COUNT_INT,
PEER_COL_UPLOAD_REQUEST_COUNT_STRING,
PEER_COL_DOWNLOAD_REQUEST_COUNT_INT,
PEER_COL_DOWNLOAD_REQUEST_COUNT_STRING,
PEER_COL_BLOCKS_DOWNLOADED_COUNT_INT,
PEER_COL_BLOCKS_DOWNLOADED_COUNT_STRING,
PEER_COL_BLOCKS_UPLOADED_COUNT_INT,
PEER_COL_BLOCKS_UPLOADED_COUNT_STRING,
PEER_COL_REQS_CANCELLED_BY_CLIENT_COUNT_INT,
PEER_COL_REQS_CANCELLED_BY_CLIENT_COUNT_STRING,
PEER_COL_REQS_CANCELLED_BY_PEER_COUNT_INT,
PEER_COL_REQS_CANCELLED_BY_PEER_COUNT_STRING,
PEER_COL_ENCRYPTION_STOCK_ID,
PEER_COL_FLAGS,
PEER_COL_TORRENT_NAME,
N_PEER_COLS
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
};
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static char const* getPeerColumnName(int column)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
switch (column)
{
case PEER_COL_ADDRESS:
return _("Address");
case PEER_COL_DOWNLOAD_RATE_STRING:
case PEER_COL_DOWNLOAD_RATE_DOUBLE:
return _("Down");
case PEER_COL_UPLOAD_RATE_STRING:
case PEER_COL_UPLOAD_RATE_DOUBLE:
return _("Up");
case PEER_COL_CLIENT:
return _("Client");
case PEER_COL_PROGRESS:
return _("%");
case PEER_COL_UPLOAD_REQUEST_COUNT_INT:
case PEER_COL_UPLOAD_REQUEST_COUNT_STRING:
return _("Up Reqs");
case PEER_COL_DOWNLOAD_REQUEST_COUNT_INT:
case PEER_COL_DOWNLOAD_REQUEST_COUNT_STRING:
return _("Dn Reqs");
case PEER_COL_BLOCKS_DOWNLOADED_COUNT_INT:
case PEER_COL_BLOCKS_DOWNLOADED_COUNT_STRING:
return _("Dn Blocks");
case PEER_COL_BLOCKS_UPLOADED_COUNT_INT:
case PEER_COL_BLOCKS_UPLOADED_COUNT_STRING:
return _("Up Blocks");
case PEER_COL_REQS_CANCELLED_BY_CLIENT_COUNT_INT:
case PEER_COL_REQS_CANCELLED_BY_CLIENT_COUNT_STRING:
return _("We Cancelled");
case PEER_COL_REQS_CANCELLED_BY_PEER_COUNT_INT:
case PEER_COL_REQS_CANCELLED_BY_PEER_COUNT_STRING:
return _("They Cancelled");
case PEER_COL_FLAGS:
return _("Flags");
default:
return "";
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static GtkListStore* peer_store_new(void)
{
return gtk_list_store_new(N_PEER_COLS,
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
G_TYPE_STRING, /* key */
G_TYPE_BOOLEAN, /* was-updated */
G_TYPE_STRING, /* address */
G_TYPE_STRING, /* collated address */
G_TYPE_DOUBLE, /* download speed int */
G_TYPE_STRING, /* download speed string */
G_TYPE_DOUBLE, /* upload speed int */
G_TYPE_STRING, /* upload speed string */
G_TYPE_STRING, /* client */
G_TYPE_INT, /* progress [0..100] */
G_TYPE_INT, /* upload request count int */
G_TYPE_STRING, /* upload request count string */
G_TYPE_INT, /* download request count int */
G_TYPE_STRING, /* download request count string */
G_TYPE_INT, /* # blocks downloaded int */
G_TYPE_STRING, /* # blocks downloaded string */
G_TYPE_INT, /* # blocks uploaded int */
G_TYPE_STRING, /* # blocks uploaded string */
G_TYPE_INT, /* # blocks cancelled by client int */
G_TYPE_STRING, /* # blocks cancelled by client string */
G_TYPE_INT, /* # blocks cancelled by peer int */
G_TYPE_STRING, /* # blocks cancelled by peer string */
G_TYPE_STRING, /* encryption stock id */
G_TYPE_STRING, /* flagString */
G_TYPE_STRING); /* torrent name */
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void initPeerRow(GtkListStore* store, GtkTreeIter* iter, char const* key, char const* torrentName,
tr_peer_stat const* peer)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
fix: silence some sonarcloud warnings (#1493) * refactor: add null ptr check in initPeerRow() * refactor: add a nullptr gurad in icon_cache_get_mime_type_icon * chore: silence two "break notreached" warnings * chore: silence sonarcloud html warnings * chore: silence sonarcloud uninitialized var warning * chore: silence sonarcloud nullptr warning
2020-10-31 21:23:43 +00:00
g_return_if_fail(peer != NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
fix: silence some sonarcloud warnings (#1493) * refactor: add null ptr check in initPeerRow() * refactor: add a nullptr gurad in icon_cache_get_mime_type_icon * chore: silence two "break notreached" warnings * chore: silence sonarcloud html warnings * chore: silence sonarcloud uninitialized var warning * chore: silence sonarcloud nullptr warning
2020-10-31 21:23:43 +00:00
char const* client = peer->client;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (client == NULL || g_strcmp0(client, "Unknown Client") == 0)
{
client = "";
}
fix: silence some sonarcloud warnings (#1493) * refactor: add null ptr check in initPeerRow() * refactor: add a nullptr gurad in icon_cache_get_mime_type_icon * chore: silence two "break notreached" warnings * chore: silence sonarcloud html warnings * chore: silence sonarcloud uninitialized var warning * chore: silence sonarcloud nullptr warning
2020-10-31 21:23:43 +00:00
int q[4];
char collated_name[128];
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (sscanf(peer->addr, "%d.%d.%d.%d", q, q + 1, q + 2, q + 3) != 4)
{
g_strlcpy(collated_name, peer->addr, sizeof(collated_name));
}
else
{
g_snprintf(collated_name, sizeof(collated_name), "%03d.%03d.%03d.%03d", q[0], q[1], q[2], q[3]);
}
gtk_list_store_set(store, iter,
PEER_COL_ADDRESS, peer->addr,
PEER_COL_ADDRESS_COLLATED, collated_name,
PEER_COL_CLIENT, client,
PEER_COL_ENCRYPTION_STOCK_ID, peer->isEncrypted ? "transmission-lock" : NULL,
PEER_COL_KEY, key,
PEER_COL_TORRENT_NAME, torrentName,
-1);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void refreshPeerRow(GtkListStore* store, GtkTreeIter* iter, tr_peer_stat const* peer)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
char up_speed[64] = { '\0' };
char down_speed[64] = { '\0' };
char up_count[64] = { '\0' };
char down_count[64] = { '\0' };
char blocks_to_peer[64] = { '\0' };
char blocks_to_client[64] = { '\0' };
char cancelled_by_peer[64] = { '\0' };
char cancelled_by_client[64] = { '\0' };
chore: sonarcloud warnings 2 (#1496) * fix "merge nested if" sonarcloud warnings * fix explicit constructor warnings in qt client
2020-11-01 21:47:57 +00:00
g_return_if_fail(peer != NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (peer->rateToPeer_KBps > 0.01)
{
tr_formatter_speed_KBps(up_speed, peer->rateToPeer_KBps, sizeof(up_speed));
}
if (peer->rateToClient_KBps > 0)
{
tr_formatter_speed_KBps(down_speed, peer->rateToClient_KBps, sizeof(down_speed));
}
if (peer->pendingReqsToPeer > 0)
{
g_snprintf(down_count, sizeof(down_count), "%d", peer->pendingReqsToPeer);
}
if (peer->pendingReqsToClient > 0)
{
g_snprintf(up_count, sizeof(down_count), "%d", peer->pendingReqsToClient);
}
if (peer->blocksToPeer > 0)
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_snprintf(blocks_to_peer, sizeof(blocks_to_peer), "%" PRIu32, peer->blocksToPeer);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
if (peer->blocksToClient > 0)
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_snprintf(blocks_to_client, sizeof(blocks_to_client), "%" PRIu32, peer->blocksToClient);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
if (peer->cancelsToPeer > 0)
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_snprintf(cancelled_by_client, sizeof(cancelled_by_client), "%" PRIu32, peer->cancelsToPeer);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
if (peer->cancelsToClient > 0)
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_snprintf(cancelled_by_peer, sizeof(cancelled_by_peer), "%" PRIu32, peer->cancelsToClient);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
gtk_list_store_set(store, iter,
PEER_COL_PROGRESS, (int)(100.0 * peer->progress),
PEER_COL_UPLOAD_REQUEST_COUNT_INT, peer->pendingReqsToClient,
PEER_COL_UPLOAD_REQUEST_COUNT_STRING, up_count,
PEER_COL_DOWNLOAD_REQUEST_COUNT_INT, peer->pendingReqsToPeer,
PEER_COL_DOWNLOAD_REQUEST_COUNT_STRING, down_count,
PEER_COL_DOWNLOAD_RATE_DOUBLE, peer->rateToClient_KBps,
PEER_COL_DOWNLOAD_RATE_STRING, down_speed,
PEER_COL_UPLOAD_RATE_DOUBLE, peer->rateToPeer_KBps,
PEER_COL_UPLOAD_RATE_STRING, up_speed,
PEER_COL_FLAGS, peer->flagStr,
PEER_COL_WAS_UPDATED, TRUE,
PEER_COL_BLOCKS_DOWNLOADED_COUNT_INT, (int)peer->blocksToClient,
PEER_COL_BLOCKS_DOWNLOADED_COUNT_STRING, blocks_to_client,
PEER_COL_BLOCKS_UPLOADED_COUNT_INT, (int)peer->blocksToPeer,
PEER_COL_BLOCKS_UPLOADED_COUNT_STRING, blocks_to_peer,
PEER_COL_REQS_CANCELLED_BY_CLIENT_COUNT_INT, (int)peer->cancelsToPeer,
PEER_COL_REQS_CANCELLED_BY_CLIENT_COUNT_STRING, cancelled_by_client,
PEER_COL_REQS_CANCELLED_BY_PEER_COUNT_INT, (int)peer->cancelsToClient,
PEER_COL_REQS_CANCELLED_BY_PEER_COUNT_STRING, cancelled_by_peer,
-1);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void refreshPeerList(struct DetailsImpl* di, tr_torrent** torrents, int n)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int* peerCount;
GtkTreeIter iter;
GtkTreeModel* model;
GHashTable* hash = di->peer_hash;
GtkListStore* store = di->peer_store;
struct tr_peer_stat** peers;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 1: get all the peers */
peers = g_new(struct tr_peer_stat*, n);
peerCount = g_new(int, n);
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
peers[i] = tr_torrentPeers(torrents[i], &peerCount[i]);
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 2: mark all the peers in the list as not-updated */
model = GTK_TREE_MODEL(store);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (gtk_tree_model_iter_nth_child(model, &iter, NULL, 0))
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
do
{
gtk_list_store_set(store, &iter, PEER_COL_WAS_UPDATED, FALSE, -1);
}
while (gtk_tree_model_iter_next(model, &iter));
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 3: add any new peers */
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_torrent const* tor = torrents[i];
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int j = 0; j < peerCount[i]; ++j)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char key[128];
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_peer_stat const* s = &peers[i][j];
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_snprintf(key, sizeof(key), "%d.%s", tr_torrentId(tor), s->addr);
if (g_hash_table_lookup(hash, key) == NULL)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkTreePath* p;
gtk_list_store_append(store, &iter);
initPeerRow(store, &iter, key, tr_torrentName(tor), s);
p = gtk_tree_model_get_path(model, &iter);
g_hash_table_insert(hash, g_strdup(key), gtk_tree_row_reference_new(model, p));
gtk_tree_path_free(p);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 4: update the peers */
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_torrent const* tor = torrents[i];
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int j = 0; j < peerCount[i]; ++j)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char key[128];
GtkTreePath* p;
GtkTreeRowReference* ref;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_peer_stat const* s = &peers[i][j];
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_snprintf(key, sizeof(key), "%d.%s", tr_torrentId(tor), s->addr);
ref = g_hash_table_lookup(hash, key);
p = gtk_tree_row_reference_get_path(ref);
gtk_tree_model_get_iter(model, &iter, p);
refreshPeerRow(store, &iter, s);
gtk_tree_path_free(p);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 5: remove peers that have disappeared */
model = GTK_TREE_MODEL(store);
if (gtk_tree_model_iter_nth_child(model, &iter, NULL, 0))
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gboolean more = TRUE;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
while (more)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gboolean b;
gtk_tree_model_get(model, &iter, PEER_COL_WAS_UPDATED, &b, -1);
if (b)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
more = gtk_tree_model_iter_next(model, &iter);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char* key;
gtk_tree_model_get(model, &iter, PEER_COL_KEY, &key, -1);
g_hash_table_remove(hash, key);
more = gtk_list_store_remove(store, &iter);
g_free(key);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 6: cleanup */
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
tr_torrentPeersFree(peers[i], peerCount[i]);
}
tr_free(peers);
tr_free(peerCount);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void refreshWebseedList(struct DetailsImpl* di, tr_torrent** torrents, int n)
(trunk) #1787: add support for seeding ratio limiting in libtransmission
2009-02-13 18:23:56 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int total = 0;
GtkTreeIter iter;
GHashTable* hash = di->webseed_hash;
GtkListStore* store = di->webseed_store;
GtkTreeModel* model = GTK_TREE_MODEL(store);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 1: mark all webseeds as not-updated */
if (gtk_tree_model_iter_nth_child(model, &iter, NULL, 0))
{
do
{
gtk_list_store_set(store, &iter, WEBSEED_COL_WAS_UPDATED, FALSE, -1);
}
while (gtk_tree_model_iter_next(model, &iter));
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 2: add any new webseeds */
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_torrent const* tor = torrents[i];
tr_info const* inf = tr_torrentInfo(tor);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
total += inf->webseedCount;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (unsigned int j = 0; j < inf->webseedCount; ++j)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char key[256];
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
char const* url = inf->webseeds[j];
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_snprintf(key, sizeof(key), "%d.%s", tr_torrentId(tor), url);
if (g_hash_table_lookup(hash, key) == NULL)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkTreePath* p;
gtk_list_store_append(store, &iter);
gtk_list_store_set(store, &iter,
WEBSEED_COL_URL, url,
WEBSEED_COL_KEY, key,
-1);
p = gtk_tree_model_get_path(model, &iter);
g_hash_table_insert(hash, g_strdup(key), gtk_tree_row_reference_new(model, p));
gtk_tree_path_free(p);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 3: update the webseeds */
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_torrent* tor = torrents[i];
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_info const* inf = tr_torrentInfo(tor);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
double* speeds_KBps = tr_torrentWebSpeeds_KBps(tor);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (unsigned int j = 0; j < inf->webseedCount; ++j)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char buf[128];
char key[256];
GtkTreePath* p;
GtkTreeRowReference* ref;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
char const* url = inf->webseeds[j];
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_snprintf(key, sizeof(key), "%d.%s", tr_torrentId(tor), url);
ref = g_hash_table_lookup(hash, key);
p = gtk_tree_row_reference_get_path(ref);
gtk_tree_model_get_iter(model, &iter, p);
if (speeds_KBps[j] > 0)
{
tr_formatter_speed_KBps(buf, speeds_KBps[j], sizeof(buf));
}
else
{
*buf = '\0';
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_list_store_set(store, &iter,
WEBSEED_COL_DOWNLOAD_RATE_DOUBLE, speeds_KBps[j],
WEBSEED_COL_DOWNLOAD_RATE_STRING, buf,
WEBSEED_COL_WAS_UPDATED, TRUE,
-1);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_tree_path_free(p);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_free(speeds_KBps);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 4: remove webseeds that have disappeared */
if (gtk_tree_model_iter_nth_child(model, &iter, NULL, 0))
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gboolean more = TRUE;
while (more)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gboolean b;
gtk_tree_model_get(model, &iter, WEBSEED_COL_WAS_UPDATED, &b, -1);
if (b)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
more = gtk_tree_model_iter_next(model, &iter);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char* key;
gtk_tree_model_get(model, &iter, WEBSEED_COL_KEY, &key, -1);
if (key != NULL)
{
g_hash_table_remove(hash, key);
}
more = gtk_list_store_remove(store, &iter);
g_free(key);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* most of the time there are no webseeds...
don't waste space showing an empty list */
gtk_widget_set_visible(di->webseed_view, total > 0);
(trunk) #1787: add support for seeding ratio limiting in libtransmission
2009-02-13 18:23:56 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void refreshPeers(struct DetailsImpl* di, tr_torrent** torrents, int n)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
refreshPeerList(di, torrents, n);
refreshWebseedList(di, torrents, n);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static gboolean onPeerViewQueryTooltip(GtkWidget* widget, gint x, gint y, gboolean keyboard_tip, GtkTooltip* tooltip,
gpointer gdi)
{
GtkTreeIter iter;
GtkTreeModel* model;
gboolean show_tip = FALSE;
if (gtk_tree_view_get_tooltip_context(GTK_TREE_VIEW(widget), &x, &y, keyboard_tip, &model, NULL, &iter))
{
char* name = NULL;
char* addr = NULL;
char* markup = NULL;
char* flagstr = NULL;
struct DetailsImpl* di = gdi;
GString* gstr = di->gstr;
gtk_tree_model_get(model, &iter,
PEER_COL_TORRENT_NAME, &name,
PEER_COL_ADDRESS, &addr,
PEER_COL_FLAGS, &flagstr,
-1);
g_string_truncate(gstr, 0);
markup = g_markup_escape_text(name, -1);
g_string_append_printf(gstr, "<b>%s</b>\n%s\n \n", markup, addr);
g_free(markup);
Introduce `tr_str_is_empty` to relay intent better
2019-07-13 08:52:44 +00:00
for (char const* pch = flagstr; !tr_str_is_empty(pch); ++pch)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
char const* s = NULL;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
switch (*pch)
(gtk) clean up yesterday's properties dialog rewrite a bit.
2009-04-24 12:05:53 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case 'O':
s = _("Optimistic unchoke");
break;
case 'D':
s = _("Downloading from this peer");
break;
case 'd':
s = _("We would download from this peer if they would let us");
break;
case 'U':
s = _("Uploading to peer");
break;
case 'u':
s = _("We would upload to this peer if they asked");
break;
case 'K':
s = _("Peer has unchoked us, but we're not interested");
break;
case '?':
s = _("We unchoked this peer, but they're not interested");
break;
case 'E':
s = _("Encrypted connection");
break;
case 'X':
s = _("Peer was found through Peer Exchange (PEX)");
break;
case 'H':
s = _("Peer was found through DHT");
break;
case 'I':
s = _("Peer is an incoming connection");
break;
case 'T':
s = _("Peer is connected over µTP");
break;
(gtk) clean up yesterday's properties dialog rewrite a bit.
2009-04-24 12:05:53 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (s != NULL)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
g_string_append_printf(gstr, "%c: %s\n", *pch, s);
}
(gtk) clean up yesterday's properties dialog rewrite a bit.
2009-04-24 12:05:53 +00:00
}
(trunk gtk) #4254 "can't see description about Flags" -- fixed.
2011-05-28 00:12:59 +00:00
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (gstr->len != 0) /* remove the last linefeed */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
g_string_set_size(gstr, gstr->len - 1);
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_tooltip_set_markup(tooltip, gstr->str);
(trunk gtk) #4254 "can't see description about Flags" -- fixed.
2011-05-28 00:12:59 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_free(flagstr);
g_free(addr);
g_free(name);
show_tip = TRUE;
(gtk) clean up yesterday's properties dialog rewrite a bit.
2009-04-24 12:05:53 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return show_tip;
(gtk) clean up yesterday's properties dialog rewrite a bit.
2009-04-24 12:05:53 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void setPeerViewColumns(GtkTreeView* peer_view)
{
int n;
int view_columns[32];
GtkCellRenderer* r;
GtkTreeViewColumn* c;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
bool const more = gtr_pref_flag_get(TR_KEY_show_extra_peer_details);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
n = 0;
view_columns[n++] = PEER_COL_ENCRYPTION_STOCK_ID;
view_columns[n++] = PEER_COL_UPLOAD_RATE_STRING;
if (more)
{
view_columns[n++] = PEER_COL_UPLOAD_REQUEST_COUNT_STRING;
}
view_columns[n++] = PEER_COL_DOWNLOAD_RATE_STRING;
if (more)
{
view_columns[n++] = PEER_COL_DOWNLOAD_REQUEST_COUNT_STRING;
}
if (more)
{
view_columns[n++] = PEER_COL_BLOCKS_DOWNLOADED_COUNT_STRING;
}
if (more)
{
view_columns[n++] = PEER_COL_BLOCKS_UPLOADED_COUNT_STRING;
}
if (more)
{
view_columns[n++] = PEER_COL_REQS_CANCELLED_BY_CLIENT_COUNT_STRING;
}
if (more)
{
view_columns[n++] = PEER_COL_REQS_CANCELLED_BY_PEER_COUNT_STRING;
}
view_columns[n++] = PEER_COL_PROGRESS;
view_columns[n++] = PEER_COL_FLAGS;
view_columns[n++] = PEER_COL_ADDRESS;
view_columns[n++] = PEER_COL_CLIENT;
/* remove any existing columns */
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
while ((c = gtk_tree_view_get_column(peer_view, 0)) != NULL)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
gtk_tree_view_remove_column(peer_view, c);
}
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const col = view_columns[i];
char const* t = getPeerColumnName(col);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int sort_col = col;
switch (col)
{
case PEER_COL_ADDRESS:
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
sort_col = PEER_COL_ADDRESS_COLLATED;
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_CLIENT:
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_PROGRESS:
r = gtk_cell_renderer_progress_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "value", PEER_COL_PROGRESS, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_ENCRYPTION_STOCK_ID:
r = gtk_cell_renderer_pixbuf_new();
g_object_set(r, "xalign", (gfloat)0.0, "yalign", (gfloat)0.5, NULL);
c = gtk_tree_view_column_new_with_attributes(t, r, "stock-id", PEER_COL_ENCRYPTION_STOCK_ID, NULL);
gtk_tree_view_column_set_sizing(c, GTK_TREE_VIEW_COLUMN_FIXED);
gtk_tree_view_column_set_fixed_width(c, 20);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_DOWNLOAD_REQUEST_COUNT_STRING:
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
sort_col = PEER_COL_DOWNLOAD_REQUEST_COUNT_INT;
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_UPLOAD_REQUEST_COUNT_STRING:
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
sort_col = PEER_COL_UPLOAD_REQUEST_COUNT_INT;
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_BLOCKS_DOWNLOADED_COUNT_STRING:
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
sort_col = PEER_COL_BLOCKS_DOWNLOADED_COUNT_INT;
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_BLOCKS_UPLOADED_COUNT_STRING:
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
sort_col = PEER_COL_BLOCKS_UPLOADED_COUNT_INT;
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_REQS_CANCELLED_BY_CLIENT_COUNT_STRING:
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
sort_col = PEER_COL_REQS_CANCELLED_BY_CLIENT_COUNT_INT;
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_REQS_CANCELLED_BY_PEER_COUNT_STRING:
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
sort_col = PEER_COL_REQS_CANCELLED_BY_PEER_COUNT_INT;
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_DOWNLOAD_RATE_STRING:
r = gtk_cell_renderer_text_new();
Uppercase the literal suffixes * MISRA C++:2008, 2-13-4 - Literal suffixes shall be upper case * MISRA C:2012, 7.3 - The lowercase character "l" shall not be used in a literal suffix * CERT DCL16-C. - Use "L," not "l," to indicate a long value * CERT, DCL50-J. - Use visually distinct identifiers
2019-03-17 04:07:48 +00:00
g_object_set(G_OBJECT(r), "xalign", 1.0F, NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
sort_col = PEER_COL_DOWNLOAD_RATE_DOUBLE;
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_UPLOAD_RATE_STRING:
r = gtk_cell_renderer_text_new();
Uppercase the literal suffixes * MISRA C++:2008, 2-13-4 - Literal suffixes shall be upper case * MISRA C:2012, 7.3 - The lowercase character "l" shall not be used in a literal suffix * CERT DCL16-C. - Use "L," not "l," to indicate a long value * CERT, DCL50-J. - Use visually distinct identifiers
2019-03-17 04:07:48 +00:00
g_object_set(G_OBJECT(r), "xalign", 1.0F, NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
sort_col = PEER_COL_UPLOAD_RATE_DOUBLE;
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case PEER_COL_FLAGS:
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(t, r, "text", col, NULL);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
default:
abort();
(trunk) #2548 "T's request queue can send out too many duplicate requests" -- (1) fix r9465 implementation bug that caused some peers to get starved of requests if they rejected a request or choked, then unchoked us. (2) increase a block request's TTL by 15 seconds to reduce cancel/req cycles between two or more blocks (3) add a debug mode to the GTK+ client's peer tab to watch the pending requests counts both up & down
2009-12-16 18:20:01 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_tree_view_column_set_resizable(c, FALSE);
gtk_tree_view_column_set_sort_column_id(c, sort_col);
gtk_tree_view_append_column(GTK_TREE_VIEW(peer_view), c);
(trunk) #2548 "T's request queue can send out too many duplicate requests" -- (1) fix r9465 implementation bug that caused some peers to get starved of requests if they rejected a request or choked, then unchoked us. (2) increase a block request's TTL by 15 seconds to reduce cancel/req cycles between two or more blocks (3) add a debug mode to the GTK+ client's peer tab to watch the pending requests counts both up & down
2009-12-16 18:20:01 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* the 'expander' column has a 10-pixel margin on the left
that doesn't look quite correct in any of these columns...
so create a non-visible column and assign it as the
'expander column. */
{
refactor: use GTest for running tests (#1383) * refactor: use google-test on libtransmission tests
2020-08-11 18:11:55 +00:00
c = gtk_tree_view_column_new();
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_tree_view_column_set_visible(c, FALSE);
gtk_tree_view_append_column(GTK_TREE_VIEW(peer_view), c);
gtk_tree_view_set_expander_column(GTK_TREE_VIEW(peer_view), c);
}
(trunk) #2548 "T's request queue can send out too many duplicate requests" -- (1) fix r9465 implementation bug that caused some peers to get starved of requests if they rejected a request or choked, then unchoked us. (2) increase a block request's TTL by 15 seconds to reduce cancel/req cycles between two or more blocks (3) add a debug mode to the GTK+ client's peer tab to watch the pending requests counts both up & down
2009-12-16 18:20:01 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void onMorePeerInfoToggled(GtkToggleButton* button, struct DetailsImpl* di)
(trunk) #2548 "T's request queue can send out too many duplicate requests" -- (1) fix r9465 implementation bug that caused some peers to get starved of requests if they rejected a request or choked, then unchoked us. (2) increase a block request's TTL by 15 seconds to reduce cancel/req cycles between two or more blocks (3) add a debug mode to the GTK+ client's peer tab to watch the pending requests counts both up & down
2009-12-16 18:20:01 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_quark const key = TR_KEY_show_extra_peer_details;
gboolean const value = gtk_toggle_button_get_active(button);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_core_set_pref_bool(di->core, key, value);
setPeerViewColumns(GTK_TREE_VIEW(di->peer_view));
(trunk) #2548 "T's request queue can send out too many duplicate requests" -- (1) fix r9465 implementation bug that caused some peers to get starved of requests if they rejected a request or choked, then unchoked us. (2) increase a block request's TTL by 15 seconds to reduce cancel/req cycles between two or more blocks (3) add a debug mode to the GTK+ client's peer tab to watch the pending requests counts both up & down
2009-12-16 18:20:01 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static GtkWidget* peer_page_new(struct DetailsImpl* di)
{
gboolean b;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
char const* str;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkListStore* store;
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
GtkWidget* v;
GtkWidget* w;
GtkWidget* ret;
GtkWidget* sw;
GtkWidget* vbox;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* webtree = NULL;
GtkTreeModel* m;
GtkTreeViewColumn* c;
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
GtkCellRenderer* r;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* webseeds */
store = di->webseed_store = webseed_model_new();
v = gtk_tree_view_new_with_model(GTK_TREE_MODEL(store));
g_signal_connect(v, "button-release-event", G_CALLBACK(on_tree_view_button_released), NULL);
g_object_unref(store);
str = getWebseedColumnNames(WEBSEED_COL_URL);
r = gtk_cell_renderer_text_new();
g_object_set(G_OBJECT(r), "ellipsize", PANGO_ELLIPSIZE_END, NULL);
c = gtk_tree_view_column_new_with_attributes(str, r, "text", WEBSEED_COL_URL, NULL);
g_object_set(G_OBJECT(c), "expand", TRUE, NULL);
gtk_tree_view_column_set_sort_column_id(c, WEBSEED_COL_URL);
gtk_tree_view_append_column(GTK_TREE_VIEW(v), c);
str = getWebseedColumnNames(WEBSEED_COL_DOWNLOAD_RATE_STRING);
r = gtk_cell_renderer_text_new();
c = gtk_tree_view_column_new_with_attributes(str, r, "text", WEBSEED_COL_DOWNLOAD_RATE_STRING, NULL);
gtk_tree_view_column_set_sort_column_id(c, WEBSEED_COL_DOWNLOAD_RATE_DOUBLE);
gtk_tree_view_append_column(GTK_TREE_VIEW(v), c);
w = gtk_scrolled_window_new(NULL, NULL);
gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(w), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(w), GTK_SHADOW_IN);
gtk_container_add(GTK_CONTAINER(w), v);
webtree = w;
di->webseed_view = w;
/* peers */
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
store = di->peer_store = peer_store_new();
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
m = gtk_tree_model_sort_new_with_model(GTK_TREE_MODEL(store));
gtk_tree_sortable_set_sort_column_id(GTK_TREE_SORTABLE(m), PEER_COL_PROGRESS, GTK_SORT_DESCENDING);
v = GTK_WIDGET(g_object_new(GTK_TYPE_TREE_VIEW, "model", m, "rules-hint", TRUE, "has-tooltip", TRUE, NULL));
di->peer_view = v;
g_signal_connect(v, "query-tooltip", G_CALLBACK(onPeerViewQueryTooltip), di);
g_object_unref(store);
g_signal_connect(v, "button-release-event", G_CALLBACK(on_tree_view_button_released), NULL);
setPeerViewColumns(GTK_TREE_VIEW(v));
w = sw = gtk_scrolled_window_new(NULL, NULL);
gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(w), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(w), GTK_SHADOW_IN);
gtk_container_add(GTK_CONTAINER(w), v);
vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, GUI_PAD);
gtk_container_set_border_width(GTK_CONTAINER(vbox), GUI_PAD_BIG);
v = gtk_paned_new(GTK_ORIENTATION_VERTICAL);
gtk_paned_pack1(GTK_PANED(v), webtree, FALSE, TRUE);
gtk_paned_pack2(GTK_PANED(v), sw, TRUE, TRUE);
gtk_box_pack_start(GTK_BOX(vbox), v, TRUE, TRUE, 0);
w = gtk_check_button_new_with_mnemonic(_("Show _more details"));
di->more_peer_details_check = w;
b = gtr_pref_flag_get(TR_KEY_show_extra_peer_details);
gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(w), b);
g_signal_connect(w, "toggled", G_CALLBACK(onMorePeerInfoToggled), di);
gtk_box_pack_start(GTK_BOX(vbox), w, FALSE, FALSE, 0);
/* ip-to-GtkTreeRowReference */
di->peer_hash = g_hash_table_new_full(g_str_hash, g_str_equal, (GDestroyNotify)g_free,
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
(GDestroyNotify)gtk_tree_row_reference_free);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* url-to-GtkTreeRowReference */
di->webseed_hash = g_hash_table_new_full(g_str_hash, g_str_equal, (GDestroyNotify)g_free,
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
(GDestroyNotify)gtk_tree_row_reference_free);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ret = vbox;
return ret;
(trunk gtk) tweak the encryption ui in the details dialog
2009-04-19 17:00:28 +00:00
}
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
/****
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
*****
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
***** TRACKER
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
*****
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
****/
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
/* if it's been longer than a minute, don't bother showing the seconds */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void tr_strltime_rounded(char* buf, time_t t, size_t buflen)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (t > 60)
{
t -= (t % 60);
}
tr_strltime(buf, t, buflen);
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
(trunk) libT and gtk+ parts for #1889: per-torrent vs. global speed limit confusion
2009-03-04 19:52:57 +00:00
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void buildTrackerSummary(GString* gstr, char const* key, tr_tracker_stat const* st, gboolean showScrape)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
char* str;
char timebuf[256];
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
time_t const now = time(NULL);
char const* err_markup_begin = "<span color=\"red\">";
char const* err_markup_end = "</span>";
char const* timeout_markup_begin = "<span color=\"#224466\">";
char const* timeout_markup_end = "</span>";
char const* success_markup_begin = "<span color=\"#008B00\">";
char const* success_markup_end = "</span>";
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* hostname */
{
g_string_append(gstr, st->isBackup ? "<i>" : "<b>");
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
if (key != NULL)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
str = g_markup_printf_escaped("%s - %s", st->host, key);
}
else
{
str = g_markup_printf_escaped("%s", st->host);
}
g_string_append(gstr, str);
g_free(str);
g_string_append(gstr, st->isBackup ? "</i>" : "</b>");
}
if (!st->isBackup)
{
if (st->hasAnnounced && st->announceState != TR_TRACKER_INACTIVE)
{
g_string_append_c(gstr, '\n');
tr_strltime_rounded(timebuf, now - st->lastAnnounceTime, sizeof(timebuf));
if (st->lastAnnounceSucceeded)
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_string_append_printf(gstr, _("Got a list of %1$s%2$'d peers%3$s %4$s ago"),
success_markup_begin, st->lastAnnouncePeerCount, success_markup_end, timebuf);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
else if (st->lastAnnounceTimedOut)
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_string_append_printf(gstr, _("Peer list request %1$stimed out%2$s %3$s ago; will retry"),
timeout_markup_begin, timeout_markup_end, timebuf);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
else
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_string_append_printf(gstr, _("Got an error %1$s\"%2$s\"%3$s %4$s ago"), err_markup_begin,
st->lastAnnounceResult, err_markup_end, timebuf);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
}
switch (st->announceState)
{
case TR_TRACKER_INACTIVE:
g_string_append_c(gstr, '\n');
g_string_append(gstr, _("No updates scheduled"));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case TR_TRACKER_WAITING:
tr_strltime_rounded(timebuf, st->nextAnnounceTime - now, sizeof(timebuf));
g_string_append_c(gstr, '\n');
g_string_append_printf(gstr, _("Asking for more peers in %s"), timebuf);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case TR_TRACKER_QUEUED:
g_string_append_c(gstr, '\n');
g_string_append(gstr, _("Queued to ask for more peers"));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
break;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
case TR_TRACKER_ACTIVE:
tr_strltime_rounded(timebuf, now - st->lastAnnounceStartTime, sizeof(timebuf));
g_string_append_c(gstr, '\n');
g_string_append_printf(gstr, _("Asking for more peers now… <small>%s</small>"), timebuf);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
break;
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
(trunk) replace tr_tracker_stat's "isActive" field with the more descriptive "isBackup"
2009-10-10 00:17:00 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (showScrape)
(trunk) replace tr_tracker_stat's "isActive" field with the more descriptive "isBackup"
2009-10-10 00:17:00 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (st->hasScraped)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_string_append_c(gstr, '\n');
tr_strltime_rounded(timebuf, now - st->lastScrapeTime, sizeof(timebuf));
if (st->lastScrapeSucceeded)
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_string_append_printf(gstr, _("Tracker had %s%'d seeders and %'d leechers%s %s ago"), success_markup_begin,
st->seederCount, st->leecherCount, success_markup_end, timebuf);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
else
{
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
g_string_append_printf(gstr, _("Got a scrape error \"%s%s%s\" %s ago"), err_markup_begin,
st->lastScrapeResult, err_markup_end, timebuf);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(trunk) replace tr_tracker_stat's "isActive" field with the more descriptive "isBackup"
2009-10-10 00:17:00 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
switch (st->scrapeState)
(trunk) replace tr_tracker_stat's "isActive" field with the more descriptive "isBackup"
2009-10-10 00:17:00 +00:00
{
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
case TR_TRACKER_INACTIVE:
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
break;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
case TR_TRACKER_WAITING:
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_string_append_c(gstr, '\n');
tr_strltime_rounded(timebuf, st->nextScrapeTime - now, sizeof(timebuf));
g_string_append_printf(gstr, _("Asking for peer counts in %s"), timebuf);
break;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
case TR_TRACKER_QUEUED:
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_string_append_c(gstr, '\n');
g_string_append(gstr, _("Queued to ask for peer counts"));
break;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
case TR_TRACKER_ACTIVE:
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_string_append_c(gstr, '\n');
tr_strltime_rounded(timebuf, now - st->lastScrapeStartTime, sizeof(timebuf));
g_string_append_printf(gstr, _("Asking for peer counts now… <small>%s</small>"), timebuf);
break;
(trunk) replace tr_tracker_stat's "isActive" field with the more descriptive "isBackup"
2009-10-10 00:17:00 +00:00
}
}
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
(gtk) add options to set global & per-torrent peer connection limits
2007-12-22 00:06:38 +00:00
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
enum
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
TRACKER_COL_TORRENT_ID,
TRACKER_COL_TEXT,
TRACKER_COL_IS_BACKUP,
TRACKER_COL_TRACKER_ID,
TRACKER_COL_FAVICON,
TRACKER_COL_WAS_UPDATED,
TRACKER_COL_KEY,
TRACKER_N_COLS
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
};
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static gboolean trackerVisibleFunc(GtkTreeModel* model, GtkTreeIter* iter, gpointer data)
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gboolean isBackup;
struct DetailsImpl* di = data;
libT: add tracker information to tr_stat. gtk: add `tracker' tab to inspector
2008-02-21 07:29:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* show all */
if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(di->all_check)))
{
return TRUE;
}
libT: add tracker information to tr_stat. gtk: add `tracker' tab to inspector
2008-02-21 07:29:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* don't show the backups... */
gtk_tree_model_get(model, iter, TRACKER_COL_IS_BACKUP, &isBackup, -1);
return !isBackup;
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static int tracker_list_get_current_torrent_id(struct DetailsImpl* di)
(trunk gtk) #3011 "'Edit Trackers' dialog not reset after Cancel" -- fixed in trunk for 2.00
2010-03-10 19:16:25 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int torrent_id = -1;
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* if there's only one torrent in the dialog, always use it */
fix: resolve some lgtm warnings (#1444) * fix: warnings found by LGTM static analyzer
2020-09-11 21:07:45 +00:00
if (g_slist_length(di->ids) == 1)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
fix: resolve some lgtm warnings (#1444) * fix: warnings found by LGTM static analyzer
2020-09-11 21:07:45 +00:00
torrent_id = GPOINTER_TO_INT(di->ids->data);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
}
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* otherwise, use the selected tracker's torrent */
if (torrent_id < 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkTreeIter iter;
GtkTreeModel* model;
GtkTreeSelection* sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(di->tracker_view));
if (gtk_tree_selection_get_selected(sel, &model, &iter))
{
gtk_tree_model_get(model, &iter, TRACKER_COL_TORRENT_ID, &torrent_id, -1);
}
(trunk gtk) #3011 "'Edit Trackers' dialog not reset after Cancel" -- fixed in trunk for 2.00
2010-03-10 19:16:25 +00:00
}
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return torrent_id;
(trunk gtk) #3011 "'Edit Trackers' dialog not reset after Cancel" -- fixed in trunk for 2.00
2010-03-10 19:16:25 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static tr_torrent* tracker_list_get_current_torrent(struct DetailsImpl* di)
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const torrent_id = tracker_list_get_current_torrent_id(di);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return gtr_core_find_torrent(di->core, torrent_id);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
(trunk gtk) fix the editing of tracker URLs in the GTK+ client
2009-10-04 02:32:38 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void favicon_ready_cb(gpointer pixbuf, gpointer vreference)
(trunk gtk) #3166 "Add Tracker Favicons to Tracker Tab in Properties Window." -- implemented in trunk for 2.00
2010-04-23 01:46:02 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkTreeIter iter;
GtkTreeRowReference* reference = vreference;
(trunk gtk) #3166 "Add Tracker Favicons to Tracker Tab in Properties Window." -- implemented in trunk for 2.00
2010-04-23 01:46:02 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (pixbuf != NULL)
(trunk gtk) #3166 "Add Tracker Favicons to Tracker Tab in Properties Window." -- implemented in trunk for 2.00
2010-04-23 01:46:02 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkTreePath* path = gtk_tree_row_reference_get_path(reference);
GtkTreeModel* model = gtk_tree_row_reference_get_model(reference);
(trunk gtk) #3166 "Add Tracker Favicons to Tracker Tab in Properties Window." -- implemented in trunk for 2.00
2010-04-23 01:46:02 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (gtk_tree_model_get_iter(model, &iter, path))
{
gtk_list_store_set(GTK_LIST_STORE(model), &iter, TRACKER_COL_FAVICON, pixbuf, -1);
}
(trunk gtk) #3166 "Add Tracker Favicons to Tracker Tab in Properties Window." -- implemented in trunk for 2.00
2010-04-23 01:46:02 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_tree_path_free(path);
g_object_unref(pixbuf);
(trunk gtk) #3166 "Add Tracker Favicons to Tracker Tab in Properties Window." -- implemented in trunk for 2.00
2010-04-23 01:46:02 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_tree_row_reference_free(reference);
(trunk gtk) #3166 "Add Tracker Favicons to Tracker Tab in Properties Window." -- implemented in trunk for 2.00
2010-04-23 01:46:02 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void refreshTracker(struct DetailsImpl* di, tr_torrent** torrents, int n)
{
int* statCount;
tr_tracker_stat** stats;
GtkTreeIter iter;
GtkTreeModel* model;
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
GString* gstr = di->gstr; /* buffer for temporary strings */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GHashTable* hash = di->tracker_hash;
GtkListStore* store = di->tracker_store;
tr_session* session = gtr_core_session(di->core);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
gboolean const showScrape = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(di->scrape_check));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 1: get all the trackers */
statCount = g_new0(int, n);
stats = g_new0(tr_tracker_stat*, n);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
stats[i] = tr_torrentTrackers(torrents[i], &statCount[i]);
}
/* step 2: mark all the trackers in the list as not-updated */
model = GTK_TREE_MODEL(store);
if (gtk_tree_model_iter_nth_child(model, &iter, NULL, 0))
{
do
{
gtk_list_store_set(store, &iter, TRACKER_COL_WAS_UPDATED, FALSE, -1);
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
while (gtk_tree_model_iter_next(model, &iter));
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
#838 (Adding trackers to existing torrents): add a backend API for this (tr_torrentSetAnnounceList) and implement a GUI for it in the gtk+ client.
2008-06-01 01:40:32 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 3: add any new trackers */
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
(trunk gtk) more heap pruning: give DetailsImpl an internal GString buffer so that it doesn't have to create and free so many temporary strings
2011-04-12 10:51:52 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const jn = statCount[i];
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int j = 0; j < jn; ++j)
(trunk gtk) more heap pruning: give DetailsImpl an internal GString buffer so that it doesn't have to create and free so many temporary strings
2011-04-12 10:51:52 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_torrent const* tor = torrents[i];
tr_tracker_stat const* st = &stats[i][j];
int const torrent_id = tr_torrentId(tor);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* build the key to find the row */
g_string_truncate(gstr, 0);
g_string_append_printf(gstr, "%d\t%d\t%s", torrent_id, st->tier, st->announce);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (g_hash_table_lookup(hash, gstr->str) == NULL)
{
GtkTreePath* p;
GtkTreeRowReference* ref;
gtk_list_store_insert_with_values(store, &iter, -1,
TRACKER_COL_TORRENT_ID, torrent_id,
TRACKER_COL_TRACKER_ID, st->id,
TRACKER_COL_KEY, gstr->str,
-1);
p = gtk_tree_model_get_path(model, &iter);
ref = gtk_tree_row_reference_new(model, p);
g_hash_table_insert(hash, g_strdup(gstr->str), ref);
ref = gtk_tree_row_reference_new(model, p);
gtr_get_favicon_from_url(session, st->announce, favicon_ready_cb, ref);
gtk_tree_path_free(p);
}
}
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 4: update the peers */
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_torrent const* tor = torrents[i];
char const* summary_name = n > 1 ? tr_torrentName(tor) : NULL;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int j = 0; j < statCount[i]; ++j)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
GtkTreePath* p;
GtkTreeRowReference* ref;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_tracker_stat const* st = &stats[i][j];
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* build the key to find the row */
g_string_truncate(gstr, 0);
g_string_append_printf(gstr, "%d\t%d\t%s", tr_torrentId(tor), st->tier, st->announce);
ref = g_hash_table_lookup(hash, gstr->str);
p = gtk_tree_row_reference_get_path(ref);
gtk_tree_model_get_iter(model, &iter, p);
/* update the row */
g_string_truncate(gstr, 0);
buildTrackerSummary(gstr, summary_name, st, showScrape);
gtk_list_store_set(store, &iter,
TRACKER_COL_TEXT, gstr->str,
TRACKER_COL_IS_BACKUP, st->isBackup,
TRACKER_COL_TRACKER_ID, st->id,
TRACKER_COL_WAS_UPDATED, TRUE,
-1);
/* cleanup */
gtk_tree_path_free(p);
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
}
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* step 5: remove trackers that have disappeared */
if (gtk_tree_model_iter_nth_child(model, &iter, NULL, 0))
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gboolean more = TRUE;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
while (more)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gboolean b;
gtk_tree_model_get(model, &iter, TRACKER_COL_WAS_UPDATED, &b, -1);
if (b)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
more = gtk_tree_model_iter_next(model, &iter);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char* key;
gtk_tree_model_get(model, &iter, TRACKER_COL_KEY, &key, -1);
g_hash_table_remove(hash, key);
more = gtk_list_store_remove(store, &iter);
g_free(key);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_widget_set_sensitive(di->edit_trackers_button, tracker_list_get_current_torrent_id(di) >= 0);
libT: add tracker information to tr_stat. gtk: add `tracker' tab to inspector
2008-02-21 07:29:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* cleanup */
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; i < n; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
tr_torrentTrackersFree(stats[i], statCount[i]);
}
g_free(stats);
g_free(statCount);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
libT: add tracker information to tr_stat. gtk: add `tracker' tab to inspector
2008-02-21 07:29:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void onScrapeToggled(GtkToggleButton* button, struct DetailsImpl* di)
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_quark const key = TR_KEY_show_tracker_scrapes;
gboolean const value = gtk_toggle_button_get_active(button);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_core_set_pref_bool(di->core, key, value);
refresh(di);
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
libT: add tracker information to tr_stat. gtk: add `tracker' tab to inspector
2008-02-21 07:29:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void onBackupToggled(GtkToggleButton* button, struct DetailsImpl* di)
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_quark const key = TR_KEY_show_backup_trackers;
gboolean const value = gtk_toggle_button_get_active(button);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_core_set_pref_bool(di->core, key, value);
refresh(di);
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
libT: add tracker information to tr_stat. gtk: add `tracker' tab to inspector
2008-02-21 07:29:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void on_edit_trackers_response(GtkDialog* dialog, int response, gpointer data)
(trunk gtk) implement 'edit trackers' window in gtk client
2009-09-26 00:48:07 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gboolean do_destroy = TRUE;
struct DetailsImpl* di = data;
(trunk gtk) implement 'edit trackers' window in gtk client
2009-09-26 00:48:07 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (response == GTK_RESPONSE_ACCEPT)
(trunk gtk) implement 'edit trackers' window in gtk client
2009-09-26 00:48:07 +00:00
{
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
int n;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int tier;
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
GtkTextIter start;
GtkTextIter end;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const torrent_id = GPOINTER_TO_INT(g_object_get_qdata(G_OBJECT(dialog), TORRENT_ID_KEY));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkTextBuffer* text_buffer = g_object_get_qdata(G_OBJECT(dialog), TEXT_BUFFER_KEY);
tr_torrent* tor = gtr_core_find_torrent(di->core, torrent_id);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (tor != NULL)
(trunk gtk) #2489: tr_torrentSetAnnounceList() should check for invalid and duplicate announce URLs
2009-10-10 19:24:46 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_tracker_info* trackers;
char** tracker_strings;
char* tracker_text;
/* build the array of trackers */
gtk_text_buffer_get_bounds(text_buffer, &start, &end);
tracker_text = gtk_text_buffer_get_text(text_buffer, &start, &end, FALSE);
tracker_strings = g_strsplit(tracker_text, "\n", 0);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
trackers = g_new0(tr_tracker_info, g_strv_length(tracker_strings));
n = 0;
tier = 0;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (int i = 0; tracker_strings[i] != NULL; ++i)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
char* const str = tracker_strings[i];
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
Introduce `tr_str_is_empty` to relay intent better
2019-07-13 08:52:44 +00:00
if (tr_str_is_empty(str))
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
++tier;
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
trackers[n].tier = tier;
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
trackers[n].announce = str;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
++n;
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
}
(trunk gtk) implement 'edit trackers' window in gtk client
2009-09-26 00:48:07 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* update the torrent */
if (tr_torrentSetAnnounceList(tor, trackers, n))
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
refresh(di);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* w;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
char const* text = _("List contains invalid URLs");
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
w = gtk_message_dialog_new(GTK_WINDOW(dialog), GTK_DIALOG_MODAL, GTK_MESSAGE_ERROR, GTK_BUTTONS_CLOSE, "%s",
text);
gtk_message_dialog_format_secondary_text(GTK_MESSAGE_DIALOG(w), "%s",
_("Please correct the errors and try again."));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_dialog_run(GTK_DIALOG(w));
gtk_widget_destroy(w);
do_destroy = FALSE;
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
(trunk gtk) implement 'edit trackers' window in gtk client
2009-09-26 00:48:07 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
/* cleanup */
g_free(trackers);
g_strfreev(tracker_strings);
g_free(tracker_text);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
(trunk gtk) #3011 "'Edit Trackers' dialog not reset after Cancel" -- fixed in trunk for 2.00
2010-03-10 19:16:25 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (do_destroy)
{
gtk_widget_destroy(GTK_WIDGET(dialog));
}
(trunk gtk) implement 'edit trackers' window in gtk client
2009-09-26 00:48:07 +00:00
}
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
static void get_editable_tracker_list(GString* gstr, tr_torrent const* tor)
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int tier = 0;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_info const* inf = tr_torrentInfo(tor);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Reduce for loop variables scope
2017-05-13 22:38:31 +00:00
for (unsigned int i = 0; i < inf->trackerCount; ++i)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_tracker_info const* t = &inf->trackers[i];
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (tier != t->tier)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tier = t->tier;
g_string_append_c(gstr, '\n');
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_string_append_printf(gstr, "%s\n", t->announce);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (gstr->len > 0)
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_string_truncate(gstr, gstr->len - 1);
}
}
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void on_edit_trackers(GtkButton* button, gpointer data)
{
struct DetailsImpl* di = data;
tr_torrent* tor = tracker_list_get_current_torrent(di);
if (tor != NULL)
{
guint row;
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
GtkWidget* w;
GtkWidget* d;
GtkWidget* fr;
GtkWidget* t;
GtkWidget* l;
GtkWidget* sw;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWindow* win = GTK_WINDOW(gtk_widget_get_toplevel(GTK_WIDGET(button)));
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
GString* gstr = di->gstr; /* buffer for temporary strings */
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const torrent_id = tr_torrentId(tor);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_string_truncate(gstr, 0);
g_string_append_printf(gstr, _("%s - Edit Trackers"), tr_torrentName(tor));
chore: fix deprecation warnings of GTK_STOCK_ use. (#1370) * chore: fix deprecation warnings of GTK_STOCK_ use. This is just a tiny step towards getting all of the GTK code up-to-date, but GTK_STOCK warnings are the lowest-hanging fruit of the warnings, so let's fix them.
2020-07-27 17:49:45 +00:00
d = gtk_dialog_new_with_buttons(gstr->str, win, GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
_("_Cancel"), GTK_RESPONSE_CANCEL,
_("_Save"), GTK_RESPONSE_ACCEPT,
NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_signal_connect(d, "response", G_CALLBACK(on_edit_trackers_response), data);
row = 0;
t = hig_workarea_create();
hig_workarea_add_section_title(t, &row, _("Tracker Announce URLs"));
l = gtk_label_new(NULL);
gtk_label_set_markup(GTK_LABEL(l), _("To add a backup URL, add it on the line after the primary URL.\n"
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
"To add another primary URL, add it after a blank line."));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_label_set_justify(GTK_LABEL(l), GTK_JUSTIFY_LEFT);
Fix some gtk warnings (#1038) * fix gtk deprecation warning: gtk_misc_set_alignment * fix gtk deprecation warning: gtk_alignment_new * fix gtk deprecation warning: gtk_tree_view_set_rules_hint * fix gtk deprecation warning: gtk_image_new_from_stock * fixup! fix gtk deprecation warning: gtk_alignment_new * fix gtk deprecation warning: gtk_dialog_set_alternative_button_order * fix gtk deprecation warning: gtk_show_uri * fix gtk deprecation warning: gtk_widget_set_margin_left * fix gtk deprecation warning: gtk_button_set_alignment * fix gtk deprecation warning: g_type_class_add_private * fix gtk deprecation warning: gtk_menu_popup * fix gtk deprecation warning: gtk_misc_set_padding * chore: uncrustify * fix: silence G_TYPE_INSTANCE_GET_PRIVATE warning Deprecaed starting in glib 2.58 * chore: uncrustify
2019-11-06 19:09:27 +00:00
g_object_set(l, "halign", GTK_ALIGN_START, "valign", GTK_ALIGN_CENTER, NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
hig_workarea_add_wide_control(t, &row, l);
w = gtk_text_view_new();
g_string_truncate(gstr, 0);
get_editable_tracker_list(gstr, tor);
gtk_text_buffer_set_text(gtk_text_view_get_buffer(GTK_TEXT_VIEW(w)), gstr->str, -1);
fr = gtk_frame_new(NULL);
gtk_frame_set_shadow_type(GTK_FRAME(fr), GTK_SHADOW_IN);
sw = gtk_scrolled_window_new(NULL, NULL);
gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(sw), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
gtk_container_add(GTK_CONTAINER(sw), w);
gtk_container_add(GTK_CONTAINER(fr), sw);
Uppercase the literal suffixes * MISRA C++:2008, 2-13-4 - Literal suffixes shall be upper case * MISRA C:2012, 7.3 - The lowercase character "l" shall not be used in a literal suffix * CERT DCL16-C. - Use "L," not "l," to indicate a long value * CERT, DCL50-J. - Use visually distinct identifiers
2019-03-17 04:07:48 +00:00
gtk_widget_set_size_request(fr, 500U, 166U);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
hig_workarea_add_wide_tall_control(t, &row, fr);
gtr_dialog_set_content(GTK_DIALOG(d), t);
g_object_set_qdata(G_OBJECT(d), TORRENT_ID_KEY, GINT_TO_POINTER(torrent_id));
g_object_set_qdata(G_OBJECT(d), TEXT_BUFFER_KEY, gtk_text_view_get_buffer(GTK_TEXT_VIEW(w)));
gtk_widget_show(d);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void on_tracker_list_selection_changed(GtkTreeSelection* sel, gpointer gdi)
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
struct DetailsImpl* di = gdi;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const n = gtk_tree_selection_count_selected_rows(sel);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_torrent* tor = tracker_list_get_current_torrent(di);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_widget_set_sensitive(di->remove_tracker_button, n > 0);
gtk_widget_set_sensitive(di->add_tracker_button, tor != NULL);
gtk_widget_set_sensitive(di->edit_trackers_button, tor != NULL);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void on_add_tracker_response(GtkDialog* dialog, int response, gpointer gdi)
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gboolean destroy = TRUE;
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (response == GTK_RESPONSE_ACCEPT)
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
struct DetailsImpl* di = gdi;
GtkWidget* e = GTK_WIDGET(g_object_get_qdata(G_OBJECT(dialog), URL_ENTRY_KEY));
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const torrent_id = GPOINTER_TO_INT(g_object_get_qdata(G_OBJECT(dialog), TORRENT_ID_KEY));
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char* url = g_strdup(gtk_entry_get_text(GTK_ENTRY(e)));
g_strstrip(url);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
Introduce `tr_str_is_empty` to relay intent better
2019-07-13 08:52:44 +00:00
if (!tr_str_is_empty(url))
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (tr_urlIsValidTracker(url))
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
{
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
tr_variant top;
tr_variant* args;
tr_variant* trackers;
Improve RPC performance for local sessions Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_variantInitDict(&top, 2);
tr_variantDictAddStr(&top, TR_KEY_method, "torrent-set");
args = tr_variantDictAddDict(&top, TR_KEY_arguments, 2);
tr_variantDictAddInt(args, TR_KEY_id, torrent_id);
trackers = tr_variantDictAddList(args, TR_KEY_trackerAdd, 1);
tr_variantListAddStr(trackers, url);
Improve RPC performance for local sessions Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_core_exec(di->core, &top);
refresh(di);
Improve RPC performance for local sessions Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_variantFree(&top);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_unrecognized_url_dialog(GTK_WIDGET(dialog), url);
destroy = FALSE;
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_free(url);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (destroy)
{
gtk_widget_destroy(GTK_WIDGET(dialog));
}
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
Switch from UNUSED macro to TR_UNUSED macro Since there is no way to mark parameters as [potentially] unused in standard C and when using MSVC compiler, use the widely accepted cast-to-void approach instead.
2020-08-18 10:36:10 +00:00
static void on_tracker_list_add_button_clicked(GtkButton* button, gpointer gdi)
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
{
Switch from UNUSED macro to TR_UNUSED macro Since there is no way to mark parameters as [potentially] unused in standard C and when using MSVC compiler, use the widely accepted cast-to-void approach instead.
2020-08-18 10:36:10 +00:00
TR_UNUSED(button);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
struct DetailsImpl* di = gdi;
tr_torrent* tor = tracker_list_get_current_torrent(di);
if (tor != NULL)
{
guint row;
GtkWidget* e;
GtkWidget* t;
GtkWidget* w;
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
GString* gstr = di->gstr; /* buffer for temporary strings */
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_string_truncate(gstr, 0);
g_string_append_printf(gstr, _("%s - Add Tracker"), tr_torrentName(tor));
chore: fix deprecation warnings of GTK_STOCK_ use. (#1370) * chore: fix deprecation warnings of GTK_STOCK_ use. This is just a tiny step towards getting all of the GTK code up-to-date, but GTK_STOCK warnings are the lowest-hanging fruit of the warnings, so let's fix them.
2020-07-27 17:49:45 +00:00
w = gtk_dialog_new_with_buttons(gstr->str, GTK_WINDOW(di->dialog), GTK_DIALOG_DESTROY_WITH_PARENT,
_("_Cancel"), GTK_RESPONSE_CANCEL,
_("_Add"), GTK_RESPONSE_ACCEPT,
NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_signal_connect(w, "response", G_CALLBACK(on_add_tracker_response), gdi);
row = 0;
t = hig_workarea_create();
hig_workarea_add_section_title(t, &row, _("Tracker"));
e = gtk_entry_new();
gtk_widget_set_size_request(e, 400, -1);
gtr_paste_clipboard_url_into_entry(e);
g_object_set_qdata(G_OBJECT(w), URL_ENTRY_KEY, e);
g_object_set_qdata(G_OBJECT(w), TORRENT_ID_KEY, GINT_TO_POINTER(tr_torrentId(tor)));
hig_workarea_add_row(t, &row, _("_Announce URL:"), e, NULL);
gtr_dialog_set_content(GTK_DIALOG(w), t);
gtk_widget_show_all(w);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
}
Switch from UNUSED macro to TR_UNUSED macro Since there is no way to mark parameters as [potentially] unused in standard C and when using MSVC compiler, use the widely accepted cast-to-void approach instead.
2020-08-18 10:36:10 +00:00
static void on_tracker_list_remove_button_clicked(GtkButton* button, gpointer gdi)
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
{
Switch from UNUSED macro to TR_UNUSED macro Since there is no way to mark parameters as [potentially] unused in standard C and when using MSVC compiler, use the widely accepted cast-to-void approach instead.
2020-08-18 10:36:10 +00:00
TR_UNUSED(button);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkTreeIter iter;
GtkTreeModel* model;
struct DetailsImpl* di = gdi;
GtkTreeView* v = GTK_TREE_VIEW(di->tracker_view);
GtkTreeSelection* sel = gtk_tree_view_get_selection(v);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (gtk_tree_selection_get_selected(sel, &model, &iter))
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int torrent_id;
int tracker_id;
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
tr_variant top;
tr_variant* args;
tr_variant* trackers;
Improve RPC performance for local sessions Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_tree_model_get(model, &iter,
TRACKER_COL_TRACKER_ID, &tracker_id,
TRACKER_COL_TORRENT_ID, &torrent_id,
-1);
Improve RPC performance for local sessions Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_variantInitDict(&top, 2);
tr_variantDictAddStr(&top, TR_KEY_method, "torrent-set");
args = tr_variantDictAddDict(&top, TR_KEY_arguments, 2);
tr_variantDictAddInt(args, TR_KEY_id, torrent_id);
trackers = tr_variantDictAddList(args, TR_KEY_trackerRemove, 1);
tr_variantListAddInt(trackers, tracker_id);
Improve RPC performance for local sessions Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_core_exec(di->core, &top);
refresh(di);
Improve RPC performance for local sessions Don't unnecessarily de-/serialize JSON data if local session is used.
2015-07-13 00:32:48 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_variantFree(&top);
(trunk libT) #3898 "Add 'Add' and 'Remove' buttons to the tracker list" -- done.
2011-01-14 21:57:20 +00:00
}
(trunk) #1699: Announce to multiple trackers at once #2424: Tracker address is not listed in GTK client.
2009-09-25 21:05:59 +00:00
}
libT: add tracker information to tr_stat. gtk: add `tracker' tab to inspector
2008-02-21 07:29:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static GtkWidget* tracker_page_new(struct DetailsImpl* di)
{
gboolean b;
GtkCellRenderer* r;
GtkTreeViewColumn* c;
GtkTreeSelection* sel;
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
GtkWidget* vbox;
GtkWidget* sw;
GtkWidget* w;
GtkWidget* v;
GtkWidget* hbox;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const pad = (GUI_PAD + GUI_PAD_BIG) / 2;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, GUI_PAD);
gtk_container_set_border_width(GTK_CONTAINER(vbox), GUI_PAD_BIG);
di->tracker_store = gtk_list_store_new(TRACKER_N_COLS,
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
G_TYPE_INT,
G_TYPE_STRING,
G_TYPE_BOOLEAN,
G_TYPE_INT,
GDK_TYPE_PIXBUF,
G_TYPE_BOOLEAN,
G_TYPE_STRING);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
di->tracker_hash = g_hash_table_new_full(g_str_hash, g_str_equal, (GDestroyNotify)g_free,
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
(GDestroyNotify)gtk_tree_row_reference_free);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
di->trackers_filtered = gtk_tree_model_filter_new(GTK_TREE_MODEL(di->tracker_store), NULL);
Make conditional expressions explicitly boolean
2017-04-30 16:25:26 +00:00
gtk_tree_model_filter_set_visible_func(GTK_TREE_MODEL_FILTER(di->trackers_filtered), trackerVisibleFunc, di, NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, GUI_PAD_BIG);
v = di->tracker_view = gtk_tree_view_new_with_model(GTK_TREE_MODEL(di->trackers_filtered));
g_object_unref(di->trackers_filtered);
gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(v), FALSE);
g_signal_connect(v, "button-press-event", G_CALLBACK(on_tree_view_button_pressed), NULL);
g_signal_connect(v, "button-release-event", G_CALLBACK(on_tree_view_button_released), NULL);
sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(v));
g_signal_connect(sel, "changed", G_CALLBACK(on_tracker_list_selection_changed), di);
c = gtk_tree_view_column_new();
gtk_tree_view_column_set_title(c, _("Trackers"));
gtk_tree_view_append_column(GTK_TREE_VIEW(v), c);
r = gtk_cell_renderer_pixbuf_new();
Uppercase the literal suffixes * MISRA C++:2008, 2-13-4 - Literal suffixes shall be upper case * MISRA C:2012, 7.3 - The lowercase character "l" shall not be used in a literal suffix * CERT DCL16-C. - Use "L," not "l," to indicate a long value * CERT, DCL50-J. - Use visually distinct identifiers
2019-03-17 04:07:48 +00:00
g_object_set(r, "width", 20 + (GUI_PAD_SMALL * 2), "xpad", GUI_PAD_SMALL, "ypad", pad, "yalign", 0.0F, NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_tree_view_column_pack_start(c, r, FALSE);
gtk_tree_view_column_add_attribute(c, r, "pixbuf", TRACKER_COL_FAVICON);
r = gtk_cell_renderer_text_new();
g_object_set(G_OBJECT(r), "ellipsize", PANGO_ELLIPSIZE_END, "xpad", GUI_PAD_SMALL, "ypad", pad, NULL);
gtk_tree_view_column_pack_start(c, r, TRUE);
gtk_tree_view_column_add_attribute(c, r, "markup", TRACKER_COL_TEXT);
sw = gtk_scrolled_window_new(NULL, NULL);
gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(sw), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
gtk_container_add(GTK_CONTAINER(sw), v);
w = gtk_frame_new(NULL);
gtk_frame_set_shadow_type(GTK_FRAME(w), GTK_SHADOW_IN);
gtk_container_add(GTK_CONTAINER(w), sw);
gtk_box_pack_start(GTK_BOX(hbox), w, TRUE, TRUE, 0);
v = gtk_box_new(GTK_ORIENTATION_VERTICAL, GUI_PAD);
w = gtk_button_new_with_mnemonic(_("_Add"));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
di->add_tracker_button = w;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_signal_connect(w, "clicked", G_CALLBACK(on_tracker_list_add_button_clicked), di);
gtk_box_pack_start(GTK_BOX(v), w, FALSE, FALSE, 0);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
w = gtk_button_new_with_mnemonic(_("_Edit"));
g_signal_connect(w, "clicked", G_CALLBACK(on_edit_trackers), di);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
di->edit_trackers_button = w;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_box_pack_start(GTK_BOX(v), w, FALSE, FALSE, 0);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
w = gtk_button_new_with_mnemonic(_("_Remove"));
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
di->remove_tracker_button = w;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_signal_connect(w, "clicked", G_CALLBACK(on_tracker_list_remove_button_clicked), di);
gtk_box_pack_start(GTK_BOX(v), w, FALSE, FALSE, 0);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_box_pack_start(GTK_BOX(hbox), v, FALSE, FALSE, 0);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_box_pack_start(GTK_BOX(vbox), hbox, TRUE, TRUE, 0);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
w = gtk_check_button_new_with_mnemonic(_("Show _more details"));
di->scrape_check = w;
b = gtr_pref_flag_get(TR_KEY_show_tracker_scrapes);
gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(w), b);
g_signal_connect(w, "toggled", G_CALLBACK(onScrapeToggled), di);
gtk_box_pack_start(GTK_BOX(vbox), w, FALSE, FALSE, 0);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
w = gtk_check_button_new_with_mnemonic(_("Show _backup trackers"));
di->all_check = w;
b = gtr_pref_flag_get(TR_KEY_show_backup_trackers);
gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(w), b);
g_signal_connect(w, "toggled", G_CALLBACK(onBackupToggled), di);
gtk_box_pack_start(GTK_BOX(vbox), w, FALSE, FALSE, 0);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return vbox;
libT: add tracker information to tr_stat. gtk: add `tracker' tab to inspector
2008-02-21 07:29:39 +00:00
}
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
/****
***** DIALOG
****/
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void refresh(struct DetailsImpl* di)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
int n;
tr_torrent** torrents = getTorrents(di, &n);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
refreshInfo(di, torrents, n);
refreshPeers(di, torrents, n);
refreshTracker(di, torrents, n);
refreshOptions(di, torrents, n);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (n == 0)
{
gtk_dialog_response(GTK_DIALOG(di->dialog), GTK_RESPONSE_CLOSE);
}
(trunk gtk) #2567: Close the preferences window when the torrent is deleted.
2009-11-09 07:38:22 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_free(torrents);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static gboolean periodic_refresh(gpointer data)
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
refresh(data);
(gtk) copyediting: use G_SOURCE_REMOVE and G_SOURCE_CONTINUE where appropriate
2013-01-04 16:36:52 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return G_SOURCE_CONTINUE;
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Switch from UNUSED macro to TR_UNUSED macro Since there is no way to mark parameters as [potentially] unused in standard C and when using MSVC compiler, use the widely accepted cast-to-void approach instead.
2020-08-18 10:36:10 +00:00
static void on_details_window_size_allocated(GtkWidget* gtk_window, GtkAllocation* alloc, gpointer gdata)
GTK: behavior improvements of the torrent details window (#892) * gtk: torrent details file-list default sort * gtk: save torrent details window size * gtk: torrent details window size & sort, code style * gtk: torrent details window, conf.c dict fix Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-27 21:34:02 +00:00
{
Switch from UNUSED macro to TR_UNUSED macro Since there is no way to mark parameters as [potentially] unused in standard C and when using MSVC compiler, use the widely accepted cast-to-void approach instead.
2020-08-18 10:36:10 +00:00
TR_UNUSED(alloc);
TR_UNUSED(gdata);
chore: sonarcloud warnings 2 (#1496) * fix "merge nested if" sonarcloud warnings * fix explicit constructor warnings in qt client
2020-11-01 21:47:57 +00:00
int w = 0;
int h = 0;
GTK: behavior improvements of the torrent details window (#892) * gtk: torrent details file-list default sort * gtk: save torrent details window size * gtk: torrent details window size & sort, code style * gtk: torrent details window, conf.c dict fix Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-27 21:34:02 +00:00
gtk_window_get_size(GTK_WINDOW(gtk_window), &w, &h);
gtr_pref_int_set(TR_KEY_details_window_width, w);
gtr_pref_int_set(TR_KEY_details_window_height, h);
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
static void details_free(gpointer gdata)
{
struct DetailsImpl* data = gdata;
g_source_remove(data->periodic_refresh_tag);
g_hash_table_destroy(data->tracker_hash);
g_hash_table_destroy(data->webseed_hash);
g_hash_table_destroy(data->peer_hash);
g_string_free(data->gstr, TRUE);
g_slist_free(data->ids);
g_free(data);
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
GtkWidget* gtr_torrent_details_dialog_new(GtkWindow* parent, TrCore* core)
{
Avoid declaring multiple variables on the same line
2017-05-01 15:46:41 +00:00
GtkWidget* d;
GtkWidget* n;
GtkWidget* v;
GtkWidget* w;
GtkWidget* l;
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
struct DetailsImpl* di = g_new0(struct DetailsImpl, 1);
/* one-time setup */
if (ARG_KEY == 0)
{
ARG_KEY = g_quark_from_static_string("tr-arg-key");
DETAILS_KEY = g_quark_from_static_string("tr-details-data-key");
TORRENT_ID_KEY = g_quark_from_static_string("tr-torrent-id-key");
TEXT_BUFFER_KEY = g_quark_from_static_string("tr-text-buffer-key");
URL_ENTRY_KEY = g_quark_from_static_string("tr-url-entry-key");
}
/* create the dialog */
di->core = core;
di->gstr = g_string_new(NULL);
chore: fix deprecation warnings of GTK_STOCK_ use. (#1370) * chore: fix deprecation warnings of GTK_STOCK_ use. This is just a tiny step towards getting all of the GTK code up-to-date, but GTK_STOCK warnings are the lowest-hanging fruit of the warnings, so let's fix them.
2020-07-27 17:49:45 +00:00
d = gtk_dialog_new_with_buttons(NULL, parent, 0,
_("_Close"), GTK_RESPONSE_CLOSE,
NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
di->dialog = d;
gtk_window_set_role(GTK_WINDOW(d), "tr-info");
GTK: behavior improvements of the torrent details window (#892) * gtk: torrent details file-list default sort * gtk: save torrent details window size * gtk: torrent details window size & sort, code style * gtk: torrent details window, conf.c dict fix Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-27 21:34:02 +00:00
/* return saved window size */
Fix or silence gtk warnings (#1380) * chore: disable deprecation warnings in GTK client Yes, updating the GTK codebase is still a goal. (help welcomed!) But there's a deluge of deprecation warnings that drown out other more important warnings, so turn off deprecation warnings for now. * fixup! chore: disable deprecation warnings in GTK client * fix: gtk_tree_sortable_set_sort_column_id caller. * fix: gtk_window_resize caller.
2020-07-30 19:45:11 +00:00
gtk_window_resize(GTK_WINDOW(d),
gtr_pref_int_get(TR_KEY_details_window_width),
gtr_pref_int_get(TR_KEY_details_window_height));
GTK: behavior improvements of the torrent details window (#892) * gtk: torrent details file-list default sort * gtk: save torrent details window size * gtk: torrent details window size & sort, code style * gtk: torrent details window, conf.c dict fix Co-authored-by: Charles Kerr <ckerr@github.com>
2020-04-27 21:34:02 +00:00
g_signal_connect(d, "size-allocate", G_CALLBACK(on_details_window_size_allocated), NULL);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_signal_connect_swapped(d, "response", G_CALLBACK(gtk_widget_destroy), d);
gtk_container_set_border_width(GTK_CONTAINER(d), GUI_PAD);
g_object_set_qdata_full(G_OBJECT(d), DETAILS_KEY, di, details_free);
n = gtk_notebook_new();
gtk_container_set_border_width(GTK_CONTAINER(n), GUI_PAD);
w = info_page_new(di);
l = gtk_label_new(_("Information"));
gtk_notebook_append_page(GTK_NOTEBOOK(n), w, l);
w = peer_page_new(di);
l = gtk_label_new(_("Peers"));
Code style change leftovers For some reason, GTK client wasn't fully processed. All the rest of changes are mostly in comments.
2017-04-21 07:40:57 +00:00
gtk_notebook_append_page(GTK_NOTEBOOK(n), w, l);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
w = tracker_page_new(di);
l = gtk_label_new(_("Trackers"));
gtk_notebook_append_page(GTK_NOTEBOOK(n), w, l);
v = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
di->file_list = gtr_file_list_new(core, 0);
di->file_label = gtk_label_new(_("File listing not available for combined torrent properties"));
gtk_box_pack_start(GTK_BOX(v), di->file_list, TRUE, TRUE, 0);
gtk_box_pack_start(GTK_BOX(v), di->file_label, TRUE, TRUE, 0);
gtk_container_set_border_width(GTK_CONTAINER(v), GUI_PAD_BIG);
l = gtk_label_new(_("Files"));
gtk_notebook_append_page(GTK_NOTEBOOK(n), v, l);
w = options_page_new(di);
l = gtk_label_new(_("Options"));
gtk_notebook_append_page(GTK_NOTEBOOK(n), w, l);
gtr_dialog_set_content(GTK_DIALOG(d), n);
di->periodic_refresh_tag = gdk_threads_add_timeout_seconds(SECONDARY_WINDOW_REFRESH_INTERVAL_SECONDS, periodic_refresh, di);
return d;
patches from Charles Kerr to update the Inspector in GTK and fix some memory leaks
2007-06-06 00:30:13 +00:00
}
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void gtr_torrent_details_dialog_set_torrents(GtkWidget* w, GSList* ids)
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
char title[256];
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const len = g_slist_length(ids);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
struct DetailsImpl* di = g_object_get_qdata(G_OBJECT(w), DETAILS_KEY);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_slist_free(di->ids);
di->ids = g_slist_copy(ids);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (len == 1)
(gtk) clean up yesterday's properties dialog rewrite a bit.
2009-04-24 12:05:53 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
int const id = GPOINTER_TO_INT(ids->data);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
tr_torrent* tor = gtr_core_find_torrent(di->core, id);
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
tr_info const* inf = tr_torrentInfo(tor);
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
g_snprintf(title, sizeof(title), _("%s Properties"), inf->name);
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_file_list_set_torrent(di->file_list, id);
gtk_widget_show(di->file_list);
gtk_widget_hide(di->file_label);
(gtk) clean up yesterday's properties dialog rewrite a bit.
2009-04-24 12:05:53 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtr_file_list_clear(di->file_list);
gtk_widget_hide(di->file_list);
gtk_widget_show(di->file_label);
g_snprintf(title, sizeof(title), _("%'d Torrent Properties"), len);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
gtk_window_set_title(GTK_WINDOW(w), title);
(gtk) clean up yesterday's properties dialog rewrite a bit.
2009-04-24 12:05:53 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
refresh(di);
(trunk gtk) #1473: Properties dialog should let you edit/view multiple torrents at once
2009-04-24 01:37:04 +00:00
}