mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-28 10:38:45 +00:00
Code Issues Releases Wiki Activity
transmission/qt/RelocateDialog.cc

97 lines
2.4 KiB
C++
Raw Normal View History

(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
/*
Use PascalCase for Qt client filenames Split FileTree.{h,cc} and FilterBar.{h,cc} files so that each class is in its own file. This breaks translations (some classes got renamed => context changed), to be fixed by next commit (along with Tx sync).
2015-06-10 21:27:11 +00:00
* This file Copyright (C) 2009-2015 Mnemosyne LLC
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
*
Fix license wording in Qt client .cc files to match the rest of the code.
2014-12-21 23:49:39 +00:00
* It may be used under the GNU GPL versions 2 or 3
Licensing changes: 1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed 2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :) 3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
* or any future license endorsed by Mnemosyne LLC.
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
*
*/
(trunk qt) minor cleanup
2009-10-06 00:27:26 +00:00
#include <QDir>
Rework relocate dialog in Qt client to load from .ui
2014-12-26 10:35:00 +00:00
Use PascalCase for Qt client filenames Split FileTree.{h,cc} and FilterBar.{h,cc} files so that each class is in its own file. This breaks translations (some classes got renamed => context changed), to be fixed by next commit (along with Tx sync).
2015-06-10 21:27:11 +00:00
#include "RelocateDialog.h"
#include "Session.h"
#include "Torrent.h"
#include "TorrentModel.h"
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
Strip spaces around :: in C++ code (Qt client)
2014-12-12 23:05:10 +00:00
bool RelocateDialog::myMoveFlag = true;
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void RelocateDialog::onSetLocation()
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
mySession.torrentSetLocation(myIds, newLocation(), myMoveFlag);
close();
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
void RelocateDialog::onMoveToggled(bool b)
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
myMoveFlag = b;
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
}
qt client speedups * faster updating of trackers combobox. * generate trackerDisplayNames just once per torrent * refactor: cache torrent delegate's warning emblem * refactor: change mainwin refresh debounce to 200ms * refactor: do not store trackers, hosts in QVariant * refactor: don't use `virtual` when it's not needed * refactor: faster counting torrents-matching-filter * refactor: faster tracker handling in filterbar * refactor: improve json parser's prealloc heuristic * refactor: make Torrent::hasError() faster * refactor: remove redundant speed stats collection * refactor: remove unnecessary tor->isQueued() calls * refactor: use unordered containers where possible * scale favicons only once, when adding to the cache
2019-11-12 01:37:05 +00:00
RelocateDialog::RelocateDialog(Session& session, TorrentModel const& model, torrent_ids_t const& ids, QWidget* parent) :
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
BaseDialog(parent),
mySession(session),
myIds(ids)
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.setupUi(this);
(qt) copyediting: whitespace/indentation
2013-02-03 19:40:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QString path;
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
for (int const id : myIds)
(qt) copyediting: whitespace/indentation
2013-02-03 19:40:20 +00:00
{
Align type qualifiers to the right (code style) This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading types right-to-left, e.g. "constant pointer to constant T" vs. "constant pointer to T which is constant".
2017-04-20 16:02:19 +00:00
Torrent const* tor = model.getTorrentFromId(id);
(qt) copyediting: whitespace/indentation
2013-02-03 19:40:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (path.isEmpty())
(qt) copyediting: whitespace/indentation
2013-02-03 19:40:20 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
path = tor->getPath();
(qt) copyediting: whitespace/indentation
2013-02-03 19:40:20 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else if (path != tor->getPath())
(qt) #3255: Don't use filebrowser in remote sessions
2010-06-04 01:00:27 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (mySession.isServer())
{
path = QDir::homePath();
}
else
{
path = QDir::rootPath();
}
break;
(qt) #3255: Don't use filebrowser in remote sessions
2010-06-04 01:00:27 +00:00
}
}
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (mySession.isServer())
Make use of path button in relocate dialog (Qt client)
2015-01-01 05:02:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.newLocationStack->setCurrentWidget(ui.newLocationButton);
ui.newLocationButton->setMode(PathButton::DirectoryMode);
ui.newLocationButton->setTitle(tr("Select Location"));
ui.newLocationButton->setPath(path);
Make use of path button in relocate dialog (Qt client)
2015-01-01 05:02:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
else
Make use of path button in relocate dialog (Qt client)
2015-01-01 05:02:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.newLocationStack->setCurrentWidget(ui.newLocationEdit);
ui.newLocationEdit->setText(path);
ui.newLocationEdit->selectAll();
Make use of path button in relocate dialog (Qt client)
2015-01-01 05:02:13 +00:00
}
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
ui.newLocationStack->setFixedHeight(ui.newLocationStack->currentWidget()->sizeHint().height());
ui.newLocationLabel->setBuddy(ui.newLocationStack->currentWidget());
(qt) copyediting: whitespace/indentation
2013-02-03 19:40:20 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
if (myMoveFlag)
{
ui.moveDataRadio->setChecked(true);
}
else
{
ui.findDataRadio->setChecked(true);
}
Rework relocate dialog in Qt client to load from .ui
2014-12-26 10:35:00 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
connect(ui.moveDataRadio, SIGNAL(toggled(bool)), this, SLOT(onMoveToggled(bool)));
connect(ui.dialogButtons, SIGNAL(rejected()), this, SLOT(close()));
connect(ui.dialogButtons, SIGNAL(accepted()), this, SLOT(onSetLocation()));
Make use of path button in relocate dialog (Qt client)
2015-01-01 05:02:13 +00:00
}
Rework relocate dialog in Qt client to load from .ui
2014-12-26 10:35:00 +00:00
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
QString RelocateDialog::newLocation() const
Make use of path button in relocate dialog (Qt client)
2015-01-01 05:02:13 +00:00
{
Adjust uncrustify config, reformat all but Mac client There're places where manual intervention is still required as uncrustify is not ideal (unfortunately), but at least one may rely on it to do the right thing most of the time (e.g. when sending in a patch). The style itself is quite different from what we had before but making it uniform across all the codebase is the key. I also hope that it'll make the code more readable (YMMV) and less sensitive to further changes.
2017-04-19 12:04:45 +00:00
return ui.newLocationStack->currentWidget() == ui.newLocationButton ? ui.newLocationButton->path() :
Update to Uncrustify 0.68.1 Tweak a few rules in the process. Now all code in cli, daemon, gtk, libtransmission, qt, and utils is properly formatted with no manual intervention.
2019-02-10 11:05:16 +00:00
ui.newLocationEdit->text();
(trunk) #920: add "move data" to libT so all clients can use it
2009-05-13 15:54:04 +00:00
}
Reference in a new issue Copy permalink