From 01ffcd5dcfd69e2a88604097ffa90bdea306a3af Mon Sep 17 00:00:00 2001 From: Will Thompson Date: Thu, 30 Nov 2017 16:41:39 +0000 Subject: [PATCH] gtk: add symbolic icon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The -symbolic icon variant (if available) is used in the GNOME top bar, and when the high contrast theme is in use. This icon was created by Jakub Steiner, and comes from the gnome-icons repository: https://github.com/gnome-design-team/gnome-icons/blob/master/apps-symbolic/Adwaita/scalable/apps/transmission-symbolic.svg https://bugzilla.redhat.com/show_bug.cgi?id=1221292 There is some confusion over whether symbolic app icons should be installed to icons/hicolor/scalable/apps (alongside the regular scalable icon) or to icons/hicolor/symbolic/apps. On the one hand, https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons has this to say: > […] obtain a suitable symbolic style icon […] and install it to the > hicolor prefix, the same way you would for the full color variant. > > cp myapp-symbolic.svg /usr/share/icons/hicolor/scalable/apps/myapp-symbolic.svg On the other hand, the Fedora package at https://src.fedoraproject.org/rpms/transmission/blob/master/f/transmission.spec ships this icon in icons/hicolor/symbolic/apps: > # Install the symbolic icon > mkdir -p %{buildroot}%{_datadir}/icons/hicolor/symbolic/apps > cp %{SOURCE1} %{buildroot}%{_datadir}/icons/hicolor/symbolic/apps/transmission-symbolic.svg Anecdotally, icons in scalable/ have minimum size 64×64 on openSUSE, so symbolic/ is the safer location (given the GNOME top bar uses 32×32 icons). This has the advantage of matching the location used in the distribution which already ships this file. https://github.com/transmission/transmission/issues/414 --- gtk/CMakeLists.txt | 1 + gtk/icons/Makefile.am | 1 + ...or_apps_symbolic_transmission-symbolic.svg | 26 +++++++++++++++++++ 3 files changed, 28 insertions(+) create mode 100644 gtk/icons/hicolor_apps_symbolic_transmission-symbolic.svg diff --git a/gtk/CMakeLists.txt b/gtk/CMakeLists.txt index f4193d6b5..18091c01b 100644 --- a/gtk/CMakeLists.txt +++ b/gtk/CMakeLists.txt @@ -183,6 +183,7 @@ set(${PROJECT_NAME}_PUBLIC_ICONS hicolor_apps_48x48_transmission.png hicolor_apps_256x256_transmission.png hicolor_apps_scalable_transmission.svg + hicolor_apps_symbolic_transmission-symbolic.svg ) set(ICON_NAME_REGEX "^([^_]+)_([^_]+)_([^_]+)_(.+)$") diff --git a/gtk/icons/Makefile.am b/gtk/icons/Makefile.am index 989d69394..88f784c52 100644 --- a/gtk/icons/Makefile.am +++ b/gtk/icons/Makefile.am @@ -12,6 +12,7 @@ public_icons = \ hicolor_apps_48x48_transmission.png \ hicolor_apps_256x256_transmission.png \ hicolor_apps_scalable_transmission.svg \ + hicolor_apps_symbolic_transmission-symbolic.svg \ $(NULL) private_icons = \ diff --git a/gtk/icons/hicolor_apps_symbolic_transmission-symbolic.svg b/gtk/icons/hicolor_apps_symbolic_transmission-symbolic.svg new file mode 100644 index 000000000..474dec021 --- /dev/null +++ b/gtk/icons/hicolor_apps_symbolic_transmission-symbolic.svg @@ -0,0 +1,26 @@ + + + + + + + + image/svg+xml + + Gnome Symbolic Icon Theme + + + + + + + Gnome Symbolic Icon Theme + + + + + + + + +