From 03ffe42ad4a4542627ac2e9ebf52cab377c19a54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C5=93ur?= Date: Sun, 30 Jul 2023 03:57:43 +0200 Subject: [PATCH] fix: -fobjc-arc with GCC (#5632) --- libtransmission/CMakeLists.txt | 6 +++--- libtransmission/utils.cc | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libtransmission/CMakeLists.txt b/libtransmission/CMakeLists.txt index 4476b1628..8648a1911 100644 --- a/libtransmission/CMakeLists.txt +++ b/libtransmission/CMakeLists.txt @@ -12,7 +12,7 @@ check_symbol_exists(SO_REUSEPORT "sys/types.h;sys/socket.h" HAVE_SO_REUSEPORT) add_compile_options( # equivalent of XCODE_ATTRIBUTE_CLANG_ENABLE_OBJC_ARC YES for this directory - $<$,$>:-fobjc-arc>) + $<$,$,$>:-fobjc-arc>) add_library(${TR_NAME} STATIC) @@ -201,10 +201,10 @@ tr_allow_compile_if( watchdir-inotify.cc [=[[WITH_KQUEUE]]=] watchdir-kqueue.cc - [=[[APPLE]]=] + [=[[APPLE AND CMAKE_CXX_COMPILER_ID MATCHES "Clang"]]=] tr-assert.mm utils.mm - [=[[NOT APPLE]]=] + [=[[NOT (APPLE AND CMAKE_CXX_COMPILER_ID MATCHES "Clang")]]=] tr-assert.cc [=[[WIN32]]=] file-win32.cc diff --git a/libtransmission/utils.cc b/libtransmission/utils.cc index e207d62d6..ddf8dfacc 100644 --- a/libtransmission/utils.cc +++ b/libtransmission/utils.cc @@ -287,7 +287,7 @@ double tr_getRatio(uint64_t numerator, uint64_t denominator) // --- -#ifndef __APPLE__ +#if !(defined(__APPLE__) && defined(__clang__)) std::string tr_strv_convert_utf8(std::string_view sv) {