mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

fixup: heap-use-after-free in announce, scrape response on shutdown (#4228) 

fixes #4222.
This commit is contained in:
Charles Kerr 2022-11-23 01:38:31 -06:00 committed by GitHub
parent a8f2b840f7
commit 046ba32d33
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
libtransmission/announcer.cc
View File

@ -1192,8 +1192,13 @@ static void tierAnnounce(tr_announcer_impl* announcer, tr_tier* tier)
announcer->announce(
req,
[announcer, tier_id, event, is_running_on_success](tr_announce_response const& response)
{ announcer->onAnnounceDone(tier_id, event, is_running_on_success, response); });
[session = announcer->session, announcer, tier_id, event, is_running_on_success](tr_announce_response const& response)
{
if (session->announcer_)
{
announcer->onAnnounceDone(tier_id, event, is_running_on_success, response);
}
});
}
/***
@ -1435,7 +1440,15 @@ static void multiscrape(tr_announcer_impl* announcer, std::vector<tr_tier*> cons
/* send the requests we just built */
for (size_t i = 0; i < request_count; ++i)
{
announcer->scrape(requests[i], [announcer](tr_scrape_response const& response) { announcer->onScrapeDone(response); });
announcer->scrape(
requests[i],
[session = announcer->session, announcer](tr_scrape_response const& response)
{
if (session->announcer_)
{
announcer->onScrapeDone(response);
}
});
}
}