mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-03-12 23:23:54 +00:00
Code Issues Releases Wiki Activity

perf: cache curl version (#7461)

Browse source 
it doesn't change during runtime, so no need to
keep calling curl_version_info(CURLVERSION_NOW)
This commit is contained in:
Charles Kerr 2025-03-04 08:16:21 -06:00 • committed by GitHub
parent 76ab7ba592
commit 05797a9e93
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
libtransmission/web.cc
View file

@ -171,7 +171,7 @@ public:
explicit Impl(Mediator& mediator_in)
: mediator{ mediator_in }
{
auto const curl_version_num = curl_version_info(CURLVERSION_NOW)->version_num;
auto const curl_version_num = get_curl_version();
if (curl_version_num == 0x080901)
{
tr_logAddWarn(_("Consider upgrading your curl installation."));
@ -402,18 +402,24 @@ public:
CURL* easy_;
};
[[nodiscard]] static unsigned int get_curl_version() noexcept
{
static auto const ver = curl_version_info(CURLVERSION_NOW)->version_num;
return ver;
}
// https://github.com/curl/curl/issues/10936
[[nodiscard]] static bool check_curl_gh10936() noexcept
{
auto const version = curl_version_info(CURLVERSION_NOW)->version_num;
return version >= 0x075700 /* 7.87.0 */ && version <= 0x080500 /* 8.5.0 */;
static bool const in_range = 0x075700 /* 7.87.0 */ <= get_curl_version() && get_curl_version() <= 0x080500 /* 8.5.0 */;
return in_range;
}
// https://github.com/curl/curl/issues/6312
[[nodiscard]] static bool check_curl_gh6312() noexcept
{
auto const version = curl_version_info(CURLVERSION_NOW)->version_num;
return version >= 0x074700 /* 7.71.0 */ && version <= 0x074a00 /* 7.74.0 */;
static bool const in_range = 0x074700 /* 7.71.0 */ <= get_curl_version() && get_curl_version() <= 0x074a00 /* 7.74.0 */;
return in_range;
}
static auto constexpr BandwidthPauseMsec = long{ 500 };