Don't pack PDBs on feature branches to reduce AppVeyor artifacts size (#1972)

appveyor.yml

@@ -62,7 +62,8 @@ for:
       try {
           & (Join-Path $Env:APPVEYOR_BUILD_FOLDER release windows main.ps1) `
               -Mode Build `
-              -BuildArch $env:TR_ARCH
+              -BuildArch $env:TR_ARCH `
+              -NoPackDebugSyms:$($Env:APPVEYOR_REPO_BRANCH -match "/")
       } catch {
           Write-Error ("{1}{0}{2}{0}{3}" -f [Environment]::NewLine, $_.ToString(), $_.InvocationInfo.PositionMessage, $_.ScriptStackTrace) -ErrorAction Continue
           exit 1

release/windows/build-transmission.ps1

@@ -1,6 +1,6 @@
 #!/usr/bin/env pwsh
 
-function global:Build-Transmission([string] $PrefixDir, [string] $Arch, [string] $DepsPrefixDir, [string] $SourceDir, [string] $ArtifactsDir) {
+function global:Build-Transmission([string] $PrefixDir, [string] $Arch, [string] $DepsPrefixDir, [string] $SourceDir, [string] $ArtifactsDir, [boolean] $NoPackDebugSyms) {
     $BuildDir = Join-Path $SourceDir .build
 
     $env:PATH = @(
@@ -64,7 +64,10 @@ function global:Build-Transmission([string] $PrefixDir, [string] $Arch, [string]
     New-Item -Path $ArtifactsDir -ItemType Directory -ErrorAction Ignore | Out-Null
     $MsiPackage = (Get-ChildItem (Join-Path $BuildDir dist msi 'transmission-*.msi'))[0]
     Move-Item -Path $MsiPackage.FullName -Destination $ArtifactsDir
-    Invoke-NativeCommand cmake -E chdir $DebugSymbolsDir 7z a -y (Join-Path $ArtifactsDir "$($MsiPackage.BaseName)-pdb.7z")
+
+    if (-not $NoPackDebugSyms) {
+        Invoke-NativeCommand cmake -E chdir $DebugSymbolsDir 7z a -y (Join-Path $ArtifactsDir "$($MsiPackage.BaseName)-pdb.7z")
+    }
 }
 
 function global:Test-Transmission([string] $DepsPrefixDir, [string] $SourceDir) {

release/windows/main.ps1

@@ -16,7 +16,10 @@ Param(
     [string] $RootDir,
 
     [Parameter()]
-    [string] $ScriptBaseUrl
+    [string] $ScriptBaseUrl,
+
+    [Parameter()]
+    [switch] $NoPackDebugSyms
 )
 
 Set-StrictMode -Version '6.0'
@@ -247,7 +250,7 @@ if ($Mode -eq 'Build') {
     Invoke-Build Curl
     Invoke-Build Qt
 
-    Invoke-Build Transmission -NoCache -MoreArguments @($SourceDir, $SourceDir)
+    Invoke-Build Transmission -NoCache -MoreArguments @($SourceDir, $SourceDir, $NoPackDebugSyms.IsPresent)
 }
 
 if ($Mode -eq 'Test') {