mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-01-01 12:35:22 +00:00
Code Issues Releases Wiki Activity

Fix up rename test to avoid random use-after-free failures

Browse source
This commit is contained in:
Mike Gelfand 2016-12-25 19:44:38 +03:00
parent 3cda09ea81
commit 0ac657c5f1
1 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
libtransmission/rename-test.c
View file

@ -84,6 +84,16 @@ torrentRenameAndWait (tr_torrent * tor,
return error;
}
static void
torrentRemoveAndWait (tr_torrent * tor,
int expected_torrent_count)
{
tr_torrentRemove (tor, false, NULL);
while (tr_sessionCountTorrents (session) != expected_torrent_count)
tr_wait_msec (10);
}
/***
****
***/
@ -221,7 +231,7 @@ test_single_filename_torrent (void)
/* cleanup */
tr_ctorFree (ctor);
tr_torrentRemove (tor, false, NULL);
torrentRemoveAndWait (tor, 0);
return 0;
}
@ -436,13 +446,7 @@ test_multifile_torrent (void)
}
tr_ctorFree (ctor);
tr_torrentRemove (tor, false, NULL);
do
{
tr_wait_msec (10);
}
while (tr_sessionCountTorrents (session) > 0);
torrentRemoveAndWait (tor, 0);
/**
*** Test renaming prefixes (shouldn't work)
@ -483,7 +487,7 @@ test_multifile_torrent (void)
/* cleanup */
tr_ctorFree (ctor);
tr_torrentRemove (tor, false, NULL);
torrentRemoveAndWait (tor, 0);
return 0;
}
@ -550,7 +554,7 @@ test_partial_file (void)
tr_free (expected);
}
tr_torrentRemove (tor, false, NULL);
torrentRemoveAndWait (tor, 0);
return 0;
}