mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-25 01:03:01 +00:00
Code Issues Releases Wiki Activity

gracefully fail when poison torrents containing no files, or zero byte files, are opened.

Browse source
This commit is contained in:
Charles Kerr 2007-07-27 01:50:26 +00:00
parent 815c6bfe1f
commit 0e6f766a57
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
libtransmission/metainfo.c
View file

@ -253,8 +253,6 @@ realparse( tr_info_t * inf, const uint8_t * buf, size_t size )
memcpy (inf->pieces[i].hash, &val->val.s.s[i*SHA_DIGEST_LENGTH], SHA_DIGEST_LENGTH);
}
/* TODO add more tests so we don't crash on weird files */
/* get file or top directory name */
val = tr_bencDictFindFirst( beInfo, "name.utf-8", "name", NULL );
if( parseFiles( inf, tr_bencDictFindFirst( beInfo,
@ -265,6 +263,22 @@ realparse( tr_info_t * inf, const uint8_t * buf, size_t size )
goto fail;
}
if( !inf->fileCount )
{
tr_err( "Torrent has no files." );
goto fail;
}
for( i=0; i<inf->fileCount; ++i )
{
if( !inf->files[i].length )
{
tr_err("File #%d, \"%s\" is zero bytes long.", (i+1), inf->files[i].name );
goto fail;
}
}
/* TODO add more tests so we don't crash on weird files */
if( (uint64_t) inf->pieceCount !=
( inf->totalSize + inf->pieceSize - 1 ) / inf->pieceSize )
{