refactor: iwyu (#3525)

2022-07-25 21:45:54 -05:00 · 2022-07-25 21:45:54 -05:00 · 1a0afbe95e
parent d09aba0e6a
commit 1a0afbe95e
44 changed files with 37 additions and 19 deletions
--- a/gtk/Dialogs.cc
+++ b/gtk/Dialogs.cc
@ -2,8 +2,8 @@
 // It may be used under the MIT (SPDX: MIT) license.
 // License text can be found in the licenses/ folder.

-#include <algorithm>
 #include <memory>
+#include <vector>

 #include <glibmm.h>
 #include <glibmm/i18n.h>
--- a/gtk/FaviconCache.cc
+++ b/gtk/FaviconCache.cc
@ -4,6 +4,7 @@
 // License text can be found in the licenses/ folder.

 #include <array>
+#include <functional>
 #include <memory>
 #include <string>

--- a/gtk/FileList.cc
+++ b/gtk/FileList.cc
@ -3,13 +3,14 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm>
 #include <climits> /* INT_MAX */
 #include <cstddef>
 #include <cstring> // strchr
-#include <functional>
-#include <unordered_map>
+#include <list>
 #include <string>
 #include <string_view>
+#include <unordered_map>
 #include <utility>

 #include <glibmm.h>
--- a/gtk/FilterBar.cc
+++ b/gtk/FilterBar.cc
@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm> // std::transform()
 #include <memory>
 #include <set>
 #include <string>
--- a/gtk/FreeSpaceLabel.cc
+++ b/gtk/FreeSpaceLabel.cc
@ -5,6 +5,7 @@

 #include <memory>
 #include <string>
+#include <string_view>

 #include <glibmm/i18n.h>

--- a/gtk/IconCache.cc
+++ b/gtk/IconCache.cc
@ -5,6 +5,7 @@
 *
 */

+#include <algorithm>
 #include <array>
 #include <map>
 #include <memory>
--- a/gtk/MakeDialog.cc
+++ b/gtk/MakeDialog.cc
@ -4,6 +4,7 @@
 // License text can be found in the licenses/ folder.

 #include <iostream>
+#include <list>
 #include <memory>
 #include <string>

@ -560,4 +561,4 @@ void MakeDialog::Impl::onPieceSizeUpdated()
        tr_metaInfoBuilderSetPieceSize(builder_.get(), new_size);
        updatePiecesLabel();
    }
-}
+}
--- a/gtk/Notify.cc
+++ b/gtk/Notify.cc
@ -4,6 +4,7 @@
 // License text can be found in the licenses/ folder.

 #include <map>
+#include <vector>

 #include <giomm.h>
 #include <glibmm/i18n.h>
--- a/gtk/OptionsDialog.cc
+++ b/gtk/OptionsDialog.cc
@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <list>
 #include <memory>

 #include <glibmm.h>
--- a/gtk/RelocateDialog.cc
+++ b/gtk/RelocateDialog.cc
@ -3,7 +3,6 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

-#include <algorithm>
 #include <memory>
 #include <string>

--- a/gtk/TorrentCellRenderer.cc
+++ b/gtk/TorrentCellRenderer.cc
@ -3,11 +3,13 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm> // std::max()
 #include <climits> /* INT_MAX */
 #include <cstring> // strchr()
 #include <memory>
 #include <optional>
 #include <string>
+#include <string_view>

 #include <glibmm.h>
 #include <glibmm/i18n.h>
--- a/gtk/Utils.cc
+++ b/gtk/Utils.cc
@ -6,6 +6,7 @@
 #include <array>
 #include <ctype.h> /* isxdigit() */
 #include <errno.h>
+#include <functional>
 #include <limits.h> /* INT_MAX */

 #include <giomm.h> /* g_file_trash() */
--- a/libtransmission/announcer-http.cc
+++ b/libtransmission/announcer-http.cc
@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm> // std::copy_n()
 #include <climits> /* USHRT_MAX */
 #include <cstdio> /* fprintf() */
 #include <cstring> /* strchr(), memcmp(), memcpy() */
--- a/libtransmission/announcer-udp.cc
+++ b/libtransmission/announcer-udp.cc
@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm> // std::find_if()
 #include <cerrno> /* errno, EAFNOSUPPORT */
 #include <cstring> /* memset() */
 #include <ctime>
--- a/libtransmission/blocklist.cc
+++ b/libtransmission/blocklist.cc
@ -8,6 +8,7 @@
 #include <cstdio>
 #include <cstring>
 #include <string_view>
+#include <vector>

 #include <fmt/core.h>

--- a/libtransmission/cache.cc
+++ b/libtransmission/cache.cc
@ -8,6 +8,7 @@
 #include <limits> // std::numeric_limits<size_t>::max()
 #include <numeric> // std::accumulate()
 #include <utility> // std::make_pair()
+#include <vector>

 #include <event2/buffer.h>

--- a/libtransmission/cache.h
+++ b/libtransmission/cache.h
@ -10,6 +10,7 @@
 #endif

 #include <cstdint> // intX_t, uintX_t
+#include <ctime>
 #include <memory> // std::unique_ptr
 #include <utility> // std::pair
 #include <vector>
--- a/libtransmission/crypto-utils.cc
+++ b/libtransmission/crypto-utils.cc
@ -11,6 +11,7 @@
 #include <random>
 #include <string>
 #include <string_view>
+#include <vector>

 #include <arc4.h>

--- a/libtransmission/open-files.cc
+++ b/libtransmission/open-files.cc
@ -7,6 +7,7 @@
 #include <array>
 #include <cerrno>
 #include <cstdint> // uint8_t, uint64_t
+#include <string_view>

 #include <fmt/core.h>

--- a/libtransmission/open-files.h
+++ b/libtransmission/open-files.h
@ -11,6 +11,7 @@

 #include <cstdint>
 #include <optional>
+#include <string_view>
 #include <utility>

 #include "transmission.h"
--- a/libtransmission/peer-mgr-active-requests.cc
+++ b/libtransmission/peer-mgr-active-requests.cc
@ -5,9 +5,7 @@

 #include <algorithm>
 #include <ctime>
-#include <functional>
 #include <memory>
-#include <numeric>
 #include <utility>
 #include <unordered_map>
 #include <unordered_set>
--- a/libtransmission/peer-mgr-wishlist.cc
+++ b/libtransmission/peer-mgr-wishlist.cc
@ -6,7 +6,6 @@
 #include <algorithm>
 #include <cstddef>
 #include <iterator>
-#include <numeric>
 #include <set>
 #include <utility>
 #include <vector>
--- a/libtransmission/peer-mgr.h
+++ b/libtransmission/peer-mgr.h
@ -9,11 +9,9 @@
 #error only libtransmission should #include this header.
 #endif

-#include <array>
 #include <cstddef> // size_t
 #include <cstdint> // uint8_t, uint64_t
 #include <string>
-#include <string_view>
 #include <vector>

 #ifdef _WIN32
--- a/libtransmission/peer-mse.h
+++ b/libtransmission/peer-mse.h
@ -11,6 +11,7 @@
 #error only libtransmission should #include this header.
 #endif

+#include <array>
 #include <cstddef> // size_t, std::byte
 #include <memory>

--- a/libtransmission/rpc-server.cc
+++ b/libtransmission/rpc-server.cc
@ -8,7 +8,6 @@
 #include <cerrno>
 #include <cstring> /* memcpy */
 #include <ctime>
-#include <list>
 #include <string>
 #include <string_view>
 #include <vector>
--- a/libtransmission/session.cc
+++ b/libtransmission/session.cc
@ -16,7 +16,6 @@
 #include <numeric> // std::accumulate()
 #include <string>
 #include <string_view>
-#include <tuple>
 #include <unordered_set>
 #include <vector>

--- a/libtransmission/torrent-files.cc
+++ b/libtransmission/torrent-files.cc
@ -3,6 +3,8 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm> // std::find()
+#include <functional>
 #include <iterator>
 #include <optional>
 #include <set>
--- a/libtransmission/torrent-files.h
+++ b/libtransmission/torrent-files.h
@ -13,6 +13,7 @@
 #include <optional>
 #include <string>
 #include <string_view>
+#include <utility>
 #include <vector>

 #include "transmission.h"
--- a/libtransmission/torrent-metainfo.cc
+++ b/libtransmission/torrent-metainfo.cc
@ -6,7 +6,6 @@
 #include <algorithm>
 #include <array>
 #include <cctype>
-#include <numeric>
 #include <string>
 #include <string_view>
 #include <vector>
--- a/libtransmission/tr-assert.cc
+++ b/libtransmission/tr-assert.cc
@ -6,6 +6,7 @@
 #include <cstdio>
 #include <cstdlib>
 #include <iostream>
+#include <string_view>

 #include "tr-assert.h"

--- a/libtransmission/tr-lpd.cc
+++ b/libtransmission/tr-lpd.cc
@ -6,7 +6,6 @@
 #include <cerrno>
 #include <csignal> /* sig_atomic_t */
 #include <cstring> /* strlen(), strncpy(), strstr(), memset() */
-#include <string_view>
 #include <type_traits>

 #ifdef _WIN32
--- a/libtransmission/variant-json.cc
+++ b/libtransmission/variant-json.cc
@ -10,6 +10,7 @@
 #include <cstring>
 #include <deque>
 #include <string_view>
+#include <utility>

 #define UTF_CPP_CPLUSPLUS 201703L
 #include <utf8.h>
--- a/libtransmission/web.cc
+++ b/libtransmission/web.cc
@ -10,7 +10,6 @@
 #include <memory>
 #include <mutex>
 #include <string>
-#include <string_view>
 #include <thread>

 #ifdef _WIN32
--- a/libtransmission/webseed.cc
+++ b/libtransmission/webseed.cc
@ -10,6 +10,7 @@
 #include <set>
 #include <string>
 #include <string_view>
+#include <vector>

 #include <event2/buffer.h>
 #include <event2/event.h>
--- a/qt/Application.cc
+++ b/qt/Application.cc
@ -9,6 +9,7 @@
 #include <array>
 #include <ctime>
 #include <memory>
+#include <utility>

 #include <QIcon>
 #include <QLibraryInfo>
--- a/qt/MainWindow.cc
+++ b/qt/MainWindow.cc
@ -5,7 +5,6 @@

 #include <array>
 #include <cassert>
-#include <functional>
 #include <memory>
 #include <utility>

--- a/qt/Prefs.cc
+++ b/qt/Prefs.cc
@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm>
 #include <array>
 #include <cassert>
 #include <cstdlib>
--- a/qt/Torrent.cc
+++ b/qt/Torrent.cc
@ -4,7 +4,6 @@
 // License text can be found in the licenses/ folder.

 #include <algorithm>
-#include <cassert>
 #include <iterator>
 #include <set>

--- a/qt/TorrentFilter.cc
+++ b/qt/TorrentFilter.cc
@ -3,7 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

-#include <algorithm>
+#include <array>
 #include <optional>

 #include "Filters.h"
--- a/qt/TorrentModel.cc
+++ b/qt/TorrentModel.cc
@ -6,7 +6,6 @@
 #include <algorithm>
 #include <cassert>
 #include <string_view>
-#include <utility>

 #include <libtransmission/transmission.h>
 #include <libtransmission/variant.h>
--- a/tests/libtransmission/clients-test.cc
+++ b/tests/libtransmission/clients-test.cc
@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm>
 #include <array>
 #include <string_view>

--- a/tests/libtransmission/completion-test.cc
+++ b/tests/libtransmission/completion-test.cc
@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm>
 #include <array>
 #include <cstdint>
 #include <set>
--- a/tests/libtransmission/crypto-test.cc
+++ b/tests/libtransmission/crypto-test.cc
@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm>
 #include <array>
 #include <cstring>
 #include <iostream>
--- a/tests/libtransmission/handshake-test.cc
+++ b/tests/libtransmission/handshake-test.cc
@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.

+#include <algorithm>
 #include <array>
 #include <cassert>
 #include <cstring>