mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

(trunk gtk) more heap pruning: minor GtkTreeModel changes 

Use gtk_tree_model_iter_nth_child() instead of gtk_tree_model_get_iter_first() to avoid an unnecessary gtk_tree_path object being created and destroyed. This is a very minor change and I'm not sure how useful it really is, but it doesn't hurt.
This commit is contained in:
Jordan Lee 2011-04-13 22:00:55 +00:00
parent 01461d0b4a
commit 1d7a4eb528
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gtk/details.c
View File

@ -1270,7 +1270,7 @@ refreshPeerList( struct DetailsImpl * di, tr_torrent ** torrents, int n )
/* step 2: mark all the peers in the list as not-updated */
model = GTK_TREE_MODEL( store );
if( gtk_tree_model_get_iter_first( model, &iter ) ) do
if( gtk_tree_model_iter_nth_child( model, &iter, NULL, 0 ) ) do
gtk_list_store_set( store, &iter, PEER_COL_WAS_UPDATED, FALSE, -1 );
while( gtk_tree_model_iter_next( model, &iter ) );
@ -1314,7 +1314,7 @@ refreshPeerList( struct DetailsImpl * di, tr_torrent ** torrents, int n )
/* step 5: remove peers that have disappeared */
model = GTK_TREE_MODEL( store );
if( gtk_tree_model_get_iter_first( model, &iter ) ) {
if( gtk_tree_model_iter_nth_child( model, &iter, NULL, 0 ) ) {
gboolean more = TRUE;
while( more ) {
gboolean b;
@ -1349,7 +1349,7 @@ refreshWebseedList( struct DetailsImpl * di, tr_torrent ** torrents, int n )
GtkTreeModel * model = GTK_TREE_MODEL( store );
/* step 1: mark all webseeds as not-updated */
if( gtk_tree_model_get_iter_first( model, &iter ) ) do
if( gtk_tree_model_iter_nth_child( model, &iter, NULL, 0 ) ) do
gtk_list_store_set( store, &iter, WEBSEED_COL_WAS_UPDATED, FALSE, -1 );
while( gtk_tree_model_iter_next( model, &iter ) );
@ -1408,7 +1408,7 @@ refreshWebseedList( struct DetailsImpl * di, tr_torrent ** torrents, int n )
}
/* step 4: remove webseeds that have disappeared */
if( gtk_tree_model_get_iter_first( model, &iter ) ) {
if( gtk_tree_model_iter_nth_child( model, &iter, NULL, 0 ) ) {
gboolean more = TRUE;
while( more ) {
gboolean b;
@ -1983,7 +1983,7 @@ refreshTracker( struct DetailsImpl * di, tr_torrent ** torrents, int n )
/* step 2: mark all the trackers in the list as not-updated */
model = GTK_TREE_MODEL( store );
if( gtk_tree_model_get_iter_first( model, &iter ) ) do
if( gtk_tree_model_iter_nth_child( model, &iter, NULL, 0 ) ) do
gtk_list_store_set( store, &iter, TRACKER_COL_WAS_UPDATED, FALSE, -1 );
while( gtk_tree_model_iter_next( model, &iter ) );
@ -2055,7 +2055,7 @@ refreshTracker( struct DetailsImpl * di, tr_torrent ** torrents, int n )
}
/* step 5: remove trackers that have disappeared */
if( gtk_tree_model_get_iter_first( model, &iter ) ) {
if( gtk_tree_model_iter_nth_child( model, &iter, NULL, 0 ) ) {
gboolean more = TRUE;
while( more ) {
gboolean b;

2
gtk/file-list.c
View File

@ -236,7 +236,7 @@ gtr_tree_model_foreach_postorder( GtkTreeModel * model,
gpointer data )
{
GtkTreeIter iter;
if( gtk_tree_model_get_iter_first( model, &iter ) ) do
if( gtk_tree_model_iter_nth_child( model, &iter, NULL, 0 ) ) do
gtr_tree_model_foreach_postorder_subtree( model, &iter, func, data );
while( gtk_tree_model_iter_next( model, &iter ) );
}

2
gtk/tr-window.c
View File

@ -819,7 +819,7 @@ updateSpeeds( PrivateData * p )
GtkTreeIter iter;
GtkTreeModel * model = gtr_core_model( p->core );
if( gtk_tree_model_get_iter_first( model, &iter ) ) do
if( gtk_tree_model_iter_nth_child( model, &iter, NULL, 0 ) ) do
{
double u, d;
gtk_tree_model_get( model, &iter, MC_SPEED_UP, &u,