mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-02-13 18:04:43 +00:00
Code Issues Releases Wiki Activity

(trunk gtk) #3866 "Popup menu for file list manipulation" -- removing from the 2.20 milestone

Browse source 
Looking over the 2.20 tickets, this one keeps sticking out. A popup menu may be useful if the "delete files" ticket is accepted in 2.30, but for this release (2.20) it doesn't really add anything new. One lesson from the 2.1x cycle was that features are a harder to remove than to add. So I'm going to hold off on adding this feature until it has a clear raison d'être.
This commit is contained in:
Jordan Lee 2011-02-06 18:50:35 +00:00
parent b2a7f130ee
commit 24b9dc7dc2
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
gtk/file-list.c
View file

@ -680,6 +680,7 @@ onRowActivated( GtkTreeView * view, GtkTreePath * path,
return handled; return handled;
} }
#if 0
static void static void
fileMenuSetDownload( GtkWidget * item, gpointer gdata ) fileMenuSetDownload( GtkWidget * item, gpointer gdata )
{ {
@ -771,6 +772,7 @@ fileMenuPopup( GtkWidget * w, GdkEventButton * event, gpointer filedata )
event ? event->button : 0, event ? event->button : 0,
event ? event->time : gtk_get_current_event_time( ) ); event ? event->time : gtk_get_current_event_time( ) );
} }
#endif
static gboolean static gboolean
onViewPathToggled( GtkTreeView * view, onViewPathToggled( GtkTreeView * view,
@ -877,6 +879,7 @@ onViewButtonPressed( GtkWidget * w, GdkEventButton * event, gpointer gdata )
{ {
handled = onViewPathToggled( treeview, col, path, data ); handled = onViewPathToggled( treeview, col, path, data );
} }
#if 0
else if( event->type == GDK_BUTTON_PRESS && event->button == 3 else if( event->type == GDK_BUTTON_PRESS && event->button == 3
&& getAndSelectEventPath( treeview, event, &col, &path ) ) && getAndSelectEventPath( treeview, event, &col, &path ) )
{ {
@ -887,17 +890,20 @@ onViewButtonPressed( GtkWidget * w, GdkEventButton * event, gpointer gdata )
handled = TRUE; handled = TRUE;
} }
} }
#endif
gtk_tree_path_free( path ); gtk_tree_path_free( path );
return handled; return handled;
} }
#if 0
static gboolean static gboolean
onViewPopupMenu( GtkWidget * w, gpointer gdata ) onViewPopupMenu( GtkWidget * w, gpointer gdata )
{ {
fileMenuPopup( w, NULL, gdata ); fileMenuPopup( w, NULL, gdata );
return TRUE; return TRUE;
} }
#endif
GtkWidget * GtkWidget *
gtr_file_list_new( TrCore * core, int torrentId ) gtr_file_list_new( TrCore * core, int torrentId )
@ -926,8 +932,10 @@ gtr_file_list_new( TrCore * core, int torrentId )
gtk_container_set_border_width( GTK_CONTAINER( view ), GUI_PAD_BIG ); gtk_container_set_border_width( GTK_CONTAINER( view ), GUI_PAD_BIG );
g_signal_connect( view, "button-press-event", g_signal_connect( view, "button-press-event",
G_CALLBACK( onViewButtonPressed ), data ); G_CALLBACK( onViewButtonPressed ), data );
#if 0
g_signal_connect( view, "popup-menu", g_signal_connect( view, "popup-menu",
G_CALLBACK( onViewPopupMenu ), data ); G_CALLBACK( onViewPopupMenu ), data );
#endif
g_signal_connect( view, "row_activated", g_signal_connect( view, "row_activated",
G_CALLBACK( onRowActivated ), data ); G_CALLBACK( onRowActivated ), data );
g_signal_connect( view, "button-release-event", g_signal_connect( view, "button-release-event",