chore: iwyu headers (#3661)

daemon/daemon.cc

@@ -8,9 +8,9 @@
 #include <cstdio> /* printf */
 #include <cstdlib> /* atoi */
 #include <iostream>
+#include <memory>
 #include <string>
 #include <string_view>
-#include <utility>
 
 #ifdef HAVE_SYSLOG
 #include <syslog.h>

gtk/Application.cc

@@ -5,10 +5,13 @@
 #include <algorithm>
 #include <cstdlib> // exit()
 #include <ctime>
+#include <iterator> // for std::back_inserter
 #include <map>
+#include <memory>
 #include <sstream>
 #include <string>
 #include <thread>
+#include <utility>
 #include <vector>
 
 #include <locale.h>

gtk/DetailsDialog.cc

@@ -6,6 +6,7 @@
 #include <algorithm>
 #include <array>
 #include <limits.h> /* INT_MAX */
+#include <memory>
 #include <numeric>
 #include <sstream>
 #include <stddef.h>

gtk/FileList.cc

@@ -7,6 +7,7 @@
 #include <climits> /* INT_MAX */
 #include <cstddef>
 #include <list>
+#include <memory>
 #include <string>
 #include <string_view>
 #include <unordered_map>

gtk/IconCache.cc

@@ -11,6 +11,7 @@
 #include <memory>
 #include <string>
 #include <string_view>
+#include <utility>
 
 #include <glibmm.h>
 #include <giomm.h>

gtk/MainWindow.cc

@@ -3,6 +3,7 @@
 // License text can be found in the licenses/ folder.
 
 #include <array>
+#include <memory>
 #include <string>
 
 #include <glibmm/i18n.h>

gtk/MakeDialog.cc

@@ -8,6 +8,7 @@
 #include <memory>
 #include <string>
 #include <string_view>
+#include <utility>
 
 #include <glibmm.h>
 #include <glibmm/i18n.h>

gtk/MessageLogWindow.cc

@@ -6,6 +6,7 @@
 #include <errno.h>
 #include <stdio.h>
 #include <map>
+#include <memory>
 
 #include <glibmm.h>
 #include <glibmm/i18n.h>

gtk/Notify.cc

@@ -4,6 +4,7 @@
 // License text can be found in the licenses/ folder.
 
 #include <map>
+#include <utility>
 #include <vector>
 
 #include <giomm.h>

gtk/OptionsDialog.cc

@@ -5,6 +5,7 @@
 
 #include <list>
 #include <memory>
+#include <utility>
 
 #include <glibmm.h>
 #include <glibmm/i18n.h>

gtk/Prefs.cc

@@ -3,7 +3,6 @@
 // License text can be found in the licenses/ folder.
 
 #include <errno.h>
-#include <stdlib.h> /* strtol() */
 #include <string>
 #include <string_view>
 

gtk/PrefsDialog.cc

@@ -4,6 +4,7 @@
 // License text can be found in the licenses/ folder.
 
 #include <climits> /* USHRT_MAX, INT_MAX */
+#include <memory>
 #include <sstream>
 #include <string>
 

gtk/Session.cc

@@ -12,6 +12,7 @@
 #include <memory>
 #include <string>
 #include <string_view>
+#include <utility>
 
 #include <glibmm/i18n.h>
 

gtk/SystemTrayIcon.cc

@@ -8,6 +8,7 @@
 // We're using deprecated Gtk::StatusItem ourselves as well
 #undef GTKMM_DISABLE_DEPRECATED
 
+#include <memory>
 #include <string>
 
 #include <glibmm.h>

gtk/Utils.cc

@@ -8,6 +8,8 @@
 #include <errno.h>
 #include <functional>
 #include <limits.h> /* INT_MAX */
+#include <memory>
+#include <utility>
 
 #include <giomm.h> /* g_file_trash() */
 #include <glibmm/i18n.h>

gtk/Utils.h

@@ -9,6 +9,7 @@
 #include <ctime>
 #include <functional>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include <sys/types.h>

libtransmission/announce-list.cc

@@ -4,7 +4,6 @@
 // License text can be found in the licenses/ folder.
 
 #include <algorithm>
-#include <set>
 #include <string>
 #include <string_view>
 

libtransmission/announcer-http.cc

@@ -11,6 +11,7 @@
 #include <optional>
 #include <string>
 #include <string_view>
+#include <utility>
 
 #include <curl/curl.h>
 

libtransmission/announcer.cc

@@ -12,6 +12,7 @@
 #include <deque>
 #include <iterator>
 #include <map>
+#include <memory>
 #include <numeric>
 #include <set>
 #include <string>

libtransmission/blocklist.cc

@@ -4,7 +4,6 @@
 // License text can be found in the licenses/ folder.
 
 #include <algorithm>
-#include <cerrno>
 #include <cstdio>
 #include <cstdlib> // bsearch()
 #include <string_view>

libtransmission/blocklist.h

@@ -9,6 +9,8 @@
 #error only libtransmission should #include this header.
 #endif
 
+#include <cstddef> // for size_t
+#include <cstdint>
 #include <string>
 #include <string_view>
 #include <vector>

libtransmission/cache.cc

@@ -6,6 +6,7 @@
 #include <cstdlib> // std::lldiv()
 #include <iterator> // std::distance(), std::next(), std::prev()
 #include <limits> // std::numeric_limits<size_t>::max()
+#include <memory>
 #include <numeric> // std::accumulate()
 #include <utility> // std::make_pair()
 #include <vector>

libtransmission/cache.h

@@ -9,10 +9,11 @@
 #error only libtransmission should #include this header.
 #endif
 
-#include <cstdint> // intX_t, uintX_t
+#include <cstdint> // for size_t
+#include <cstdint> // for intX_t, uintX_t
 #include <ctime>
-#include <memory> // std::unique_ptr
-#include <utility> // std::pair
+#include <memory> // for std::unique_ptr
+#include <utility> // for std::pair
 #include <vector>
 
 #include "transmission.h"

libtransmission/completion.cc

@@ -5,6 +5,7 @@
 
 #include <algorithm>
 #include <memory>
+#include <utility>
 #include <vector>
 
 #include "transmission.h"

libtransmission/crypto-utils-cyassl.cc

@@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.
 
+#include <memory>
 #include <mutex>
 
 #if defined(CYASSL_IS_WOLFSSL)

libtransmission/crypto-utils-openssl.cc

@@ -8,6 +8,8 @@
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 #endif
 
+#include <memory>
+
 #include <openssl/crypto.h>
 #include <openssl/err.h>
 #include <openssl/evp.h>

libtransmission/crypto-utils-polarssl.cc

@@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.
 
+#include <memory>
 #include <mutex>
 
 #if defined(POLARSSL_IS_MBEDTLS)

libtransmission/crypto-utils.h

@@ -8,6 +8,7 @@
 
 #include <array>
 #include <cstddef> // size_t
+#include <cstdint>
 #include <memory>
 #include <optional>
 #include <string>

libtransmission/file-win32.cc

@@ -6,6 +6,7 @@
 #include <algorithm>
 #include <array>
 #include <cctype> // for isalpha()
+#include <iterator> // for std::back_inserter
 #include <string>
 #include <string_view>
 

libtransmission/handshake.cc

@@ -9,6 +9,7 @@
 #include <chrono>
 #include <cstring>
 #include <string_view>
+#include <utility>
 
 #include <event2/buffer.h>
 

libtransmission/handshake.h

@@ -9,6 +9,7 @@
 #error only libtransmission should #include this header.
 #endif
 
+#include <cstddef> // for size_t
 #include <optional>
 #include <memory>
 

libtransmission/history.h

@@ -10,8 +10,9 @@
 #endif
 
 #include <array>
-#include <cstdint>
-#include <ctime> // time_t
+#include <cstddef> // for size_t
+#include <cstdint> // for uint32_t
+#include <ctime> // for time_t
 
 /**
  * A short-term memory object that remembers how many times something

libtransmission/lru-cache.h

@@ -10,6 +10,7 @@
 #include <cstddef>
 #include <cstdint>
 #include <functional>
+#include <utility>
 
 // A fixed-size cache that erases least-recently-used items to make room for new ones.
 template<typename Key, typename Val, std::size_t N>

libtransmission/makemeta.cc

@@ -3,11 +3,13 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.
 
+#include <cerrno> // for ENOENT
 #include <optional>
 #include <set>
 #include <string>
 #include <string_view>
 #include <thread>
+#include <utility>
 #include <vector>
 
 #include <fmt/format.h>

libtransmission/makemeta.h

@@ -7,6 +7,7 @@
 
 #include <algorithm> // std::move
 #include <cstddef> // std::byte
+#include <cstdint>
 #include <future>
 #include <string>
 #include <string_view>

libtransmission/natpmp_local.h

@@ -10,6 +10,7 @@
 #endif
 
 #include <ctime> // time_t
+#include <cstdint>
 
 #include "transmission.h" // tr_port_forwarding
 

libtransmission/net.h

@@ -18,7 +18,7 @@
 #ifdef _WIN32
 #include <ws2tcpip.h>
 #else
-#include <errno.h>
+#include <cerrno>
 #include <sys/socket.h>
 #include <netinet/in.h>
 #endif

libtransmission/open-files.cc

@@ -5,9 +5,9 @@
 
 #include <algorithm>
 #include <array>
-#include <cerrno>
 #include <cstdint> // uint8_t, uint64_t
 #include <string_view>
+#include <utility>
 
 #include <fmt/core.h>
 

libtransmission/open-files.h

@@ -9,7 +9,8 @@
 #error only libtransmission should #include this header.
 #endif
 
-#include <cstdint>
+#include <cstddef> // for size_t
+#include <cstdint> // for uintX_t
 #include <optional>
 #include <string_view>
 #include <utility>

libtransmission/peer-mgr-wishlist.cc

@@ -5,7 +5,6 @@
 
 #include <algorithm>
 #include <cstddef>
-#include <iterator>
 #include <set>
 #include <utility>
 #include <vector>

libtransmission/peer-mgr.h

@@ -12,6 +12,7 @@
 #include <cstddef> // size_t
 #include <cstdint> // uint8_t, uint64_t
 #include <string>
+#include <utility>
 #include <vector>
 
 #ifdef _WIN32

libtransmission/peer-msgs.cc

@@ -13,6 +13,7 @@
 #include <map>
 #include <memory> // std::unique_ptr
 #include <optional>
+#include <utility>
 #include <vector>
 
 #include <event2/buffer.h>

libtransmission/peer-msgs.h

@@ -12,6 +12,7 @@
 #include <cstdint> // int8_t
 #include <cstddef> // size_t
 #include <ctime> // time_t
+#include <utility>
 
 #include "bitfield.h"
 #include "peer-common.h"

libtransmission/platform.cc

@@ -5,10 +5,10 @@
 
 #include <algorithm>
 #include <array>
-#include <iterator>
 #include <list>
 #include <string>
 #include <string_view>
+#include <utility>
 #include <vector>
 
 #ifdef __HAIKU__

libtransmission/port-forwarding.cc

@@ -5,6 +5,7 @@
 
 #include <algorithm>
 #include <chrono>
+#include <memory>
 
 #include <fmt/core.h>
 

libtransmission/rpc-server.cc

@@ -5,12 +5,13 @@
 
 #include <algorithm>
 #include <array>
-#include <cerrno>
 #include <chrono>
 #include <cstring> /* memcpy */
 #include <ctime>
+#include <memory>
 #include <string>
 #include <string_view>
+#include <utility>
 #include <vector>
 
 #ifndef _WIN32

libtransmission/rpcimpl.cc

@@ -8,6 +8,7 @@
 #include <cerrno>
 #include <ctime>
 #include <iterator>
+#include <memory>
 #include <numeric>
 #include <set>
 #include <string_view>

libtransmission/session.cc

@@ -4,7 +4,6 @@
 // License text can be found in the licenses/ folder.
 
 #include <algorithm> // std::partial_sort(), std::min(), std::max()
-#include <cerrno> /* ENOENT */
 #include <climits> /* INT_MAX */
 #include <condition_variable>
 #include <csignal>
@@ -18,6 +17,7 @@
 #include <string>
 #include <string_view>
 #include <unordered_set>
+#include <utility>
 #include <vector>
 
 #ifndef _WIN32

libtransmission/stats.h

@@ -9,6 +9,7 @@
 #error only libtransmission should #include this header.
 #endif
 
+#include <cstdint>
 #include <ctime>
 #include <string>
 #include <string_view>

libtransmission/subprocess-win32.cc

@@ -5,7 +5,6 @@
 
 #include <algorithm>
 #include <climits>
-#include <cstdlib>
 #include <cstring>
 #include <cwchar>
 #include <map>

libtransmission/timer-ev.cc

@@ -5,6 +5,7 @@
 
 #include <chrono>
 #include <memory>
+#include <utility>
 
 #include <event2/event.h>
 

libtransmission/timer-ev.h

@@ -5,6 +5,8 @@
 
 #pragma once
 
+#include <memory>
+
 #include "timer.h"
 
 extern "C"

libtransmission/timer.h

@@ -8,6 +8,7 @@
 #include <chrono>
 #include <functional>
 #include <memory>
+#include <utility>
 
 namespace libtransmission
 {

libtransmission/torrent-ctor.cc

@@ -7,6 +7,7 @@
 #include <optional>
 #include <string>
 #include <string_view>
+#include <utility>
 #include <vector>
 
 #include "transmission.h"

libtransmission/torrent-files.cc

@@ -10,6 +10,7 @@
 #include <set>
 #include <string>
 #include <string_view>
+#include <utility>
 
 #include <fmt/format.h>
 

libtransmission/torrent-metainfo.cc

@@ -6,6 +6,7 @@
 #include <algorithm>
 #include <array>
 #include <cctype>
+#include <cerrno> // for EINVAL
 #include <string>
 #include <string_view>
 #include <vector>

libtransmission/torrent.cc

@@ -14,6 +14,7 @@
 #include <string>
 #include <string_view>
 #include <unordered_map>
+#include <utility>
 #include <vector>
 
 #ifndef _WIN32

libtransmission/torrent.h

@@ -14,6 +14,7 @@
 #include <optional>
 #include <string>
 #include <string_view>
+#include <utility>
 #include <vector>
 
 #include "transmission.h"

libtransmission/torrents.h

@@ -11,6 +11,7 @@
 
 #include <ctime>
 #include <string_view>
+#include <utility>
 #include <vector>
 
 #include "transmission.h"

libtransmission/tr-assert.mm

@@ -5,6 +5,8 @@
 
 #import <Foundation/Foundation.h>
 
+#include <cstdlib> // for abort()
+
 #include <fmt/format.h>
 
 #include "tr-assert.h"

libtransmission/tr-dht.cc

@@ -5,11 +5,13 @@
 #include <algorithm>
 #include <cerrno>
 #include <chrono>
-#include <csignal> /* sig_atomic_t */
+#include <csignal> // for sig_atomic_t
+#include <cstdlib> // for abort()
 #include <cstdio>
-#include <cstring> /* memcpy(), memset() */
+#include <cstring> // for memcpy(), memset()
 #include <ctime>
 #include <fstream>
+#include <memory>
 #include <sstream>
 #include <string>
 #include <string_view>

libtransmission/tr-lpd.cc

@@ -7,6 +7,7 @@
 #include <chrono>
 #include <csignal> /* sig_atomic_t */
 #include <cstring> /* strlen(), strncpy(), strstr(), memset() */
+#include <memory>
 #include <type_traits>
 
 #ifdef _WIN32

libtransmission/tr-popcount.h

@@ -3,10 +3,14 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.
 
+#ifndef __TRANSMISSION__
+#error only libtransmission should #include this header.
+#endif
+
 #ifndef TR_POPCNT_H
 #define TR_POPCNT_H
 
-#include <stdint.h>
+#include <cstdint>
 
 /* Avoid defining irrelevant helpers that might interfere with other
  * preprocessor logic. */

libtransmission/tr-strbuf.h

@@ -7,6 +7,7 @@
 
 #include <cstddef>
 #include <string_view>
+#include <utility>
 
 #include <fmt/format.h>
 

libtransmission/tr-udp.cc

@@ -2,6 +2,7 @@
 // It may be used under the MIT (SPDX: MIT) license.
 // License text can be found in the licenses/ folder.
 
+#include <cerrno>
 #include <cstdint>
 #include <cstring> /* memcmp(), memcpy(), memset() */
 #include <cstdlib> /* malloc(), free() */

libtransmission/trevent.cc

@@ -9,6 +9,7 @@
 #include <mutex>
 #include <shared_mutex>
 #include <thread>
+#include <utility>
 
 #include <csignal>
 

libtransmission/upnp.cc

@@ -8,6 +8,7 @@
 #include <mutex>
 #include <string>
 #include <thread>
+#include <utility>
 
 #include <fmt/core.h>
 

libtransmission/utils.cc

@@ -13,6 +13,7 @@
 #include <cstdlib> // getenv()
 #include <cstring> /* strerror() */
 #include <ctime> // nanosleep()
+#include <iterator> // for std::back_inserter
 #include <set>
 #include <string>
 #include <string_view>

libtransmission/variant.cc

@@ -4,7 +4,6 @@
 // License text can be found in the licenses/ folder.
 
 #include <algorithm> // std::sort
-#include <cerrno>
 #include <cstring>
 #include <stack>
 #include <string>

libtransmission/watchdir-base.h

@@ -7,11 +7,14 @@
 
 #include <algorithm>
 #include <chrono>
+#include <cstddef> // for size_t
 #include <map>
 #include <memory>
 #include <optional>
 #include <set>
 #include <string>
+#include <string_view>
+#include <utility>
 
 #include "timer.h"
 #include "watchdir.h"

libtransmission/watchdir-generic.cc

@@ -5,6 +5,8 @@
 
 #define LIBTRANSMISSION_WATCHDIR_MODULE
 
+#include <utility>
+
 #include "transmission.h"
 
 #include "watchdir-base.h"

libtransmission/watchdir-inotify.cc

@@ -5,8 +5,8 @@
 
 #include <cerrno>
 #include <climits> /* NAME_MAX */
-
-#include <iostream> // NOCOMMIT
+#include <memory>
+#include <utility>
 
 #include <unistd.h> /* close() */
 

libtransmission/watchdir-kqueue.cc

@@ -4,8 +4,9 @@
 // License text can be found in the licenses/ folder.
 
 #include <cerrno> // for errno
+#include <memory>
 #include <string>
-#include <unordered_set>
+#include <utility>
 
 #include <fcntl.h> // for open()
 #include <unistd.h> // for close()

libtransmission/watchdir-win32.cc

@@ -6,6 +6,8 @@
 #include <array>
 #include <cerrno>
 #include <cstddef> // for offsetof
+#include <memory>
+#include <utility>
 
 #include <process.h> // for _beginthreadex()
 

libtransmission/web-utils.cc

@@ -6,11 +6,13 @@
 #include <algorithm>
 #include <array>
 #include <cctype>
+#include <cstdlib> // for strtoul()
 #include <cstddef>
 #include <limits>
 #include <optional>
 #include <string>
 #include <string_view>
+#include <utility>
 
 #include <fmt/format.h>
 

libtransmission/web.cc

@@ -11,6 +11,7 @@
 #include <mutex>
 #include <string>
 #include <thread>
+#include <utility>
 
 #ifdef _WIN32
 #include <windows.h>

libtransmission/web.h

@@ -11,6 +11,7 @@
 #include <optional>
 #include <string>
 #include <string_view>
+#include <utility>
 
 struct evbuffer;
 

libtransmission/webseed.cc

@@ -11,6 +11,7 @@
 #include <set>
 #include <string>
 #include <string_view>
+#include <utility>
 #include <vector>
 
 #include <event2/buffer.h>

macosx/CreatorWindowController.mm

@@ -6,6 +6,7 @@
 #include <cmath>
 #include <future>
 #include <optional>
+#include <utility>
 
 #include <libtransmission/transmission.h>
 

qt/DetailsDialog.cc

@@ -6,6 +6,7 @@
 #include <algorithm>
 #include <cassert>
 #include <ctime>
+#include <utility>
 
 #include <QDateTime>
 #include <QDesktopServices>

qt/FileTreeItem.cc

@@ -6,6 +6,7 @@
 #include <algorithm>
 #include <cassert>
 #include <set>
+#include <utility>
 
 #include <QApplication>
 #include <QStyle>

qt/FilterBar.cc

@@ -8,6 +8,7 @@
 #include <cstdint> // uint64_t
 #include <map>
 #include <unordered_map>
+#include <utility>
 
 #include <QHBoxLayout>
 #include <QLabel>

qt/MakeDialog.cc

@@ -7,6 +7,7 @@
 
 #include <chrono>
 #include <future>
+#include <utility>
 #include <vector>
 
 #include <QDir>

qt/OptionsDialog.cc

@@ -4,6 +4,7 @@
 // License text can be found in the licenses/ folder.
 
 #include <algorithm>
+#include <utility>
 
 #include <QFileInfo>
 #include <QPushButton>

qt/Prefs.cc

@@ -6,8 +6,8 @@
 #include <algorithm>
 #include <array>
 #include <cassert>
-#include <cstdlib>
 #include <string_view>
+#include <utility>
 
 #include <QDateTime>
 #include <QDir>

qt/RelocateDialog.cc

@@ -3,6 +3,8 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.
 
+#include <utility>
+
 #include <QDir>
 
 #include "RelocateDialog.h"

qt/Torrent.cc

@@ -4,7 +4,6 @@
 // License text can be found in the licenses/ folder.
 
 #include <algorithm>
-#include <iterator>
 #include <set>
 
 #include <QApplication>

qt/TorrentDelegate.cc

@@ -3,6 +3,8 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.
 
+#include <utility>
+
 #include <QApplication>
 #include <QFont>
 #include <QFontMetrics>

qt/TorrentDelegateMin.cc

@@ -4,6 +4,7 @@
 // License text can be found in the licenses/ folder.
 
 #include <algorithm>
+#include <utility>
 
 #include <QApplication>
 #include <QBrush>

qt/TorrentModel.cc

@@ -5,6 +5,8 @@
 
 #include <algorithm>
 #include <cassert>
+#include <iterator> // for std::back_inserter
+#include <set>
 #include <string_view>
 
 #include <libtransmission/transmission.h>

qt/TorrentModel.h

@@ -6,6 +6,7 @@
 #pragma once
 
 #include <optional>
+#include <utility>
 #include <vector>
 
 #include <QAbstractListModel>

qt/Utils.cc

@@ -3,10 +3,6 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.
 
-#include <set>
-#include <unordered_map>
-#include <unordered_set>
-
 #include <QAbstractItemView>
 #include <QApplication>
 #include <QColor>

qt/Utils.h

@@ -6,6 +6,7 @@
 #pragma once
 
 #include <cstddef> // size_t
+#include <utility>
 
 #include <QHash>
 #include <QPointer>

tests/libtransmission/copy-test.cc

@@ -4,6 +4,7 @@
 // License text can be found in the licenses/ folder.
 
 #include <algorithm>
+#include <cstring>
 #include <vector>
 
 #include "transmission.h"

tests/libtransmission/handshake-test.cc

@@ -6,7 +6,6 @@
 #include <algorithm>
 #include <array>
 #include <cassert>
-#include <cstring>
 #include <string_view>
 
 #include <event2/util.h>

tests/libtransmission/json-test.cc

@@ -6,7 +6,6 @@
 #define LIBTRANSMISSION_VARIANT_MODULE
 
 #include <clocale> // setlocale()
-#include <cstring> // strlen()
 #include <string>
 #include <string_view>
 

tests/libtransmission/makemeta-test.cc

@@ -6,7 +6,6 @@
 #include <algorithm>
 #include <array>
 #include <cstdlib> // mktemp()
-#include <cstring> // strlen()
 #include <numeric>
 #include <string>
 #include <string_view>

tests/libtransmission/peer-msgs-test.cc

@@ -3,6 +3,8 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.
 
+#include <cstring>
+
 #include "transmission.h"
 #include "peer-msgs.h"
 

tests/libtransmission/rename-test.cc

@@ -17,7 +17,6 @@
 #include <array>
 #include <cerrno>
 #include <cstdio> // fopen()
-#include <cstring> // strcmp()
 #include <string>
 #include <string_view>
 

tests/libtransmission/strbuf-test.cc

@@ -3,6 +3,7 @@
 // or any future license endorsed by Mnemosyne LLC.
 // License text can be found in the licenses/ folder.
 
+#include <cstring>
 #include <string_view>
 
 #include "transmission.h"