From 2a65169461fc4d0cad1c7ff062cc272261cd7674 Mon Sep 17 00:00:00 2001
From: Dmitry Serov <barbari100@gmail.com>
Date: Fri, 3 Nov 2023 17:50:45 +0000
Subject: [PATCH] refactor: remove unnecessary NSNotificationCenter observer
 removals (#5118)

---
 macosx/AddMagnetWindowController.mm  | 5 -----
 macosx/AddWindowController.mm        | 2 --
 macosx/DragOverlayWindow.mm          | 5 -----
 macosx/FilterBarController.mm        | 5 -----
 macosx/InfoActivityViewController.mm | 5 -----
 macosx/InfoOptionsViewController.mm  | 5 -----
 macosx/InfoWindowController.mm       | 2 --
 macosx/MessageWindowController.mm    | 1 -
 macosx/PrefsController.mm            | 2 --
 macosx/StatusBarController.mm        | 5 -----
 macosx/Torrent.mm                    | 5 -----
 macosx/TorrentTableView.mm           | 5 -----
 12 files changed, 47 deletions(-)

diff --git a/macosx/AddMagnetWindowController.mm b/macosx/AddMagnetWindowController.mm
index 10a540e37..dc3dc6e30 100644
--- a/macosx/AddMagnetWindowController.mm
+++ b/macosx/AddMagnetWindowController.mm
@@ -106,11 +106,6 @@ typedef NS_ENUM(NSUInteger, PopupPriority) {
     }
 }
 
-- (void)dealloc
-{
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-}
-
 - (void)setDestination:(id)sender
 {
     NSOpenPanel* panel = [NSOpenPanel openPanel];
diff --git a/macosx/AddWindowController.mm b/macosx/AddWindowController.mm
index 80fd0dc3c..9b06af769 100644
--- a/macosx/AddWindowController.mm
+++ b/macosx/AddWindowController.mm
@@ -176,8 +176,6 @@ typedef NS_ENUM(NSUInteger, PopupPriority) {
 
 - (void)dealloc
 {
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-
     [_fTimer invalidate];
 }
 
diff --git a/macosx/DragOverlayWindow.mm b/macosx/DragOverlayWindow.mm
index 963c531f0..31469d8b9 100644
--- a/macosx/DragOverlayWindow.mm
+++ b/macosx/DragOverlayWindow.mm
@@ -50,11 +50,6 @@
     return self;
 }
 
-- (void)dealloc
-{
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-}
-
 - (void)setTorrents:(NSArray<NSString*>*)files
 {
     uint64_t size = 0;
diff --git a/macosx/FilterBarController.mm b/macosx/FilterBarController.mm
index abcfca053..7b1247e4a 100644
--- a/macosx/FilterBarController.mm
+++ b/macosx/FilterBarController.mm
@@ -140,11 +140,6 @@ typedef NS_ENUM(NSInteger, FilterTypeTag) {
     self.fSearchField.delegate = self;
 }
 
-- (void)dealloc
-{
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-}
-
 - (void)setFilter:(id)sender
 {
     NSString* oldFilterType = [NSUserDefaults.standardUserDefaults stringForKey:@"Filter"];
diff --git a/macosx/InfoActivityViewController.mm b/macosx/InfoActivityViewController.mm
index 6952546d2..0242a7f4e 100644
--- a/macosx/InfoActivityViewController.mm
+++ b/macosx/InfoActivityViewController.mm
@@ -69,11 +69,6 @@ static CGFloat const kStackViewVerticalSpacing = 8.0;
     [self checkWindowSize];
 }
 
-- (void)dealloc
-{
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-}
-
 - (CGFloat)fHorizLayoutHeight
 {
     return NSHeight(self.fTransferView.frame) + 2 * kStackViewInset;
diff --git a/macosx/InfoOptionsViewController.mm b/macosx/InfoOptionsViewController.mm
index b65ae46cd..6754bae6a 100644
--- a/macosx/InfoOptionsViewController.mm
+++ b/macosx/InfoOptionsViewController.mm
@@ -84,11 +84,6 @@ static CGFloat const kStackViewSpacing = 8.0;
                                              object:nil];
 }
 
-- (void)dealloc
-{
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-}
-
 - (CGFloat)fHorizLayoutHeight
 {
     return NSHeight(self.fPriorityView.frame) + 2 * kStackViewInset;
diff --git a/macosx/InfoWindowController.mm b/macosx/InfoWindowController.mm
index 28603184a..f874cb47b 100644
--- a/macosx/InfoWindowController.mm
+++ b/macosx/InfoWindowController.mm
@@ -171,8 +171,6 @@ typedef NS_ENUM(NSUInteger, TabTag) {
 
 - (void)dealloc
 {
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-
     if ([_fViewController respondsToSelector:@selector(saveViewSize)])
     {
         [_fViewController saveViewSize];
diff --git a/macosx/MessageWindowController.mm b/macosx/MessageWindowController.mm
index 216fa46b2..9286cb10c 100644
--- a/macosx/MessageWindowController.mm
+++ b/macosx/MessageWindowController.mm
@@ -141,7 +141,6 @@ static NSTimeInterval const kUpdateSeconds = 0.75;
 
 - (void)dealloc
 {
-    [NSNotificationCenter.defaultCenter removeObserver:self];
     [_fTimer invalidate];
 }
 
diff --git a/macosx/PrefsController.mm b/macosx/PrefsController.mm
index b06658b03..be55bbef5 100644
--- a/macosx/PrefsController.mm
+++ b/macosx/PrefsController.mm
@@ -188,8 +188,6 @@ static NSString* const kWebUIURLFormat = @"http://localhost:%ld/";
 
 - (void)dealloc
 {
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-
     [_fPortStatusTimer invalidate];
     if (_fPortChecker)
     {
diff --git a/macosx/StatusBarController.mm b/macosx/StatusBarController.mm
index d4609fa02..0b6c66d0e 100644
--- a/macosx/StatusBarController.mm
+++ b/macosx/StatusBarController.mm
@@ -73,11 +73,6 @@ typedef NS_ENUM(NSUInteger, StatusTag) {
                                              object:nil];
 }
 
-- (void)dealloc
-{
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-}
-
 - (void)updateWithDownload:(CGFloat)dlRate upload:(CGFloat)ulRate
 {
     //set rates
diff --git a/macosx/Torrent.mm b/macosx/Torrent.mm
index 2227b8be0..6de82b6b2 100644
--- a/macosx/Torrent.mm
+++ b/macosx/Torrent.mm
@@ -168,11 +168,6 @@ bool trashDataFile(char const* filename, void* /*user_data*/, tr_error** error)
     };
 }
 
-- (void)dealloc
-{
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-}
-
 - (NSString*)description
 {
     return [@"Torrent: " stringByAppendingString:self.name];
diff --git a/macosx/TorrentTableView.mm b/macosx/TorrentTableView.mm
index 352040354..1efabcbff 100644
--- a/macosx/TorrentTableView.mm
+++ b/macosx/TorrentTableView.mm
@@ -112,11 +112,6 @@ static NSTimeInterval const kToggleProgressSeconds = 0.175;
     return self;
 }
 
-- (void)dealloc
-{
-    [NSNotificationCenter.defaultCenter removeObserver:self];
-}
-
 - (void)awakeFromNib
 {
     [NSNotificationCenter.defaultCenter addObserver:self selector:@selector(refreshTorrentTable) name:@"RefreshTorrentTable"