mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

fix: add missing `settings.json` docs and app defaults (#7218) 

* docs: `trash-can-enabled` gtk only

* fix: add `pidfile` to daemon app defaults

* perf: don't copy string literal to variant
This commit is contained in:
Yat Ho 2024-11-01 11:14:44 +08:00 committed by GitHub
parent 1f36458e10
commit 2c82f3d83d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
daemon/daemon.cc
View File

@ -379,11 +379,12 @@ tr_rpc_callback_status on_rpc_callback(tr_session* /*session*/, tr_rpc_callback_
tr_variant load_settings(char const* config_dir)
{
auto app_defaults = tr_variant::make_map();
tr_variantDictAddStr(&app_defaults, TR_KEY_watch_dir, ""sv);
tr_variantDictAddStrView(&app_defaults, TR_KEY_watch_dir, ""sv);
tr_variantDictAddBool(&app_defaults, TR_KEY_watch_dir_enabled, false);
tr_variantDictAddBool(&app_defaults, TR_KEY_watch_dir_force_generic, false);
tr_variantDictAddBool(&app_defaults, TR_KEY_rpc_enabled, true);
tr_variantDictAddBool(&app_defaults, TR_KEY_start_paused, false);
tr_variantDictAddStrView(&app_defaults, TR_KEY_pidfile, ""sv);
return tr_sessionLoadSettings(&app_defaults, config_dir, MyName);
}

1
docs/Editing-Configuration-Files.md
View File

@ -63,6 +63,7 @@ Here is a sample of the three basic types: respectively Boolean, Number and Stri
* **rename-partial-files:** Boolean (default = true) Postfix partially downloaded files with ".part".
* **start-added-torrents:** Boolean (default = true) Start torrents as soon as they are added.
* **trash-can-enabled:** Boolean (default = true) Whether to move the torrents to the system's trashcan or unlink them right away upon deletion from Transmission.
_Note: transmission-gtk only._
* **trash-original-torrent-files:** Boolean (default = false) Delete torrents added from the watch directory.
* **umask:** String (default = "022") Sets Transmission's file mode creation mask. See [the umask(2) manpage](https://man7.org/linux/man-pages/man2/umask.2.html) for more information.
* **watch-dir:** String