From 2ef53ca5ddef0f85aa8275446d6297ce03bb9f1d Mon Sep 17 00:00:00 2001 From: Jordan Lee Date: Mon, 29 Aug 2011 20:29:45 +0000 Subject: [PATCH] #4455 'Action on N>1 torrents doesn't work properly in web interface' -- when right-clicking in the torrent list, don't change the selection if the row we're hovering over is already selected. --- web/javascript/transmission.js | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/web/javascript/transmission.js b/web/javascript/transmission.js index 061412c0f..802de2dbc 100644 --- a/web/javascript/transmission.js +++ b/web/javascript/transmission.js @@ -289,14 +289,11 @@ Transmission.prototype = boundingElement: $('div#torrent_container'), boundingRightPad: 20, boundingBottomPad: 5, - onContextMenu: function(e) { - var closest_row = $(e.target).closest('.torrent')[0]; - for (var i=0, row; row = tr._rows[i]; ++i) { - if (row.getElement() === closest_row) { - tr.setSelectedRow(row); - break; - } - } + onContextMenu: function(ev) { + var element = $(ev.target).closest('.torrent')[0]; + var i = $('#torrent_list > li').index(element); + if ((i!==-1) && !tr._rows[i].isSelected()) + tr.setSelectedRow(tr._rows[i]); return true; } });