From 33e2ece7e5bc261566ae9e8db57be0b3247508d1 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Sun, 17 Feb 2019 10:24:31 +0000 Subject: [PATCH] Silence coverity CHECKED_RETURN writing benc strs saveStringFunc() gets the target string by calling tr_variantGetStr(). It previously didn't check to see if this function succeeded because saveStringFunc() isn't reached without the type already being known. However, checking the return value costs nothing and makes Coverity happy. --- libtransmission/variant-benc.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libtransmission/variant-benc.c b/libtransmission/variant-benc.c index 9a7faf7d9..f1fa49704 100644 --- a/libtransmission/variant-benc.c +++ b/libtransmission/variant-benc.c @@ -351,9 +351,11 @@ static void saveStringFunc(tr_variant const* v, void* evbuf) { size_t len; char const* str; - tr_variantGetStr(v, &str, &len); - evbuffer_add_printf(evbuf, "%zu:", len); - evbuffer_add(evbuf, str, len); + if (tr_variantGetStr(v, &str, &len)) + { + evbuffer_add_printf(evbuf, "%zu:", len); + evbuffer_add(evbuf, str, len); + } } static void saveDictBeginFunc(tr_variant const* val UNUSED, void* evbuf)