diff --git a/cli/cli.c b/cli/cli.c index 9686738fb..e8efb8a58 100644 --- a/cli/cli.c +++ b/cli/cli.c @@ -22,10 +22,9 @@ * DEALINGS IN THE SOFTWARE. *****************************************************************************/ -#include -#include -#include -#include +#include /* fprintf() */ +#include /* atoi() */ +#include /* memcmp() */ #include #include diff --git a/daemon/daemon.c b/daemon/daemon.c index bdffd7fdc..db734cb43 100644 --- a/daemon/daemon.c +++ b/daemon/daemon.c @@ -13,7 +13,7 @@ #include #include /* printf */ #include /* exit, atoi */ -#include /* strcmp */ +#include /* strerror() */ #include /* open */ #include diff --git a/daemon/watch.c b/daemon/watch.c index 488ef21c3..32e959bf6 100644 --- a/daemon/watch.c +++ b/daemon/watch.c @@ -20,7 +20,7 @@ #endif #include -#include /* strstr */ +#include /* strlen() */ #include /* perror() */ #include /* readdir */ diff --git a/gtk/conf.c b/gtk/conf.c index 2048dcf46..19091eb43 100644 --- a/gtk/conf.c +++ b/gtk/conf.c @@ -24,7 +24,7 @@ #include #include -#include +#include /* strtol() */ #include #include diff --git a/gtk/details.c b/gtk/details.c index 7a632fe30..6eaefa1d9 100644 --- a/gtk/details.c +++ b/gtk/details.c @@ -10,10 +10,9 @@ * $Id$ */ -#include #include -#include /* sscanf */ -#include +#include /* sscanf() */ +#include /* abort() */ #include #include diff --git a/gtk/file-list.c b/gtk/file-list.c index 0f60e88a1..bb24d1ad3 100644 --- a/gtk/file-list.c +++ b/gtk/file-list.c @@ -12,7 +12,6 @@ #include #include -#include #include #include #include diff --git a/gtk/main.c b/gtk/main.c index 1c03a5f35..28a93b0fc 100644 --- a/gtk/main.c +++ b/gtk/main.c @@ -26,7 +26,7 @@ #include #include #include -#include +#include /* exit() */ #include #include #include diff --git a/gtk/makemeta-ui.c b/gtk/makemeta-ui.c index 46d14cab7..dfa5315f5 100644 --- a/gtk/makemeta-ui.c +++ b/gtk/makemeta-ui.c @@ -10,8 +10,6 @@ * $Id$ */ -#include - #include #include diff --git a/gtk/notify.c b/gtk/notify.c index 30194b344..755d5349f 100644 --- a/gtk/notify.c +++ b/gtk/notify.c @@ -10,7 +10,7 @@ * $Id$ */ -#include +#include /* strcmp() */ #ifdef HAVE_LIBCANBERRA #include diff --git a/gtk/torrent-cell-renderer.c b/gtk/torrent-cell-renderer.c index 895df2985..82147be33 100644 --- a/gtk/torrent-cell-renderer.c +++ b/gtk/torrent-cell-renderer.c @@ -10,7 +10,6 @@ * $Id$ */ -#include /* strcmp() */ #include #include #include diff --git a/gtk/tr-prefs.c b/gtk/tr-prefs.c index fd6782022..e5adcff8b 100644 --- a/gtk/tr-prefs.c +++ b/gtk/tr-prefs.c @@ -12,7 +12,7 @@ #include /* isspace */ #include /* USHRT_MAX */ -#include /* free() */ +#include /* strcmp() */ #include #include #include diff --git a/gtk/util.c b/gtk/util.c index abe7d3ae8..dac2e6dc2 100644 --- a/gtk/util.c +++ b/gtk/util.c @@ -13,8 +13,7 @@ #include /* isxdigit() */ #include #include -#include /* free() */ -#include /* strcmp() */ +#include /* strchr(), strrchr(), strlen(), strncmp(), strstr() */ #include /* for gtr_lockfile()'s open() */ #include /* for gtr_lockfile()'s open() */ @@ -888,6 +887,6 @@ gtr_label_set_text( GtkLabel * lb, const char * newstr ) { const char * oldstr = gtk_label_get_text( lb ); - if( ( oldstr == NULL ) || strcmp( oldstr, newstr ) ) + if( tr_strcmp0( oldstr, newstr ) ) gtk_label_set_text( lb, newstr ); } diff --git a/libtransmission/JSON_parser.c b/libtransmission/JSON_parser.c index b86e310bc..e4a5574bc 100644 --- a/libtransmission/JSON_parser.c +++ b/libtransmission/JSON_parser.c @@ -68,7 +68,6 @@ SOFTWARE. #include #include -#include /* some 1.4.x versions of evutil.h need this */ #include /* evutil_strtoll() */ #include "JSON_parser.h" diff --git a/libtransmission/announcer.c b/libtransmission/announcer.c index 1ba65dabe..10b2d69f0 100644 --- a/libtransmission/announcer.c +++ b/libtransmission/announcer.c @@ -11,7 +11,7 @@ */ #include -#include +#include /* INT_MAX */ #include #include /* qsort() */ #include /* strcmp(), memcpy() */ diff --git a/libtransmission/blocklist-test.c b/libtransmission/blocklist-test.c index 767e0811a..fa6e656cb 100644 --- a/libtransmission/blocklist-test.c +++ b/libtransmission/blocklist-test.c @@ -1,6 +1,4 @@ #include -#include -#include #include "transmission.h" #include "blocklist.h" #include "net.h" diff --git a/libtransmission/blocklist.c b/libtransmission/blocklist.c index dde097811..37eae2671 100644 --- a/libtransmission/blocklist.c +++ b/libtransmission/blocklist.c @@ -10,10 +10,14 @@ * $Id$ */ +#include +#include #include -#include /* qsort(), free() */ +#include /* bsearch(), qsort() */ #include +#include /* unlink() */ + #ifdef WIN32 #include #define WINVER WindowsXP @@ -28,8 +32,6 @@ #include #include #include -#include -#include #include "transmission.h" #include "platform.h" diff --git a/libtransmission/clients-test.c b/libtransmission/clients-test.c index 0f2ed8caa..db33ebeda 100644 --- a/libtransmission/clients-test.c +++ b/libtransmission/clients-test.c @@ -1,5 +1,4 @@ #include -#include #include #include "transmission.h" #include "clients.h" diff --git a/libtransmission/clients.c b/libtransmission/clients.c index 484d2c351..75002b6d2 100644 --- a/libtransmission/clients.c +++ b/libtransmission/clients.c @@ -13,7 +13,6 @@ /* thanks amc1! */ #include /* isprint() */ -#include #include /* strtol() */ #include diff --git a/libtransmission/crypto.c b/libtransmission/crypto.c index d40d49305..36ec86665 100644 --- a/libtransmission/crypto.c +++ b/libtransmission/crypto.c @@ -12,10 +12,10 @@ #include #include /* uint8_t */ -#include /* for INT_MAX */ +#include /* INT_MAX */ #include -#include /* for abs() */ -#include /* memcpy */ +#include /* abs() */ +#include /* memcpy(), memset(), strcmp() */ #include #include diff --git a/libtransmission/fdlimit.c b/libtransmission/fdlimit.c index 856c1d8d8..39bb2958d 100644 --- a/libtransmission/fdlimit.c +++ b/libtransmission/fdlimit.c @@ -24,8 +24,6 @@ #include #include #include -#include -#include #include #ifdef SYS_DARWIN #include @@ -47,7 +45,7 @@ #include /* getrlimit */ #endif #include /* O_LARGEFILE posix_fadvise */ -#include +#include /* lseek(), write(), ftruncate(), pread(), pwrite(), etc */ #include "transmission.h" #include "fdlimit.h" diff --git a/libtransmission/handshake.c b/libtransmission/handshake.c index ecb0e460e..e670e2ffa 100644 --- a/libtransmission/handshake.c +++ b/libtransmission/handshake.c @@ -15,7 +15,6 @@ #include #include /* UCHAR_MAX */ #include -#include #include diff --git a/libtransmission/inout.c b/libtransmission/inout.c index bd4213da6..5c4685579 100644 --- a/libtransmission/inout.c +++ b/libtransmission/inout.c @@ -12,8 +12,8 @@ #include #include -#include /* realloc */ -#include /* memcmp */ +#include /* bsearch() */ +#include /* memcmp() */ #include diff --git a/libtransmission/json.c b/libtransmission/json.c index 6a09ebd43..e3216a513 100644 --- a/libtransmission/json.c +++ b/libtransmission/json.c @@ -13,8 +13,6 @@ #include #include #include /* EILSEQ, EINVAL */ -#include -#include /* printf */ #include "JSON_parser.h" diff --git a/libtransmission/makemeta.c b/libtransmission/makemeta.c index a3370d959..8a3c4b2da 100644 --- a/libtransmission/makemeta.c +++ b/libtransmission/makemeta.c @@ -18,7 +18,7 @@ #include #include -#include +#include /* read() */ #include #include /* evutil_ascii_strcasecmp() */ diff --git a/libtransmission/net.c b/libtransmission/net.c index ead66df6a..014ec8991 100644 --- a/libtransmission/net.c +++ b/libtransmission/net.c @@ -24,8 +24,6 @@ *****************************************************************************/ #include -#include -#include #include #include @@ -40,9 +38,7 @@ #include #include /* inet_addr */ #include - #include #endif -#include #include #include diff --git a/libtransmission/peer-io.c b/libtransmission/peer-io.c index 057e76e47..a352fa36e 100644 --- a/libtransmission/peer-io.c +++ b/libtransmission/peer-io.c @@ -14,8 +14,6 @@ #include #include /* INT_MAX */ #include -#include -#include #ifdef WIN32 #include diff --git a/libtransmission/port-forwarding.c b/libtransmission/port-forwarding.c index 031c8121a..46aa0d9fb 100644 --- a/libtransmission/port-forwarding.c +++ b/libtransmission/port-forwarding.c @@ -11,7 +11,6 @@ */ #include -#include #include #include diff --git a/libtransmission/rpc-server.c b/libtransmission/rpc-server.c index 731181c87..774e67777 100644 --- a/libtransmission/rpc-server.c +++ b/libtransmission/rpc-server.c @@ -15,9 +15,6 @@ #include /* memcpy */ #include /* INT_MAX */ -#include /* open */ -#include /* open */ -#include /* open */ #include /* close */ #ifdef HAVE_ZLIB diff --git a/libtransmission/tr-udp.c b/libtransmission/tr-udp.c index 6797f7100..45b7d575f 100644 --- a/libtransmission/tr-udp.c +++ b/libtransmission/tr-udp.c @@ -21,11 +21,12 @@ THE SOFTWARE. */ -#include #include #include /* memcmp(), memcpy(), memset() */ #include /* malloc(), free() */ +#include /* close() */ + #include #include "transmission.h" diff --git a/libtransmission/tr-utp.c b/libtransmission/tr-utp.c index 71712b0d4..b22c3dc53 100644 --- a/libtransmission/tr-utp.c +++ b/libtransmission/tr-utp.c @@ -22,9 +22,9 @@ THE SOFTWARE. */ #include -#include #include + #include #include "transmission.h" diff --git a/libtransmission/trevent.c b/libtransmission/trevent.c index a72496dd5..1aeb4961b 100644 --- a/libtransmission/trevent.c +++ b/libtransmission/trevent.c @@ -12,9 +12,7 @@ #include #include -#include #include -#include #include @@ -125,7 +123,7 @@ piperead( int s, char *buf, int len ) #define pipewrite(a,b,c) write(a,b,c) #endif -#include +#include /* read(), write(), pipe() */ #include "transmission.h" #include "platform.h" diff --git a/libtransmission/utils.c b/libtransmission/utils.c index a5237e5eb..9511142ce 100644 --- a/libtransmission/utils.c +++ b/libtransmission/utils.c @@ -22,7 +22,7 @@ #endif #include -#include /* isalpha(), tolower() */ +#include /* isdigit(), isalpha(), tolower() */ #include #include /* DBL_EPSILON */ #include /* localeconv() */ @@ -40,7 +40,7 @@ #include #include #include -#include /* stat(), getcwd(), getpagesize() */ +#include /* stat(), getcwd(), getpagesize(), unlink() */ #include #include