feat: WebUI add `Error` case in port test result (#6607)
* refactor: do not rely on port test response to determine ip protocol * feat: show `Error` in port test if no result is returned
This commit is contained in:
parent
ee12d697cf
commit
41566cfd0b
|
@ -48,20 +48,27 @@ export class PrefsDialog extends EventTarget {
|
||||||
)) {
|
)) {
|
||||||
delete element.dataset.open;
|
delete element.dataset.open;
|
||||||
setTextContent(element, 'Checking...');
|
setTextContent(element, 'Checking...');
|
||||||
this.remote.checkPort(key, this._onPortChecked, this);
|
this.remote.checkPort(
|
||||||
|
key,
|
||||||
|
(response) => this._onPortChecked(key, response),
|
||||||
|
this,
|
||||||
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
_onPortChecked(response) {
|
_onPortChecked(ipProtocol, response) {
|
||||||
if (this.closed) {
|
if (this.closed) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
const element =
|
const element = this.elements.network.port_status_label[ipProtocol];
|
||||||
this.elements.network.port_status_label[response.arguments['ipProtocol']];
|
|
||||||
const is_open = response.arguments['port-is-open'] || false;
|
const is_open = response.arguments['port-is-open'] || false;
|
||||||
element.dataset.open = is_open;
|
element.dataset.open = is_open;
|
||||||
setTextContent(element, is_open ? 'Open' : 'Closed');
|
if ('port-is-open' in response.arguments) {
|
||||||
|
setTextContent(element, is_open ? 'Open' : 'Closed');
|
||||||
|
} else {
|
||||||
|
setTextContent(element, 'Error');
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
_setBlocklistButtonEnabled(b) {
|
_setBlocklistButtonEnabled(b) {
|
||||||
|
|
Loading…
Reference in New Issue