mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-03-16 08:49:47 +00:00
Code Issues Releases Wiki Activity

chore: disable flaky unit tests (#4808)

Browse source 
This shouldn't be a long-term fix -- each of these tests should be fixed
instead of disabled -- but they are causing so much noise in CI that I'm
disabling them for now and then they can be re-enabled when fixed.

Fixes #4747.
This commit is contained in:
Charles Kerr 2023-02-10 17:35:22 -06:00 • committed by GitHub
parent b64e65cf2e
commit 42a01068c6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/libtransmission/lpd-test.cc
View file

@ -101,7 +101,7 @@ TEST_F(LpdTest, HelloWorld)
EXPECT_EQ(0U, std::size(mediator.found_));
}
TEST_F(LpdTest, CanAnnounceAndRead)
TEST_F(LpdTest, DISABLED_CanAnnounceAndRead)
{
auto mediator_a = MyMediator{ *session_ };
auto lpd_a = tr_lpd::create(mediator_a, session_->eventBase());
@ -123,7 +123,7 @@ TEST_F(LpdTest, CanAnnounceAndRead)
EXPECT_EQ(0U, mediator_b.found_.count(info_hash_str));
}
TEST_F(LpdTest, canMultiAnnounce)
TEST_F(LpdTest, DISABLED_canMultiAnnounce)
{
auto mediator_a = MyMediator{ *session_ };
auto lpd_a = tr_lpd::create(mediator_a, session_->eventBase());
@ -159,7 +159,7 @@ TEST_F(LpdTest, canMultiAnnounce)
}
}
TEST_F(LpdTest, DoesNotReannounceTooSoon)
TEST_F(LpdTest, DISABLED_DoesNotReannounceTooSoon)
{
auto mediator_a = MyMediator{ *session_ };
auto lpd_a = tr_lpd::create(mediator_a, session_->eventBase());

6
tests/libtransmission/timer-test.cc
View file

@ -203,7 +203,7 @@ TEST_F(TimerTest, restartWithDifferentInterval)
test(200ms);
}
TEST_F(TimerTest, restartWithSameInterval)
TEST_F(TimerTest, DISABLED_restartWithSameInterval)
{
auto timer_maker = EvTimerMaker{ evbase_.get() };
auto timer = timer_maker.create();
@ -232,7 +232,7 @@ TEST_F(TimerTest, restartWithSameInterval)
test(timer->interval());
}
TEST_F(TimerTest, repeatingThenSingleShot)
TEST_F(TimerTest, DISABLED_repeatingThenSingleShot)
{
auto timer_maker = EvTimerMaker{ evbase_.get() };
auto timer = timer_maker.create();
@ -274,7 +274,7 @@ TEST_F(TimerTest, repeatingThenSingleShot)
EXPECT_EQ(baseline + 1, n_calls);
}
TEST_F(TimerTest, singleShotStop)
TEST_F(TimerTest, DISABLED_singleShotStop)
{
auto timer_maker = EvTimerMaker{ evbase_.get() };
auto timer = timer_maker.create();

2
tests/libtransmission/watchdir-test.cc
View file

@ -215,7 +215,7 @@ TEST_P(WatchDirTest, watch)
EXPECT_TRUE(std::empty(names));
}
TEST_P(WatchDirTest, retry)
TEST_P(WatchDirTest, DISABLED_retry)
{
auto const path = sandboxDir();