mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-22 07:42:37 +00:00
Code Issues Releases Wiki Activity

fix: don't create all 0-byte files in MakemetaTest::makeRandomFiles() (#6394)

Browse source 
* fix: randomly failing `MakemetaTest.nameIsRootSingleFile`

* fix: eliminate remaining probability for `MakemetaTest.nameIsRootSingleFile` to fail
This commit is contained in:
Yat Ho 2023-12-24 04:49:19 +08:00 committed by GitHub
parent bfa5da9705
commit 45298e5a4e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tests/libtransmission/makemeta-test.cc
View file

@ -44,10 +44,21 @@ protected:
{
auto files = std::vector<std::pair<std::string, std::vector<std::byte>>>{};
for (size_t i = 0; i < n_files; ++i)
auto file_sizes = std::vector<size_t>(n_files);
EXPECT_EQ(std::size(file_sizes), n_files);
while (
std::all_of(std::begin(file_sizes), std::end(file_sizes), [](size_t const file_size) { return file_size == 0U; }))
{
for (auto& file_size : file_sizes)
{
file_size = tr_rand_int(max_size);
}
}
for (size_t i = 0U; i < n_files; ++i)
{
auto payload = std::vector<std::byte>{};
payload.resize(static_cast<size_t>(tr_rand_int(max_size)));
payload.resize(file_sizes[i]);
tr_rand_buffer(std::data(payload), std::size(payload));
auto filename = tr_pathbuf{ top, '/', "test.XXXXXX" };